patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Ye Xiaolong <xiaolong.ye@intel.com>
To: "Cui, LunyuanX" <lunyuanx.cui@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] net/e1000: fix link status update
Date: Mon, 18 Nov 2019 11:28:36 +0800
Message-ID: <20191118032836.GD69793@intel.com> (raw)
In-Reply-To: <D03A2340CBF5CC478EBBD0ABAE6ADB152F150E@SHSMSX101.ccr.corp.intel.com>

On 11/18, Cui, LunyuanX wrote:
>Hi, Xiaolong
>
>> -----Original Message-----
>> From: Ye, Xiaolong
>> Sent: Monday, November 18, 2019 11:07 AM
>> To: Cui, LunyuanX <lunyuanx.cui@intel.com>
>> Cc: dev@dpdk.org; Lu, Wenzhuo <wenzhuo.lu@intel.com>;
>> stable@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH v2] net/e1000: fix link status update
>> 
>> On 11/15, Lunyuan Cui wrote:
>> >Unassigned variable should not be used as judgment, and there is no
>> >need to update link status according to old link status.
>> >This patch fix the issue.
>> >
>> >Fixes: 80ba61115e77 ("net/e1000: use link status helper functions")
>> >Cc: stable@dpdk.org
>> >
>> >Signed-off-by: Lunyuan Cui <lunyuanx.cui@intel.com>
>> >---
>> > drivers/net/e1000/em_ethdev.c | 4 ++--
>> > 1 file changed, 2 insertions(+), 2 deletions(-)
>> >
>> >diff --git a/drivers/net/e1000/em_ethdev.c
>> >b/drivers/net/e1000/em_ethdev.c index 9a88b50b2..7959ee4e9 100644
>> >--- a/drivers/net/e1000/em_ethdev.c
>> >+++ b/drivers/net/e1000/em_ethdev.c
>> >@@ -1157,7 +1157,7 @@ eth_em_link_update(struct rte_eth_dev *dev,
>> int wait_to_complete)
>> > 	memset(&link, 0, sizeof(link));
>> >
>> > 	/* Now we check if a transition has happened */
>> >-	if (link_check && (link.link_status == ETH_LINK_DOWN)) {
>> >+	if (link_check) {
>> > 		uint16_t duplex, speed;
>> > 		hw->mac.ops.get_link_up_info(hw, &speed, &duplex);
>> > 		link.link_duplex = (duplex == FULL_DUPLEX) ?
>> >@@ -1167,7 +1167,7 @@ eth_em_link_update(struct rte_eth_dev *dev,
>> int wait_to_complete)
>> > 		link.link_status = ETH_LINK_UP;
>> > 		link.link_autoneg = !(dev->data->dev_conf.link_speeds &
>> > 				ETH_LINK_SPEED_FIXED);
>> >-	} else if (!link_check && (link.link_status == ETH_LINK_UP)) {
>> >+	} else {
>> > 		link.link_speed = ETH_SPEED_NUM_NONE;
>> > 		link.link_duplex = ETH_LINK_HALF_DUPLEX;
>> > 		link.link_status = ETH_LINK_DOWN;
>> 
>> I am a little confused about the variable link_check, is it used to indicate
>> whether there is link status change or link status up?
>
>The variable link_check is used to indicate link status up.
>When link_check is true, link status is up.
>When link_check is false, link status is down.

Then the link_check seems a bad name, could you help submit a patch to rename it?

@whenzhuo, could you help review/ack this change?

Thanks,
Xiaolong
>
>Thanks,
>Lunyuan
>

  reply	other threads:[~2019-11-18  3:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-13 17:32 [dpdk-stable] [PATCH] " Cui LunyuanX
2019-11-14  6:41 ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong
2019-11-15 14:48 ` [dpdk-stable] [PATCH v2] " Lunyuan Cui
2019-11-18  3:06   ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong
2019-11-18  3:21     ` Cui, LunyuanX
2019-11-18  3:28       ` Ye Xiaolong [this message]
2019-11-18 14:58   ` [dpdk-stable] [PATCH v3] " Lunyuan Cui
2019-11-18  7:23     ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong
2019-11-19  6:43     ` [dpdk-stable] " Lu, Wenzhuo
2019-11-20  9:22     ` [dpdk-stable] [PATCH v4] " Lunyuan Cui
2019-11-26  2:24       ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong
2019-11-26  2:04 ` [dpdk-stable] [PATCH] " Lu, Wenzhuo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191118032836.GD69793@intel.com \
    --to=xiaolong.ye@intel.com \
    --cc=dev@dpdk.org \
    --cc=lunyuanx.cui@intel.com \
    --cc=stable@dpdk.org \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git