patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] eal/linux: fix build when VFIO is disabled
@ 2019-12-11 18:25 Ali Alnubani
  2019-12-16 17:22 ` [dpdk-stable] [dpdk-dev] " David Marchand
  2020-01-19 22:42 ` Thomas Monjalon
  0 siblings, 2 replies; 4+ messages in thread
From: Ali Alnubani @ 2019-12-11 18:25 UTC (permalink / raw)
  To: dev; +Cc: vattunuru, stable

The header linux/version.h isn't included when CONFIG_RTE_EAL_VFIO
is explicitly disabled. LINUX_VERSION_CODE and KERNEL_VERSION are
therefore undefined, causing the build failure:

  lib/librte_eal/linux/eal/eal.c: In function ‘rte_eal_init’:
  lib/librte_eal/linux/eal/eal.c:1076:32: error: "LINUX_VERSION_CODE" is
    not defined, evaluates to 0 [-Werror=undef]

Fixes: a0dede62a537 ("eal/linux: remove KNI restriction on IOVA")
Cc: vattunuru@marvell.com
Cc: stable@dpdk.org

Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
---
 lib/librte_eal/linux/eal/eal.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/librte_eal/linux/eal/eal.c b/lib/librte_eal/linux/eal/eal.c
index c4233ec3c..9530ee55f 100644
--- a/lib/librte_eal/linux/eal/eal.c
+++ b/lib/librte_eal/linux/eal/eal.c
@@ -25,6 +25,7 @@
 #if defined(RTE_ARCH_X86)
 #include <sys/io.h>
 #endif
+#include <linux/version.h>
 
 #include <rte_compat.h>
 #include <rte_common.h>
-- 
2.11.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] eal/linux: fix build when VFIO is disabled
  2019-12-11 18:25 [dpdk-stable] [PATCH] eal/linux: fix build when VFIO is disabled Ali Alnubani
@ 2019-12-16 17:22 ` David Marchand
  2019-12-22 12:13   ` Ali Alnubani
  2020-01-19 22:42 ` Thomas Monjalon
  1 sibling, 1 reply; 4+ messages in thread
From: David Marchand @ 2019-12-16 17:22 UTC (permalink / raw)
  To: Ali Alnubani; +Cc: dev, vattunuru, stable

On Wed, Dec 11, 2019 at 7:26 PM Ali Alnubani <alialnu@mellanox.com> wrote:
> The header linux/version.h isn't included when CONFIG_RTE_EAL_VFIO
> is explicitly disabled. LINUX_VERSION_CODE and KERNEL_VERSION are
> therefore undefined, causing the build failure:
>
>   lib/librte_eal/linux/eal/eal.c: In function ‘rte_eal_init’:
>   lib/librte_eal/linux/eal/eal.c:1076:32: error: "LINUX_VERSION_CODE" is
>     not defined, evaluates to 0 [-Werror=undef]

The patch itself is ok.
But, out of curiosity, why would you disable vfio support?


-- 
David Marchand


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] eal/linux: fix build when VFIO is disabled
  2019-12-16 17:22 ` [dpdk-stable] [dpdk-dev] " David Marchand
@ 2019-12-22 12:13   ` Ali Alnubani
  0 siblings, 0 replies; 4+ messages in thread
From: Ali Alnubani @ 2019-12-22 12:13 UTC (permalink / raw)
  To: David Marchand; +Cc: dev, vattunuru, stable

> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Monday, December 16, 2019 7:22 PM
> To: Ali Alnubani <alialnu@mellanox.com>
> Cc: dev@dpdk.org; vattunuru@marvell.com; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] eal/linux: fix build when VFIO is disabled
> 
> On Wed, Dec 11, 2019 at 7:26 PM Ali Alnubani <alialnu@mellanox.com>
> wrote:
> > The header linux/version.h isn't included when CONFIG_RTE_EAL_VFIO is
> > explicitly disabled. LINUX_VERSION_CODE and KERNEL_VERSION are
> > therefore undefined, causing the build failure:
> >
> >   lib/librte_eal/linux/eal/eal.c: In function ‘rte_eal_init’:
> >   lib/librte_eal/linux/eal/eal.c:1076:32: error: "LINUX_VERSION_CODE" is
> >     not defined, evaluates to 0 [-Werror=undef]
> 
> The patch itself is ok.
> But, out of curiosity, why would you disable vfio support?

No reason. I noticed the build error by accident actually.
> 
> 
> --
> David Marchand

Regards,
Ali

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] eal/linux: fix build when VFIO is disabled
  2019-12-11 18:25 [dpdk-stable] [PATCH] eal/linux: fix build when VFIO is disabled Ali Alnubani
  2019-12-16 17:22 ` [dpdk-stable] [dpdk-dev] " David Marchand
@ 2020-01-19 22:42 ` Thomas Monjalon
  1 sibling, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2020-01-19 22:42 UTC (permalink / raw)
  To: Ali Alnubani; +Cc: dev, vattunuru, stable

11/12/2019 19:25, Ali Alnubani:
> The header linux/version.h isn't included when CONFIG_RTE_EAL_VFIO
> is explicitly disabled. LINUX_VERSION_CODE and KERNEL_VERSION are
> therefore undefined, causing the build failure:
> 
>   lib/librte_eal/linux/eal/eal.c: In function ‘rte_eal_init’:
>   lib/librte_eal/linux/eal/eal.c:1076:32: error: "LINUX_VERSION_CODE" is
>     not defined, evaluates to 0 [-Werror=undef]
> 
> Fixes: a0dede62a537 ("eal/linux: remove KNI restriction on IOVA")
> Cc: vattunuru@marvell.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ali Alnubani <alialnu@mellanox.com>

Applied, thanks



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-01-19 22:43 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-11 18:25 [dpdk-stable] [PATCH] eal/linux: fix build when VFIO is disabled Ali Alnubani
2019-12-16 17:22 ` [dpdk-stable] [dpdk-dev] " David Marchand
2019-12-22 12:13   ` Ali Alnubani
2020-01-19 22:42 ` Thomas Monjalon

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git