patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH v2 1/4] hash: fix meson headers packaging
       [not found] ` <20200129172621.28565-1-david.marchand@redhat.com>
@ 2020-01-29 17:26   ` David Marchand
  2020-01-30 10:12     ` Luca Boccassi
  0 siblings, 1 reply; 10+ messages in thread
From: David Marchand @ 2020-01-29 17:26 UTC (permalink / raw)
  To: dev
  Cc: thomas, bruce.richardson, kevin.laatz, aconole, nhorman,
	akhil.goyal, anoobj, stable, Yipeng Wang, Sameh Gobriel,
	Harry van Haaren, Luca Boccassi, Keith Wiles

Those headers are internal and should not be distributed.

Fixes: 5b9656b157d3 ("lib: build with meson")
Cc: stable@dpdk.org

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 lib/librte_hash/meson.build | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/lib/librte_hash/meson.build b/lib/librte_hash/meson.build
index 5d02b3084..bce11ad9e 100644
--- a/lib/librte_hash/meson.build
+++ b/lib/librte_hash/meson.build
@@ -1,10 +1,7 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
-headers = files('rte_cmp_arm64.h',
-	'rte_cmp_x86.h',
-	'rte_crc_arm64.h',
-	'rte_cuckoo_hash.h',
+headers = files('rte_crc_arm64.h',
 	'rte_fbk_hash.h',
 	'rte_hash_crc.h',
 	'rte_hash.h',
-- 
2.23.0


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-stable] [PATCH v2 1/4] hash: fix meson headers packaging
  2020-01-29 17:26   ` [dpdk-stable] [PATCH v2 1/4] hash: fix meson headers packaging David Marchand
@ 2020-01-30 10:12     ` Luca Boccassi
  2020-01-30 10:54       ` David Marchand
  0 siblings, 1 reply; 10+ messages in thread
From: Luca Boccassi @ 2020-01-30 10:12 UTC (permalink / raw)
  To: David Marchand, dev
  Cc: thomas, bruce.richardson, kevin.laatz, aconole, nhorman,
	akhil.goyal, anoobj, stable, Yipeng Wang, Sameh Gobriel,
	Harry van Haaren, Keith Wiles

On Wed, 2020-01-29 at 18:26 +0100, David Marchand wrote:
> Those headers are internal and should not be distributed.
> 
> Fixes: 5b9656b157d3 ("lib: build with meson")
> Cc: 
> stable@dpdk.org
> 
> 
> Signed-off-by: David Marchand <
> david.marchand@redhat.com
> >
> ---
>  lib/librte_hash/meson.build | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/lib/librte_hash/meson.build
> b/lib/librte_hash/meson.build
> index 5d02b3084..bce11ad9e 100644
> --- a/lib/librte_hash/meson.build
> +++ b/lib/librte_hash/meson.build
> @@ -1,10 +1,7 @@
>  # SPDX-License-Identifier: BSD-3-Clause
>  # Copyright(c) 2017 Intel Corporation
>  
> -headers = files('rte_cmp_arm64.h',
> -	'rte_cmp_x86.h',
> -	'rte_crc_arm64.h',
> -	'rte_cuckoo_hash.h',
> +headers = files('rte_crc_arm64.h',
>  	'rte_fbk_hash.h',
>  	'rte_hash_crc.h',
>  	'rte_hash.h',

Difficult question: how confident we are nobody is using those? :-)

-- 
Kind regards,
Luca Boccassi

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-stable] [PATCH v2 1/4] hash: fix meson headers packaging
  2020-01-30 10:12     ` Luca Boccassi
@ 2020-01-30 10:54       ` David Marchand
  2020-01-30 10:56         ` [dpdk-stable] [dpdk-dev] " Luca Boccassi
  0 siblings, 1 reply; 10+ messages in thread
From: David Marchand @ 2020-01-30 10:54 UTC (permalink / raw)
  To: Luca Boccassi
  Cc: dev, Thomas Monjalon, Bruce Richardson, Kevin Laatz,
	Aaron Conole, Neil Horman, Akhil Goyal, Anoob Joseph,
	dpdk stable, Yipeng Wang, Sameh Gobriel, Harry van Haaren,
	Keith Wiles

On Thu, Jan 30, 2020 at 11:12 AM Luca Boccassi <bluca@debian.org> wrote:
>
> On Wed, 2020-01-29 at 18:26 +0100, David Marchand wrote:
> > Those headers are internal and should not be distributed.
> >
> > Fixes: 5b9656b157d3 ("lib: build with meson")
> > Cc:
> > stable@dpdk.org
> >
> >
> > Signed-off-by: David Marchand <
> > david.marchand@redhat.com
> > >
> > ---
> >  lib/librte_hash/meson.build | 5 +----
> >  1 file changed, 1 insertion(+), 4 deletions(-)
> >
> > diff --git a/lib/librte_hash/meson.build
> > b/lib/librte_hash/meson.build
> > index 5d02b3084..bce11ad9e 100644
> > --- a/lib/librte_hash/meson.build
> > +++ b/lib/librte_hash/meson.build
> > @@ -1,10 +1,7 @@
> >  # SPDX-License-Identifier: BSD-3-Clause
> >  # Copyright(c) 2017 Intel Corporation
> >
> > -headers = files('rte_cmp_arm64.h',
> > -     'rte_cmp_x86.h',
> > -     'rte_crc_arm64.h',
> > -     'rte_cuckoo_hash.h',
> > +headers = files('rte_crc_arm64.h',
> >       'rte_fbk_hash.h',
> >       'rte_hash_crc.h',
> >       'rte_hash.h',
>
> Difficult question: how confident we are nobody is using those? :-)

Those headers are for internal structures.
When installing with make, those headers were skipped.

Grepping on the dpdk projects that I monitor (based on Stephen list):

$ for header in rte_cmp_arm64.h rte_cmp_x86.h rte_cuckoo_hash.h; do
echo "======= $header"; git grep-all -l $header; echo; done
======= rte_cmp_arm64.h
F-Stack origin/HEAD:dpdk/lib/librte_hash/meson.build
F-Stack origin/HEAD:dpdk/lib/librte_hash/rte_cuckoo_hash.h
Trex origin/HEAD:src/dpdk/lib/librte_hash/rte_cuckoo_hash.h
yastack origin/HEAD:dpdk/lib/librte_hash/meson.build
yastack origin/HEAD:dpdk/lib/librte_hash/rte_cuckoo_hash.h

======= rte_cmp_x86.h
F-Stack origin/HEAD:dpdk/lib/librte_hash/meson.build
F-Stack origin/HEAD:dpdk/lib/librte_hash/rte_cuckoo_hash.h
Trex origin/HEAD:src/dpdk/lib/librte_hash/rte_cuckoo_hash.h
yastack origin/HEAD:dpdk/lib/librte_hash/meson.build
yastack origin/HEAD:dpdk/lib/librte_hash/rte_cuckoo_hash.h

======= rte_cuckoo_hash.h
F-Stack origin/HEAD:dpdk/lib/librte_hash/meson.build
F-Stack origin/HEAD:dpdk/lib/librte_hash/rte_cuckoo_hash.c
F-Stack origin/HEAD:dpdk/lib/librte_hash/rte_cuckoo_hash.h
Trex origin/HEAD:src/dpdk/lib/librte_hash/rte_cuckoo_hash.c
Trex origin/HEAD:src/dpdk/lib/librte_hash/rte_cuckoo_hash.h
yastack origin/HEAD:dpdk/lib/librte_hash/meson.build
yastack origin/HEAD:dpdk/lib/librte_hash/rte_cuckoo_hash.c
yastack origin/HEAD:dpdk/lib/librte_hash/rte_cuckoo_hash.h


-- 
David Marchand


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH v2 1/4] hash: fix meson headers packaging
  2020-01-30 10:54       ` David Marchand
@ 2020-01-30 10:56         ` Luca Boccassi
  0 siblings, 0 replies; 10+ messages in thread
From: Luca Boccassi @ 2020-01-30 10:56 UTC (permalink / raw)
  To: David Marchand
  Cc: dev, Thomas Monjalon, Bruce Richardson, Kevin Laatz,
	Aaron Conole, Neil Horman, Akhil Goyal, Anoob Joseph,
	dpdk stable, Yipeng Wang, Sameh Gobriel, Harry van Haaren,
	Keith Wiles

On Thu, 2020-01-30 at 11:54 +0100, David Marchand wrote:
> On Thu, Jan 30, 2020 at 11:12 AM Luca Boccassi <
> bluca@debian.org
> > wrote:
> > On Wed, 2020-01-29 at 18:26 +0100, David Marchand wrote:
> > > Those headers are internal and should not be distributed.
> > > 
> > > Fixes: 5b9656b157d3 ("lib: build with meson")
> > > Cc:
> > > stable@dpdk.org
> > > 
> > > 
> > > 
> > > Signed-off-by: David Marchand <
> > > david.marchand@redhat.com
> > > 
> > > 
> > > ---
> > >  lib/librte_hash/meson.build | 5 +----
> > >  1 file changed, 1 insertion(+), 4 deletions(-)
> > > 
> > > diff --git a/lib/librte_hash/meson.build
> > > b/lib/librte_hash/meson.build
> > > index 5d02b3084..bce11ad9e 100644
> > > --- a/lib/librte_hash/meson.build
> > > +++ b/lib/librte_hash/meson.build
> > > @@ -1,10 +1,7 @@
> > >  # SPDX-License-Identifier: BSD-3-Clause
> > >  # Copyright(c) 2017 Intel Corporation
> > > 
> > > -headers = files('rte_cmp_arm64.h',
> > > -     'rte_cmp_x86.h',
> > > -     'rte_crc_arm64.h',
> > > -     'rte_cuckoo_hash.h',
> > > +headers = files('rte_crc_arm64.h',
> > >       'rte_fbk_hash.h',
> > >       'rte_hash_crc.h',
> > >       'rte_hash.h',
> > 
> > Difficult question: how confident we are nobody is using those? :-)
> 
> Those headers are for internal structures.
> When installing with make, those headers were skipped.
> 
> Grepping on the dpdk projects that I monitor (based on Stephen list):
> 
> $ for header in rte_cmp_arm64.h rte_cmp_x86.h rte_cuckoo_hash.h; do
> echo "======= $header"; git grep-all -l $header; echo; done
> ======= rte_cmp_arm64.h
> F-Stack origin/HEAD:dpdk/lib/librte_hash/meson.build
> F-Stack origin/HEAD:dpdk/lib/librte_hash/rte_cuckoo_hash.h
> Trex origin/HEAD:src/dpdk/lib/librte_hash/rte_cuckoo_hash.h
> yastack origin/HEAD:dpdk/lib/librte_hash/meson.build
> yastack origin/HEAD:dpdk/lib/librte_hash/rte_cuckoo_hash.h
> 
> ======= rte_cmp_x86.h
> F-Stack origin/HEAD:dpdk/lib/librte_hash/meson.build
> F-Stack origin/HEAD:dpdk/lib/librte_hash/rte_cuckoo_hash.h
> Trex origin/HEAD:src/dpdk/lib/librte_hash/rte_cuckoo_hash.h
> yastack origin/HEAD:dpdk/lib/librte_hash/meson.build
> yastack origin/HEAD:dpdk/lib/librte_hash/rte_cuckoo_hash.h
> 
> ======= rte_cuckoo_hash.h
> F-Stack origin/HEAD:dpdk/lib/librte_hash/meson.build
> F-Stack origin/HEAD:dpdk/lib/librte_hash/rte_cuckoo_hash.c
> F-Stack origin/HEAD:dpdk/lib/librte_hash/rte_cuckoo_hash.h
> Trex origin/HEAD:src/dpdk/lib/librte_hash/rte_cuckoo_hash.c
> Trex origin/HEAD:src/dpdk/lib/librte_hash/rte_cuckoo_hash.h
> yastack origin/HEAD:dpdk/lib/librte_hash/meson.build
> yastack origin/HEAD:dpdk/lib/librte_hash/rte_cuckoo_hash.c
> yastack origin/HEAD:dpdk/lib/librte_hash/rte_cuckoo_hash.h

Great, thanks for checking!

-- 
Kind regards,
Luca Boccassi

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [dpdk-stable] [PATCH v3 1/4] hash: fix meson headers packaging
       [not found] ` <20200130160009.6549-1-david.marchand@redhat.com>
@ 2020-01-30 16:00   ` David Marchand
  2020-01-30 18:01     ` Wang, Yipeng1
  0 siblings, 1 reply; 10+ messages in thread
From: David Marchand @ 2020-01-30 16:00 UTC (permalink / raw)
  To: dev
  Cc: thomas, bruce.richardson, kevin.laatz, aconole, nhorman,
	akhil.goyal, anoobj, bluca, fiona.trahe, ferruh.yigit, stable,
	Yipeng Wang, Sameh Gobriel, Harry van Haaren, Luca Boccassi,
	Keith Wiles

Those headers are internal and should not be distributed.

Fixes: 5b9656b157d3 ("lib: build with meson")
Cc: stable@dpdk.org

Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Luca Boccassi <bluca@debian.org>
---
 lib/librte_hash/meson.build | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/lib/librte_hash/meson.build b/lib/librte_hash/meson.build
index 5d02b3084..bce11ad9e 100644
--- a/lib/librte_hash/meson.build
+++ b/lib/librte_hash/meson.build
@@ -1,10 +1,7 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
-headers = files('rte_cmp_arm64.h',
-	'rte_cmp_x86.h',
-	'rte_crc_arm64.h',
-	'rte_cuckoo_hash.h',
+headers = files('rte_crc_arm64.h',
 	'rte_fbk_hash.h',
 	'rte_hash_crc.h',
 	'rte_hash.h',
-- 
2.23.0


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-stable] [PATCH v3 1/4] hash: fix meson headers packaging
  2020-01-30 16:00   ` [dpdk-stable] [PATCH v3 " David Marchand
@ 2020-01-30 18:01     ` Wang, Yipeng1
  2020-01-30 18:40       ` Honnappa Nagarahalli
  0 siblings, 1 reply; 10+ messages in thread
From: Wang, Yipeng1 @ 2020-01-30 18:01 UTC (permalink / raw)
  To: David Marchand, dev, Honnappa Nagarahalli
  Cc: thomas, Richardson, Bruce, Laatz, Kevin, aconole, nhorman,
	akhil.goyal, anoobj, bluca, Trahe, Fiona, Yigit, Ferruh, stable,
	Gobriel, Sameh, Van Haaren, Harry, Luca Boccassi, Wiles, Keith

>-----Original Message-----
>From: David Marchand [mailto:david.marchand@redhat.com]
>Sent: Thursday, January 30, 2020 8:00 AM
>To: dev@dpdk.org
>Cc: thomas@monjalon.net; Richardson, Bruce <bruce.richardson@intel.com>; Laatz, Kevin <kevin.laatz@intel.com>;
>aconole@redhat.com; nhorman@tuxdriver.com; akhil.goyal@nxp.com; anoobj@marvell.com; bluca@debian.org; Trahe, Fiona
><fiona.trahe@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>; stable@dpdk.org; Wang, Yipeng1 <yipeng1.wang@intel.com>;
>Gobriel, Sameh <sameh.gobriel@intel.com>; Van Haaren, Harry <harry.van.haaren@intel.com>; Luca Boccassi
><luca.boccassi@gmail.com>; Wiles, Keith <keith.wiles@intel.com>
>Subject: [PATCH v3 1/4] hash: fix meson headers packaging
>
>Those headers are internal and should not be distributed.
>
>Fixes: 5b9656b157d3 ("lib: build with meson")
>Cc: stable@dpdk.org
>
>Signed-off-by: David Marchand <david.marchand@redhat.com>
>Acked-by: Luca Boccassi <bluca@debian.org>

[Wang, Yipeng] 
Thanks for the patch! I believe they are for internal used only.
But include Honnappa from ARM here since in the makefile seems the rte_crc_arm64.h is installed?

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-stable] [PATCH v3 1/4] hash: fix meson headers packaging
  2020-01-30 18:01     ` Wang, Yipeng1
@ 2020-01-30 18:40       ` Honnappa Nagarahalli
  2020-02-05 19:51         ` Wang, Yipeng1
  0 siblings, 1 reply; 10+ messages in thread
From: Honnappa Nagarahalli @ 2020-01-30 18:40 UTC (permalink / raw)
  To: Wang, Yipeng1, David Marchand, dev
  Cc: thomas, Richardson, Bruce, Laatz, Kevin, aconole, nhorman,
	Akhil.goyal@nxp.com, anoobj, bluca, Trahe, Fiona, Yigit, Ferruh,
	stable, Gobriel, Sameh, Van Haaren, Harry, Luca Boccassi, Wiles,
	Keith, nd, Honnappa Nagarahalli, nd

<snip>

> >Subject: [PATCH v3 1/4] hash: fix meson headers packaging
> >
> >Those headers are internal and should not be distributed.
> >
> >Fixes: 5b9656b157d3 ("lib: build with meson")
> >Cc: stable@dpdk.org
> >
> >Signed-off-by: David Marchand <david.marchand@redhat.com>
> >Acked-by: Luca Boccassi <bluca@debian.org>
> 
> [Wang, Yipeng]
> Thanks for the patch! I believe they are for internal used only.
> But include Honnappa from ARM here since in the makefile seems the
> rte_crc_arm64.h is installed?
I see that this patch installs rte_crc_arm64.h. I do no see any issue.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [dpdk-stable] [PATCH v4 1/3] hash: fix meson headers packaging
       [not found] ` <20200202210835.29791-1-david.marchand@redhat.com>
@ 2020-02-02 21:08   ` David Marchand
  2020-02-05 19:53     ` Wang, Yipeng1
  0 siblings, 1 reply; 10+ messages in thread
From: David Marchand @ 2020-02-02 21:08 UTC (permalink / raw)
  To: dev
  Cc: thomas, bruce.richardson, kevin.laatz, aconole, nhorman,
	akhil.goyal, anoobj, bluca, fiona.trahe, ferruh.yigit, stable,
	Yipeng Wang, Sameh Gobriel, Harry van Haaren, Luca Boccassi,
	Keith Wiles

Those headers are internal and should not be distributed.

Fixes: 5b9656b157d3 ("lib: build with meson")
Cc: stable@dpdk.org

Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Luca Boccassi <bluca@debian.org>
---
 lib/librte_hash/meson.build | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/lib/librte_hash/meson.build b/lib/librte_hash/meson.build
index 5d02b3084..bce11ad9e 100644
--- a/lib/librte_hash/meson.build
+++ b/lib/librte_hash/meson.build
@@ -1,10 +1,7 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
-headers = files('rte_cmp_arm64.h',
-	'rte_cmp_x86.h',
-	'rte_crc_arm64.h',
-	'rte_cuckoo_hash.h',
+headers = files('rte_crc_arm64.h',
 	'rte_fbk_hash.h',
 	'rte_hash_crc.h',
 	'rte_hash.h',
-- 
2.23.0


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-stable] [PATCH v3 1/4] hash: fix meson headers packaging
  2020-01-30 18:40       ` Honnappa Nagarahalli
@ 2020-02-05 19:51         ` Wang, Yipeng1
  0 siblings, 0 replies; 10+ messages in thread
From: Wang, Yipeng1 @ 2020-02-05 19:51 UTC (permalink / raw)
  To: Honnappa Nagarahalli, David Marchand, dev
  Cc: thomas, Richardson, Bruce, Laatz, Kevin, aconole, nhorman,
	Akhil.goyal@nxp.com, anoobj, bluca, Trahe, Fiona, Yigit, Ferruh,
	stable, Gobriel, Sameh, Van Haaren, Harry, Luca Boccassi, Wiles,
	Keith, nd, nd

>-----Original Message-----
>From: Honnappa Nagarahalli [mailto:Honnappa.Nagarahalli@arm.com]
>Sent: Thursday, January 30, 2020 10:40 AM
>To: Wang, Yipeng1 <yipeng1.wang@intel.com>; David Marchand <david.marchand@redhat.com>; dev@dpdk.org
>Cc: thomas@monjalon.net; Richardson, Bruce <bruce.richardson@intel.com>; Laatz, Kevin <kevin.laatz@intel.com>;
>aconole@redhat.com; nhorman@tuxdriver.com; Akhil.goyal@nxp.com; anoobj@marvell.com; bluca@debian.org; Trahe, Fiona
><fiona.trahe@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>; stable@dpdk.org; Gobriel, Sameh <sameh.gobriel@intel.com>; Van
>Haaren, Harry <harry.van.haaren@intel.com>; Luca Boccassi <luca.boccassi@gmail.com>; Wiles, Keith <keith.wiles@intel.com>; nd
><nd@arm.com>; Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>; nd <nd@arm.com>
>Subject: RE: [PATCH v3 1/4] hash: fix meson headers packaging
>
><snip>
>
>> >Subject: [PATCH v3 1/4] hash: fix meson headers packaging
>> >
>> >Those headers are internal and should not be distributed.
>> >
>> >Fixes: 5b9656b157d3 ("lib: build with meson")
>> >Cc: stable@dpdk.org
>> >
>> >Signed-off-by: David Marchand <david.marchand@redhat.com>
>> >Acked-by: Luca Boccassi <bluca@debian.org>
>>
>> [Wang, Yipeng]
>> Thanks for the patch! I believe they are for internal used only.
>> But include Honnappa from ARM here since in the makefile seems the
>> rte_crc_arm64.h is installed?
>I see that this patch installs rte_crc_arm64.h. I do no see any issue.

[Wang, Yipeng] 
Right sorry, I mis-read the code line. 

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-stable] [PATCH v4 1/3] hash: fix meson headers packaging
  2020-02-02 21:08   ` [dpdk-stable] [PATCH v4 1/3] " David Marchand
@ 2020-02-05 19:53     ` Wang, Yipeng1
  0 siblings, 0 replies; 10+ messages in thread
From: Wang, Yipeng1 @ 2020-02-05 19:53 UTC (permalink / raw)
  To: David Marchand, dev
  Cc: thomas, Richardson, Bruce, Laatz, Kevin, aconole, nhorman,
	akhil.goyal, anoobj, bluca, Trahe, Fiona, Yigit, Ferruh, stable,
	Gobriel, Sameh, Van Haaren, Harry, Luca Boccassi, Wiles, Keith

>-----Original Message-----
>From: David Marchand [mailto:david.marchand@redhat.com]
>Sent: Sunday, February 2, 2020 1:09 PM
>To: dev@dpdk.org
>Cc: thomas@monjalon.net; Richardson, Bruce <bruce.richardson@intel.com>; Laatz, Kevin <kevin.laatz@intel.com>;
>aconole@redhat.com; nhorman@tuxdriver.com; akhil.goyal@nxp.com; anoobj@marvell.com; bluca@debian.org; Trahe, Fiona
><fiona.trahe@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>; stable@dpdk.org; Wang, Yipeng1 <yipeng1.wang@intel.com>;
>Gobriel, Sameh <sameh.gobriel@intel.com>; Van Haaren, Harry <harry.van.haaren@intel.com>; Luca Boccassi
><luca.boccassi@gmail.com>; Wiles, Keith <keith.wiles@intel.com>
>Subject: [PATCH v4 1/3] hash: fix meson headers packaging
>
>Those headers are internal and should not be distributed.
>
>Fixes: 5b9656b157d3 ("lib: build with meson")
>Cc: stable@dpdk.org
>
>Signed-off-by: David Marchand <david.marchand@redhat.com>
>Acked-by: Luca Boccassi <bluca@debian.org>
>---
> lib/librte_hash/meson.build | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
>diff --git a/lib/librte_hash/meson.build b/lib/librte_hash/meson.build
>index 5d02b3084..bce11ad9e 100644
>--- a/lib/librte_hash/meson.build
>+++ b/lib/librte_hash/meson.build
>@@ -1,10 +1,7 @@
> # SPDX-License-Identifier: BSD-3-Clause
> # Copyright(c) 2017 Intel Corporation
>
>-headers = files('rte_cmp_arm64.h',
>-	'rte_cmp_x86.h',
>-	'rte_crc_arm64.h',
>-	'rte_cuckoo_hash.h',
>+headers = files('rte_crc_arm64.h',
> 	'rte_fbk_hash.h',
> 	'rte_hash_crc.h',
> 	'rte_hash.h',
>--
>2.23.0

[Wang, Yipeng]
Acked-by: Yipeng Wang <yipeng1.wang@intel.com>

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2020-02-05 19:53 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20191220152058.10739-1-david.marchand@redhat.com>
     [not found] ` <20200129172621.28565-1-david.marchand@redhat.com>
2020-01-29 17:26   ` [dpdk-stable] [PATCH v2 1/4] hash: fix meson headers packaging David Marchand
2020-01-30 10:12     ` Luca Boccassi
2020-01-30 10:54       ` David Marchand
2020-01-30 10:56         ` [dpdk-stable] [dpdk-dev] " Luca Boccassi
     [not found] ` <20200130160009.6549-1-david.marchand@redhat.com>
2020-01-30 16:00   ` [dpdk-stable] [PATCH v3 " David Marchand
2020-01-30 18:01     ` Wang, Yipeng1
2020-01-30 18:40       ` Honnappa Nagarahalli
2020-02-05 19:51         ` Wang, Yipeng1
     [not found] ` <20200202210835.29791-1-david.marchand@redhat.com>
2020-02-02 21:08   ` [dpdk-stable] [PATCH v4 1/3] " David Marchand
2020-02-05 19:53     ` Wang, Yipeng1

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).