From: "Mattias Rönnblom" <mattias.ronnblom@ericsson.com>
To: <jerinj@marvell.com>
Cc: dev@dpdk.org, stable@dpdk.org, vvenkatesh@paloaltonetworks.com,
"Mattias Rönnblom" <mattias.ronnblom@ericsson.com>
Subject: [dpdk-stable] [PATCH] event/dsw: avoid reusing previously recorded events
Date: Thu, 5 Mar 2020 11:46:51 +0100 [thread overview]
Message-ID: <20200305104651.25456-1-mattias.ronnblom@ericsson.com> (raw)
Avoid reusing recorded events when performing a migration, since this
may make the migration selection logic pick an already-moved flow.
Fixes: f6257b22e767 ("event/dsw: add load balancing")
Cc: stable@dpdk.org
Reported-by: Venky Venkatesh <vvenkatesh@paloaltonetworks.com>
Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
---
drivers/event/dsw/dsw_event.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/event/dsw/dsw_event.c b/drivers/event/dsw/dsw_event.c
index d68b71b98..296adea18 100644
--- a/drivers/event/dsw/dsw_event.c
+++ b/drivers/event/dsw/dsw_event.c
@@ -646,6 +646,9 @@ dsw_port_consider_migration(struct dsw_evdev *dsw,
if (dsw->num_ports == 1)
return;
+ if (seen_events_len < DSW_MAX_EVENTS_RECORDED)
+ return;
+
DSW_LOG_DP_PORT(DEBUG, source_port->id, "Considering migration.\n");
/* Randomize interval to avoid having all threads considering
--
2.17.1
next reply other threads:[~2020-03-05 10:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 10:46 Mattias Rönnblom [this message]
2020-03-06 6:05 ` Venky Venkatesh
2020-03-06 7:48 ` Mattias Rönnblom
2020-04-04 12:35 ` [dpdk-stable] [dpdk-dev] " Jerin Jacob
2020-04-14 12:45 ` Jerin Jacob
2020-04-14 13:11 ` Mattias Rönnblom
2020-04-14 13:32 ` Jerin Jacob
2020-05-01 8:01 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200305104651.25456-1-mattias.ronnblom@ericsson.com \
--to=mattias.ronnblom@ericsson.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=stable@dpdk.org \
--cc=vvenkatesh@paloaltonetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).