Re: [dpdk-stable] [dpdk-dev] [PATCH] event/dsw: avoid reusing previously recorded events

[Jerin Jacob <jerinjacobk@gmail.com>]

On Tue, Apr 14, 2020 at 7:02 PM Jerin Jacob <jerinjacobk@gmail.com> wrote:
>
> On Tue, Apr 14, 2020 at 6:41 PM Mattias Rönnblom
> <mattias.ronnblom@ericsson.com> wrote:
> >
> > On 2020-04-14 14:45, Jerin Jacob wrote:
> > > On Sat, Apr 4, 2020 at 6:05 PM Jerin Jacob <jerinjacobk@gmail.com> wrote:
> > >> On Fri, Mar 6, 2020 at 11:35 AM Venky Venkatesh
> > >> <vvenkatesh@paloaltonetworks.com> wrote:
> > >>> Hi Mattias,
> > >>> Have a question on this fix. I understand you wanting a certain number of
> > >>> events before making a decision to migrate (in the above fix).
> > >>> However, suppose there are fewer events over a few flows (even if not many)
> > >>> and yet your core is heavily loaded -- indicating may be they are one or
> > >>> more very CPU intensive flows. Often in DPI situations depending on the
> > >>> complexity of the policy you can get delayed longer. It might still be
> > >>> worthwhile to migrate if the other cores are really lightly loaded. I think
> > >>> that case will be missed out in this approach.
> > >>>
> > >>> Fundamentally, the number of packets being a proxy-metric for the load of
> > >>> that flow on the cpu is simplistic at times. Very CPU intensive
> > >>> medium/lower bandwidth flows can be picked up in this heuristic. If there
> > >>> is a way that at the time of DSW init we can have a way of tuning it
> > >>> depending on the application scenario it might be more flexible.
> > >> Hi Venky and Mattias,
> > >>
> > >> Is this patch to good to merge?
> > > Please mark the patch as "Not applicable" if the patch is not required.
> > >
> >
> > This patch should be merged. Thanks.
>
> Sure. I will wait for couple of days on any comments on this patch. If
> none, I will merge this.

Could you rebase this patch to next-eventdev master and send the next
version so that I can merge it?

[master][dpdk-next-eventdev] $ git am -3
/tmp/to_merge/event-dsw-avoid-reusing-previously-recorded-events
Applying: event/dsw: avoid reusing previously recorded events
Using index info to reconstruct a base tree...
M       drivers/event/dsw/dsw_event.c
Falling back to patching base and 3-way merge...
Auto-merging drivers/event/dsw/dsw_event.c
CONFLICT (content): Merge conflict in drivers/event/dsw/dsw_event.c
Recorded preimage for 'drivers/event/dsw/dsw_event.c'
error: Failed to merge in the changes.
Patch failed at 0001 event/dsw: avoid reusing previously recorded events
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
[master][dpdk-next-eventdev] $