patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [dpdk-dev][PATCH v1 1/1] net/ice: fix link status down
@ 2020-09-08 22:47 yanx.fu
  2020-09-15  6:54 ` [dpdk-stable] [dpdk-dev] [PATCH " Mei, JianweiX
  0 siblings, 1 reply; 2+ messages in thread
From: yanx.fu @ 2020-09-08 22:47 UTC (permalink / raw)
  To: qi.z.zhang, jia.guo; +Cc: dev, FuYanX, stable

From: FuYanX <yanx.fu@intel.com>

Add delay to ensure that the hardware FLR is completed.

Fixes: f9cf4f864150 (net/ice: support device initialization)
Cc: stable@dpdk.org

Signed-off-by: FuYanX <yanx.fu@intel.com>
---
 drivers/net/ice/ice_ethdev.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index 8d435e889..20bd85e62 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -2176,6 +2176,11 @@ ice_dev_init(struct rte_eth_dev *dev)
 
 	ice_init_controlq_parameter(hw);
 
+	/* The driver e.g. vfio-pci may triggle a FLR reset.
+	 * The operating system is required by PCIe specification to wait 100 ms
+	 * before it can assume that the FLR sequence is completed by hardware.
+	 */
+	rte_delay_ms(100);
 	ret = ice_init_hw(hw);
 	if (ret) {
 		PMD_INIT_LOG(ERR, "Failed to initialize HW");
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH v1 1/1] net/ice: fix link status down
  2020-09-08 22:47 [dpdk-stable] [dpdk-dev][PATCH v1 1/1] net/ice: fix link status down yanx.fu
@ 2020-09-15  6:54 ` Mei, JianweiX
  0 siblings, 0 replies; 2+ messages in thread
From: Mei, JianweiX @ 2020-09-15  6:54 UTC (permalink / raw)
  To: Fu, YanX, Zhang, Qi Z, Guo, Jia; +Cc: dev, Fu, YanX, stable

Tested-by:  Mei,JianweiX < jianweix.mei@intel.com>

-----Original Message-----
From: dev <dev-bounces@dpdk.org> On Behalf Of yanx.fu@intel.com
Sent: Wednesday, September 9, 2020 6:47 AM
To: Zhang, Qi Z <qi.z.zhang@intel.com>; Guo, Jia <jia.guo@intel.com>
Cc: dev@dpdk.org; Fu, YanX <yanx.fu@intel.com>; stable@dpdk.org
Subject: [dpdk-dev] [PATCH v1 1/1] net/ice: fix link status down

From: FuYanX <yanx.fu@intel.com>

Add delay to ensure that the hardware FLR is completed.

Fixes: f9cf4f864150 (net/ice: support device initialization)
Cc: stable@dpdk.org

Signed-off-by: FuYanX <yanx.fu@intel.com>
---
 drivers/net/ice/ice_ethdev.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index 8d435e889..20bd85e62 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -2176,6 +2176,11 @@ ice_dev_init(struct rte_eth_dev *dev)
 
 	ice_init_controlq_parameter(hw);
 
+	/* The driver e.g. vfio-pci may triggle a FLR reset.
+	 * The operating system is required by PCIe specification to wait 100 ms
+	 * before it can assume that the FLR sequence is completed by hardware.
+	 */
+	rte_delay_ms(100);
 	ret = ice_init_hw(hw);
 	if (ret) {
 		PMD_INIT_LOG(ERR, "Failed to initialize HW");
--
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-09-15  6:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-08 22:47 [dpdk-stable] [dpdk-dev][PATCH v1 1/1] net/ice: fix link status down yanx.fu
2020-09-15  6:54 ` [dpdk-stable] [dpdk-dev] [PATCH " Mei, JianweiX

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).