patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] examples/packet_ordering: use local port config
@ 2021-03-11  6:36 dapengx.yu
  2021-03-18 10:18 ` Pattan, Reshma
  2021-03-19  7:11 ` [dpdk-stable] [PATCH v2] " dapengx.yu
  0 siblings, 2 replies; 4+ messages in thread
From: dapengx.yu @ 2021-03-11  6:36 UTC (permalink / raw)
  To: reshma.pattan; +Cc: dev, Dapeng Yu, stable

From: Dapeng Yu <dapengx.yu@intel.com>

A global ethernet port configuration is assigned to local variable
because in this way the local variable may be updated as required. But
this local variable is not used as input of rte_eth_dev_configure() in
original implementation, and cause that fast mbuf free feature cannot
be enabled on port.

This patch use this local variable as input of rte_eth_dev_configure().

Fixes: 6833f919f56b ("examples/packet_ordering: convert to new ethdev offloads API")
Cc: stable@dpdk.org

Signed-off-by: Dapeng Yu <dapengx.yu@intel.com>
---
 examples/packet_ordering/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/packet_ordering/main.c b/examples/packet_ordering/main.c
index 4bea1982d..963b11d6d 100644
--- a/examples/packet_ordering/main.c
+++ b/examples/packet_ordering/main.c
@@ -290,7 +290,7 @@ configure_eth_port(uint16_t port_id)
 	if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE)
 		port_conf.txmode.offloads |=
 			DEV_TX_OFFLOAD_MBUF_FAST_FREE;
-	ret = rte_eth_dev_configure(port_id, rxRings, txRings, &port_conf_default);
+	ret = rte_eth_dev_configure(port_id, rxRings, txRings, &port_conf);
 	if (ret != 0)
 		return ret;
 
-- 
2.27.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-stable] [PATCH] examples/packet_ordering: use local port config
  2021-03-11  6:36 [dpdk-stable] [PATCH] examples/packet_ordering: use local port config dapengx.yu
@ 2021-03-18 10:18 ` Pattan, Reshma
  2021-03-19  7:11 ` [dpdk-stable] [PATCH v2] " dapengx.yu
  1 sibling, 0 replies; 4+ messages in thread
From: Pattan, Reshma @ 2021-03-18 10:18 UTC (permalink / raw)
  To: Yu, DapengX; +Cc: dev, Yu, DapengX, stable



> -----Original Message-----
> From: dapengx.yu@intel.com <dapengx.yu@intel.com>
>
> Fixes: 6833f919f56b ("examples/packet_ordering: convert to new ethdev
> offloads API")
> Cc: stable@dpdk.org
Also, need to add CC: <author of the commit> i.e CC:  Shahaf Shuler <shahafs@mellanox.com>

Other than that , patch looks ok to me. Please include my ack in next version of the patch .
Acked-by: Reshma Pattan <reshma.pattan@intel.com>






^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dpdk-stable] [PATCH v2] examples/packet_ordering: use local port config
  2021-03-11  6:36 [dpdk-stable] [PATCH] examples/packet_ordering: use local port config dapengx.yu
  2021-03-18 10:18 ` Pattan, Reshma
@ 2021-03-19  7:11 ` dapengx.yu
  2021-03-24 10:17   ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
  1 sibling, 1 reply; 4+ messages in thread
From: dapengx.yu @ 2021-03-19  7:11 UTC (permalink / raw)
  To: reshma.pattan; +Cc: dev, Dapeng Yu, shahafs, stable

From: Dapeng Yu <dapengx.yu@intel.com>

A global ethernet port configuration is assigned to local variable
because in this way the local variable may be updated as required. But
this local variable is not used as input of rte_eth_dev_configure() in
original implementation, and cause that fast mbuf free feature cannot
be enabled on port.

This patch use this local variable as input of rte_eth_dev_configure().

Fixes: 6833f919f56b ("examples/packet_ordering: convert to new ethdev offloads API")
Cc: shahafs@mellanox.com
Cc: stable@dpdk.org

Signed-off-by: Dapeng Yu <dapengx.yu@intel.com>
Acked-by: Reshma Pattan <reshma.pattan@intel.com>
---
v2:
* Add Cc:<original author> and Acked-by:<maintainer>

 examples/packet_ordering/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/packet_ordering/main.c b/examples/packet_ordering/main.c
index 4bea1982d..963b11d6d 100644
--- a/examples/packet_ordering/main.c
+++ b/examples/packet_ordering/main.c
@@ -290,7 +290,7 @@ configure_eth_port(uint16_t port_id)
 	if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE)
 		port_conf.txmode.offloads |=
 			DEV_TX_OFFLOAD_MBUF_FAST_FREE;
-	ret = rte_eth_dev_configure(port_id, rxRings, txRings, &port_conf_default);
+	ret = rte_eth_dev_configure(port_id, rxRings, txRings, &port_conf);
 	if (ret != 0)
 		return ret;
 
-- 
2.27.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] examples/packet_ordering: use local port config
  2021-03-19  7:11 ` [dpdk-stable] [PATCH v2] " dapengx.yu
@ 2021-03-24 10:17   ` Thomas Monjalon
  0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2021-03-24 10:17 UTC (permalink / raw)
  To: Dapeng Yu; +Cc: reshma.pattan, dev, shahafs, stable

19/03/2021 08:11, dapengx.yu@intel.com:
> From: Dapeng Yu <dapengx.yu@intel.com>
> 
> A global ethernet port configuration is assigned to local variable
> because in this way the local variable may be updated as required. But
> this local variable is not used as input of rte_eth_dev_configure() in
> original implementation, and cause that fast mbuf free feature cannot
> be enabled on port.
> 
> This patch use this local variable as input of rte_eth_dev_configure().
> 
> Fixes: 6833f919f56b ("examples/packet_ordering: convert to new ethdev offloads API")
> Cc: shahafs@mellanox.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Dapeng Yu <dapengx.yu@intel.com>
> Acked-by: Reshma Pattan <reshma.pattan@intel.com>

Applied, thanks




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-03-24 10:17 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-11  6:36 [dpdk-stable] [PATCH] examples/packet_ordering: use local port config dapengx.yu
2021-03-18 10:18 ` Pattan, Reshma
2021-03-19  7:11 ` [dpdk-stable] [PATCH v2] " dapengx.yu
2021-03-24 10:17   ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git