Re: [dpdk-stable] [dpdk-dev] [PATCH] examples/rxtx_callbacks: fix port ID format specifier

[Tyler Retzlaff <roretzla@linux.microsoft.com>]

On Tue, May 04, 2021 at 09:48:22AM +0300, Dmitry Kozlyuk wrote:
> 2021-05-03 17:11 (UTC-0700), Tyler Retzlaff:
> > On Sun, May 02, 2021 at 05:56:56AM +0300, Dmitry Kozlyuk wrote:
> > > Use "%u" and a cast as in other places when port ID is formatted.
> > > This fixes -Wformat warning with clang 10.0.0 on Windows.
> > > 
> > > Fixes: f8244c6399d9 ("ethdev: increase port id range")
> > > Cc: stable@dpdk.org
> > > 
> > > Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> > > ---
> > >  examples/rxtx_callbacks/main.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/examples/rxtx_callbacks/main.c b/examples/rxtx_callbacks/main.c
> > > index b57b2fc6bc..9574b6ea0d 100644
> > > --- a/examples/rxtx_callbacks/main.c
> > > +++ b/examples/rxtx_callbacks/main.c
> > > @@ -329,8 +329,8 @@ main(int argc, char *argv[])
> > >  	/* initialize all ports */
> > >  	RTE_ETH_FOREACH_DEV(portid)
> > >  		if (port_init(portid, mbuf_pool) != 0)
> > > -			rte_exit(EXIT_FAILURE, "Cannot init port %"PRIu8"\n",
> > > -					portid);  
> > 
> > how come not just `% " PRIu16 "\n"' ?
> > 
> > what was the -Wformat clang on windows complaint?
> 
> PRIx16 would work, but I noticed that in other places where port ID is
> printed, the pattern above is used. IMO uniform approach is better.

ah, consistency. yes i'll have some of that. maybe one day in the future
we can change them all in one shot, but not today.

Acked-By: Tyler Retzlaff <roretzla@linux.microsoft.com>