From: Jie Zhou <jizh@linux.microsoft.com>
To: Tal Shnaiderman <talshn@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"dmitry.kozliuk@gmail.com" <dmitry.kozliuk@gmail.com>,
"xiaoyun.li@intel.com" <xiaoyun.li@intel.com>,
"roretzla@microsoft.com" <roretzla@microsoft.com>,
"pallavi.kadam@intel.com" <pallavi.kadam@intel.com>,
NBU-Contact-Thomas Monjalon <thomas@monjalon.net>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
"konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v10 07/10] app/testpmd: replace POSIX specific code
Date: Wed, 5 May 2021 09:41:01 -0700 [thread overview]
Message-ID: <20210505164101.GA30464@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <20210505160920.GB22459@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
On Wed, May 05, 2021 at 09:09:20AM -0700, Jie Zhou wrote:
> On Wed, May 05, 2021 at 08:34:34AM +0000, Tal Shnaiderman wrote:
> > > Subject: [PATCH v10 07/10] app/testpmd: replace POSIX specific code
> > >
> > > External email: Use caution opening links or attachments
> > >
> > >
> > > - Make printf format OS independent
> > > - Replace htons with RTE_BE16
> > > - Replace POSIX specific inet_aton with OS independent inet_pton
> > > - Replace sleep with rte_delay_us_sleep
> > > - Repalce random with rte_rand
> > > - #ifndef mman related code for now
> >
> > Do you think we can reduce the number of ifndefs by using the functions rte_mem_map, rte_mem_lock?
>
> I used rte_mem_xxx APIs in V3. DmitryK pointed out that Apps except unit tests should not use these internal APIs, and also rte_mem_map does not support hugepage with different sized. Given that, decided to work on the mman related part in a future separate patch.
>
> >
> > >
> > > Signed-off-by: Jie Zhou <jizh@microsoft.com>
> > > Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
> > > ---
> > > app/test-pmd/cmdline.c | 3 +--
> > > app/test-pmd/csumonly.c | 2 +-
> > > app/test-pmd/icmpecho.c | 4 ++--
> > > app/test-pmd/ieee1588fwd.c | 8 ++++---- app/test-pmd/parameters.c |
> > > 10 +++++++---
> > > app/test-pmd/testpmd.c | 21 ++++++++++++++++++++-
> > > app/test-pmd/testpmd.h | 2 +-
> > > 7 files changed, 36 insertions(+), 14 deletions(-)
> > >
> >
> > <snip>
> >
> > > @@ mbuf_pool_create(uint16_t mbuf_seg_size, unsigned nb_mbuf,
> > > }
> > > }
> > >
> > > +#ifndef RTE_EXEC_ENV_WINDOWS
> > > err:
> > > if (rte_mp == NULL) {
> > > rte_exit(EXIT_FAILURE,
> > > @@ -1065,6 +1077,7 @@ mbuf_pool_create(uint16_t mbuf_seg_size,
> > > unsigned nb_mbuf,
> > > } else if (verbose_level > 0) {
> > > rte_mempool_dump(stdout, rte_mp);
> > > }
> > > +#endif
> >
> > Why do we need the err flow ifndef'ed? Isn't it needed in the MP_ALLOC_NATIVE case?
>
You are right. Will fix in V11. To avoid the unused err: lable warning, just need to ifndef the err: lable instead of the whole err flow. My mistake.
>
> > > return rte_mp;
> > > }
> > >
next prev parent reply other threads:[~2021-05-05 16:41 UTC|newest]
Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1619805162-10684-1-git-send-email-jizh@linux.microsoft.com>
2021-05-04 0:33 ` [dpdk-stable] [PATCH v10 00/10] app/testpmd: enable testpmd on Windows Jie Zhou
2021-05-04 0:34 ` [dpdk-stable] [PATCH v10 01/10] lib: build libraries that testpmd depends on Jie Zhou
2021-05-04 0:34 ` [dpdk-stable] [PATCH v10 02/10] eal/windows: add necessary macros Jie Zhou
2021-05-04 0:34 ` [dpdk-stable] [PATCH v10 03/10] eal/windows: add device event stubs Jie Zhou
2021-05-04 0:34 ` [dpdk-stable] [PATCH v10 04/10] eal/Windows: add clock_gettime on Windows Jie Zhou
2021-05-04 0:34 ` [dpdk-stable] [PATCH v10 05/10] app/testpmd: resolve name collisions Jie Zhou
2021-05-04 0:34 ` [dpdk-stable] [PATCH v10 06/10] app/testpmd: fix parse_fec_mode return type name Jie Zhou
2021-05-04 0:34 ` [dpdk-stable] [PATCH v10 07/10] app/testpmd: replace POSIX specific code Jie Zhou
2021-05-05 8:34 ` Tal Shnaiderman
2021-05-05 16:09 ` Jie Zhou
2021-05-05 16:41 ` Jie Zhou [this message]
2021-05-04 0:34 ` [dpdk-stable] [PATCH v10 08/10] app/testpmd: fix headers inclusion Jie Zhou
2021-05-04 0:34 ` [dpdk-stable] [PATCH v10 09/10] app/testpmd: fix unused function warnings Jie Zhou
2021-05-04 0:34 ` [dpdk-stable] [PATCH v10 10/10] app/testpmd: enable building testpmd on Windows Jie Zhou
2021-05-04 7:31 ` [dpdk-stable] [PATCH v10 00/10] app/testpmd: enable " Thomas Monjalon
2021-05-05 16:00 ` Jie Zhou
2021-05-04 23:51 ` Kadam, Pallavi
2021-05-05 17:18 ` [dpdk-stable] [PATCH v11 " Jie Zhou
2021-05-05 17:18 ` [dpdk-stable] [PATCH v11 01/10] lib: build libraries that testpmd depends on Jie Zhou
2021-05-05 17:18 ` [dpdk-stable] [PATCH v11 02/10] eal/windows: add necessary macros Jie Zhou
2021-05-05 17:18 ` [dpdk-stable] [PATCH v11 03/10] eal/windows: add device event stubs Jie Zhou
2021-05-05 17:18 ` [dpdk-stable] [PATCH v11 04/10] eal/Windows: add clock_gettime on Windows Jie Zhou
2021-05-05 17:18 ` [dpdk-stable] [PATCH v11 05/10] app/testpmd: resolve name collisions Jie Zhou
2021-05-05 17:18 ` [dpdk-stable] [PATCH v11 06/10] app/testpmd: fix parse_fec_mode return type name Jie Zhou
2021-05-05 17:18 ` [dpdk-stable] [PATCH v11 07/10] app/testpmd: replace POSIX specific code Jie Zhou
2021-05-05 17:18 ` [dpdk-stable] [PATCH v11 08/10] app/testpmd: fix headers inclusion Jie Zhou
2021-05-05 17:18 ` [dpdk-stable] [PATCH v11 09/10] app/testpmd: fix unused function warnings Jie Zhou
2021-05-05 17:18 ` [dpdk-stable] [PATCH v11 10/10] app/testpmd: enable building testpmd on Windows Jie Zhou
2021-05-05 17:36 ` [dpdk-stable] [PATCH v12 00/10] app/testpmd: enable " Jie Zhou
2021-05-05 17:36 ` [dpdk-stable] [PATCH v12 01/10] lib: build libraries that testpmd depends on Jie Zhou
2021-05-05 17:36 ` [dpdk-stable] [PATCH v12 02/10] eal/windows: add necessary macros Jie Zhou
2021-05-05 17:36 ` [dpdk-stable] [PATCH v12 03/10] eal/windows: add device event stubs Jie Zhou
2021-05-05 17:36 ` [dpdk-stable] [PATCH v12 04/10] eal/Windows: add clock_gettime on Windows Jie Zhou
2021-05-05 17:36 ` [dpdk-stable] [PATCH v12 05/10] app/testpmd: resolve name collisions Jie Zhou
2021-05-05 17:36 ` [dpdk-stable] [PATCH v12 06/10] app/testpmd: fix parse_fec_mode return type name Jie Zhou
2021-05-05 17:36 ` [dpdk-stable] [PATCH v12 07/10] app/testpmd: replace POSIX specific code Jie Zhou
2021-05-05 17:36 ` [dpdk-stable] [PATCH v12 08/10] app/testpmd: fix headers inclusion Jie Zhou
2021-05-05 17:36 ` [dpdk-stable] [PATCH v12 09/10] app/testpmd: fix unused function warnings Jie Zhou
2021-05-05 17:36 ` [dpdk-stable] [PATCH v12 10/10] app/testpmd: enable building testpmd on Windows Jie Zhou
2021-05-05 19:12 ` [dpdk-stable] [PATCH v13 00/10] app/testpmd: enable " Jie Zhou
2021-05-05 19:12 ` [dpdk-stable] [PATCH v13 01/10] lib: build libraries that testpmd depends on Jie Zhou
2021-05-05 19:12 ` [dpdk-stable] [PATCH v13 02/10] eal/windows: add necessary macros Jie Zhou
2021-06-20 23:28 ` Dmitry Kozlyuk
2021-06-23 20:51 ` Jie Zhou
2021-05-05 19:12 ` [dpdk-stable] [PATCH v13 03/10] eal/windows: add device event stubs Jie Zhou
2021-06-20 23:28 ` Dmitry Kozlyuk
2021-05-05 19:12 ` [dpdk-stable] [PATCH v13 04/10] eal/Windows: add clock_gettime on Windows Jie Zhou
2021-06-20 23:30 ` Dmitry Kozlyuk
2021-06-23 20:57 ` Jie Zhou
2021-05-05 19:12 ` [dpdk-stable] [PATCH v13 05/10] app/testpmd: resolve name collisions Jie Zhou
2021-06-20 23:30 ` Dmitry Kozlyuk
2021-05-05 19:12 ` [dpdk-stable] [PATCH v13 06/10] app/testpmd: fix parse_fec_mode return type name Jie Zhou
2021-05-05 19:12 ` [dpdk-stable] [PATCH v13 07/10] app/testpmd: replace POSIX specific code Jie Zhou
2021-05-05 19:12 ` [dpdk-stable] [PATCH v13 08/10] app/testpmd: fix headers inclusion Jie Zhou
2021-06-20 23:30 ` Dmitry Kozlyuk
2021-06-23 20:58 ` Jie Zhou
2021-05-05 19:12 ` [dpdk-stable] [PATCH v13 09/10] app/testpmd: fix unused function warnings Jie Zhou
2021-06-20 23:30 ` Dmitry Kozlyuk
2021-06-23 21:26 ` Jie Zhou
2021-06-24 15:45 ` [dpdk-stable] [dpdk-dev] " Tyler Retzlaff
2021-06-24 18:44 ` Dmitry Kozlyuk
2021-06-24 21:36 ` Jie Zhou
2021-05-05 19:12 ` [dpdk-stable] [PATCH v13 10/10] app/testpmd: enable building testpmd on Windows Jie Zhou
2021-06-20 23:30 ` Dmitry Kozlyuk
2021-05-06 7:20 ` [dpdk-stable] [PATCH v13 00/10] app/testpmd: enable " Tal Shnaiderman
2021-06-23 22:34 ` [dpdk-stable] [PATCH v14 0/9] " Jie Zhou
2021-06-23 22:34 ` [dpdk-stable] [PATCH v14 1/9] lib: build libraries that testpmd depends on Jie Zhou
2021-06-24 23:10 ` Dmitry Kozlyuk
2021-06-28 10:01 ` Andrew Rybchenko
2021-06-28 10:35 ` [dpdk-stable] [dpdk-dev] " Andrew Rybchenko
2021-06-28 14:10 ` Tyler Retzlaff
2021-06-29 18:29 ` Jie Zhou
2021-06-23 22:34 ` [dpdk-stable] [PATCH v14 2/9] eal/windows: add necessary macros Jie Zhou
2021-06-24 23:10 ` Dmitry Kozlyuk
2021-06-23 22:34 ` [dpdk-stable] [PATCH v14 3/9] eal/windows: add device event stubs Jie Zhou
2021-06-23 22:34 ` [dpdk-stable] [PATCH v14 4/9] eal/Windows: add clock_gettime on Windows Jie Zhou
2021-06-24 23:10 ` Dmitry Kozlyuk
2021-06-23 22:34 ` [dpdk-stable] [PATCH v14 5/9] app/testpmd: resolve name collisions Jie Zhou
2021-06-23 22:34 ` [dpdk-stable] [PATCH v14 6/9] app/testpmd: fix parse_fec_mode return type name Jie Zhou
2021-06-28 10:55 ` Andrew Rybchenko
2021-06-28 14:29 ` [dpdk-stable] [dpdk-dev] " Tyler Retzlaff
2021-06-29 18:34 ` Jie Zhou
2021-06-23 22:34 ` [dpdk-stable] [PATCH v14 7/9] app/testpmd: replace POSIX specific code Jie Zhou
2021-06-24 23:10 ` Dmitry Kozlyuk
2021-06-23 22:34 ` [dpdk-stable] [PATCH v14 8/9] app/testpmd: fix unused function warnings Jie Zhou
2021-06-24 23:10 ` Dmitry Kozlyuk
2021-06-23 22:34 ` [dpdk-stable] [PATCH v14 9/9] app/testpmd: enable building testpmd on Windows Jie Zhou
2021-06-29 20:23 ` [dpdk-stable] [PATCH v15 0/9] app/testpmd: enable " Jie Zhou
2021-06-29 20:23 ` [dpdk-stable] [PATCH v15 1/9] lib: build libraries that testpmd depends on Jie Zhou
2021-06-29 20:23 ` [dpdk-stable] [PATCH v15 2/9] eal/windows: add necessary macros Jie Zhou
2021-06-29 20:23 ` [dpdk-stable] [PATCH v15 3/9] eal/windows: add device event stubs Jie Zhou
2021-06-29 20:23 ` [dpdk-stable] [PATCH v15 4/9] eal/Windows: add clock_gettime on Windows Jie Zhou
2021-06-29 20:23 ` [dpdk-stable] [PATCH v15 5/9] app/testpmd: resolve name collisions Jie Zhou
2021-06-29 20:23 ` [dpdk-stable] [PATCH v15 6/9] app/testpmd: fix parse_fec_mode return type name Jie Zhou
2021-06-29 20:23 ` [dpdk-stable] [PATCH v15 7/9] app/testpmd: replace POSIX specific code Jie Zhou
2021-06-29 20:23 ` [dpdk-stable] [PATCH v15 8/9] app/testpmd: fix unused function warnings Jie Zhou
2021-06-29 20:23 ` [dpdk-stable] [PATCH v15 9/9] app/testpmd: enable building testpmd on Windows Jie Zhou
2021-06-29 20:50 ` [dpdk-stable] [PATCH v16 0/9] app/testpmd: enable " Jie Zhou
2021-06-29 20:50 ` [dpdk-stable] [PATCH v16 1/9] lib: build libraries that testpmd depends on Jie Zhou
2021-06-29 20:50 ` [dpdk-stable] [PATCH v16 2/9] eal/windows: add necessary macros Jie Zhou
2021-06-29 20:50 ` [dpdk-stable] [PATCH v16 3/9] eal/windows: add device event stubs Jie Zhou
2021-06-29 20:50 ` [dpdk-stable] [PATCH v16 4/9] eal/Windows: add clock_gettime on Windows Jie Zhou
2021-06-29 20:50 ` [dpdk-stable] [PATCH v16 5/9] app/testpmd: resolve name collisions Jie Zhou
2021-07-01 13:41 ` Andrew Rybchenko
2021-06-29 20:50 ` [dpdk-stable] [PATCH v16 6/9] app/testpmd: fix parse_fec_mode return type name Jie Zhou
2021-07-01 13:34 ` Andrew Rybchenko
2021-06-29 20:50 ` [dpdk-stable] [PATCH v16 7/9] app/testpmd: replace POSIX specific code Jie Zhou
2021-06-29 20:50 ` [dpdk-stable] [PATCH v16 8/9] app/testpmd: fix unused function warnings Jie Zhou
2021-06-29 20:50 ` [dpdk-stable] [PATCH v16 9/9] app/testpmd: enable building testpmd on Windows Jie Zhou
2021-07-01 13:49 ` [dpdk-stable] [PATCH v16 0/9] app/testpmd: enable " Andrew Rybchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210505164101.GA30464@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
--to=jizh@linux.microsoft.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=ferruh.yigit@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=pallavi.kadam@intel.com \
--cc=roretzla@microsoft.com \
--cc=stable@dpdk.org \
--cc=talshn@nvidia.com \
--cc=thomas@monjalon.net \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).