* [PATCH v2] net/iavf: fix Tunnel TSO path selecting.
@ 2023-07-06 2:34 Ke Xu
0 siblings, 0 replies; 4+ messages in thread
From: Ke Xu @ 2023-07-06 2:34 UTC (permalink / raw)
To: dev; +Cc: ke1.xu, zhichaox.zeng, wenzhuo.lu, stable
IAVF currently supports TSO and Tunnel TSO. Both these two features
are implemented in scalar path. As there are missed flags for Tunnel
TSO, it selects vector paths wrongly when only Tunnel TSO is enabled
after introducing the patch "net/iavf: add offload path for Tx AVX512".
This patch added the missed flags to fix the Tunnel TSO path selecting.
Fixes: 059f18ae2aec ("net/iavf: add offload path for Tx AVX512")
Cc: stable@dpdk.org
Signed-off-by: Ke Xu <ke1.xu@intel.com>
---
v2: Add fixline, add CC, fix commit message.
---
drivers/net/iavf/iavf_rxtx.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/iavf/iavf_rxtx.h b/drivers/net/iavf/iavf_rxtx.h
index 8d4a77271a..605ea3f824 100644
--- a/drivers/net/iavf/iavf_rxtx.h
+++ b/drivers/net/iavf/iavf_rxtx.h
@@ -31,6 +31,10 @@
RTE_ETH_TX_OFFLOAD_QINQ_INSERT | \
RTE_ETH_TX_OFFLOAD_MULTI_SEGS | \
RTE_ETH_TX_OFFLOAD_TCP_TSO | \
+ RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO | \
+ RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO | \
+ RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO | \
+ RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO | \
RTE_ETH_TX_OFFLOAD_SECURITY)
#define IAVF_TX_VECTOR_OFFLOAD ( \
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH v2] net/iavf: fix Tunnel TSO path selecting.
2023-07-06 6:07 ` Zeng, ZhichaoX
@ 2023-07-06 6:29 ` Zhang, Qi Z
0 siblings, 0 replies; 4+ messages in thread
From: Zhang, Qi Z @ 2023-07-06 6:29 UTC (permalink / raw)
To: Zeng, ZhichaoX, Xu, Ke1, dev; +Cc: Lu, Wenzhuo, stable
> -----Original Message-----
> From: Zeng, ZhichaoX <zhichaox.zeng@intel.com>
> Sent: Thursday, July 6, 2023 2:08 PM
> To: Xu, Ke1 <ke1.xu@intel.com>; dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; stable@dpdk.org
> Subject: RE: [PATCH v2] net/iavf: fix Tunnel TSO path selecting.
>
> > -----Original Message-----
> > From: Xu, Ke1 <ke1.xu@intel.com>
> > Sent: Thursday, July 6, 2023 10:45 AM
> > To: dev@dpdk.org
> > Cc: Xu, Ke1 <ke1.xu@intel.com>; Zeng, ZhichaoX
> > <zhichaox.zeng@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>;
> > stable@dpdk.org
> > Subject: [PATCH v2] net/iavf: fix Tunnel TSO path selecting.
net/iavf: fix Tunnel TSO path selection
> >
> > IAVF currently supports TSO and Tunnel TSO. Both these two features
> > are implemented in scalar path. As there are missed flags for Tunnel
> > TSO, it selects vector paths wrongly when only Tunnel TSO is enabled
> > after introducing the patch "net/iavf: add offload path for Tx AVX512".
> >
> > This patch added the missed flags to fix the Tunnel TSO path selecting.
> >
> > Fixes: 059f18ae2aec ("net/iavf: add offload path for Tx AVX512")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Ke Xu <ke1.xu@intel.com>
> > ---
> > v2: Add fixline, add CC, fix commit message.
> > ---
>
> Acked-by: Zhichao Zeng <zhichaox.zeng@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH v2] net/iavf: fix Tunnel TSO path selecting.
2023-07-06 2:45 ` Ke Xu
@ 2023-07-06 6:07 ` Zeng, ZhichaoX
2023-07-06 6:29 ` Zhang, Qi Z
0 siblings, 1 reply; 4+ messages in thread
From: Zeng, ZhichaoX @ 2023-07-06 6:07 UTC (permalink / raw)
To: Xu, Ke1, dev; +Cc: Lu, Wenzhuo, stable
> -----Original Message-----
> From: Xu, Ke1 <ke1.xu@intel.com>
> Sent: Thursday, July 6, 2023 10:45 AM
> To: dev@dpdk.org
> Cc: Xu, Ke1 <ke1.xu@intel.com>; Zeng, ZhichaoX
> <zhichaox.zeng@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>;
> stable@dpdk.org
> Subject: [PATCH v2] net/iavf: fix Tunnel TSO path selecting.
>
> IAVF currently supports TSO and Tunnel TSO. Both these two features are
> implemented in scalar path. As there are missed flags for Tunnel TSO, it
> selects vector paths wrongly when only Tunnel TSO is enabled after
> introducing the patch "net/iavf: add offload path for Tx AVX512".
>
> This patch added the missed flags to fix the Tunnel TSO path selecting.
>
> Fixes: 059f18ae2aec ("net/iavf: add offload path for Tx AVX512")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ke Xu <ke1.xu@intel.com>
> ---
> v2: Add fixline, add CC, fix commit message.
> ---
Acked-by: Zhichao Zeng <zhichaox.zeng@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] net/iavf: fix Tunnel TSO path selecting.
[not found] <20230705103538.903685-1-ke1.xu@intel.com>
@ 2023-07-06 2:45 ` Ke Xu
2023-07-06 6:07 ` Zeng, ZhichaoX
0 siblings, 1 reply; 4+ messages in thread
From: Ke Xu @ 2023-07-06 2:45 UTC (permalink / raw)
To: dev; +Cc: ke1.xu, zhichaox.zeng, wenzhuo.lu, stable
IAVF currently supports TSO and Tunnel TSO. Both these two features
are implemented in scalar path. As there are missed flags for Tunnel
TSO, it selects vector paths wrongly when only Tunnel TSO is enabled
after introducing the patch "net/iavf: add offload path for Tx AVX512".
This patch added the missed flags to fix the Tunnel TSO path selecting.
Fixes: 059f18ae2aec ("net/iavf: add offload path for Tx AVX512")
Cc: stable@dpdk.org
Signed-off-by: Ke Xu <ke1.xu@intel.com>
---
v2: Add fixline, add CC, fix commit message.
---
drivers/net/iavf/iavf_rxtx.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/iavf/iavf_rxtx.h b/drivers/net/iavf/iavf_rxtx.h
index 8d4a77271a..605ea3f824 100644
--- a/drivers/net/iavf/iavf_rxtx.h
+++ b/drivers/net/iavf/iavf_rxtx.h
@@ -31,6 +31,10 @@
RTE_ETH_TX_OFFLOAD_QINQ_INSERT | \
RTE_ETH_TX_OFFLOAD_MULTI_SEGS | \
RTE_ETH_TX_OFFLOAD_TCP_TSO | \
+ RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO | \
+ RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO | \
+ RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO | \
+ RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO | \
RTE_ETH_TX_OFFLOAD_SECURITY)
#define IAVF_TX_VECTOR_OFFLOAD ( \
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-06 6:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-06 2:34 [PATCH v2] net/iavf: fix Tunnel TSO path selecting Ke Xu
[not found] <20230705103538.903685-1-ke1.xu@intel.com>
2023-07-06 2:45 ` Ke Xu
2023-07-06 6:07 ` Zeng, ZhichaoX
2023-07-06 6:29 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).