patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH 19.11] doc: clarify memory write combining in mlx5 guide
@ 2020-02-27 12:28 Viacheslav Ovsiienko
  2020-02-27 13:13 ` Luca Boccassi
  0 siblings, 1 reply; 2+ messages in thread
From: Viacheslav Ovsiienko @ 2020-02-27 12:28 UTC (permalink / raw)
  To: stable; +Cc: bluca

Just add the words about write combining attribute.

Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
---
 doc/guides/nics/mlx5.rst | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
index 54354fc..86ad404 100644
--- a/doc/guides/nics/mlx5.rst
+++ b/doc/guides/nics/mlx5.rst
@@ -562,16 +562,17 @@ Run-time configuration
   The rdma core library can map doorbell register in two ways, depending on the
   environment variable "MLX5_SHUT_UP_BF":
 
-  - As regular cached memory, if the variable is either missing or set to zero.
+  - As regular cached memory (usually with write combining attribute), if the
+    variable is either missing or set to zero.
   - As non-cached memory, if the variable is present and set to not "0" value.
 
   The type of mapping may slightly affect the Tx performance, the optimal choice
   is strongly relied on the host architecture and should be deduced practically.
 
   If ``tx_db_nc`` is set to zero, the doorbell is forced to be mapped to regular
-  memory, the PMD will perform the extra write memory barrier after writing to
-  doorbell, it might increase the needed CPU clocks per packet to send, but
-  latency might be improved.
+  memory (with write combining), the PMD will perform the extra write memory barrier
+  after writing to doorbell, it might increase the needed CPU clocks per packet
+  to send, but latency might be improved.
 
   If ``tx_db_nc`` is set to one, the doorbell is forced to be mapped to non
   cached memory, the PMD will not perform the extra write memory barrier
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-stable] [PATCH 19.11] doc: clarify memory write combining in mlx5 guide
  2020-02-27 12:28 [dpdk-stable] [PATCH 19.11] doc: clarify memory write combining in mlx5 guide Viacheslav Ovsiienko
@ 2020-02-27 13:13 ` Luca Boccassi
  0 siblings, 0 replies; 2+ messages in thread
From: Luca Boccassi @ 2020-02-27 13:13 UTC (permalink / raw)
  To: Viacheslav Ovsiienko, stable

On Thu, 2020-02-27 at 12:28 +0000, Viacheslav Ovsiienko wrote:
> Just add the words about write combining attribute.
> 
> Signed-off-by: Viacheslav Ovsiienko <
> viacheslavo@mellanox.com
> >
> ---
>  doc/guides/nics/mlx5.rst | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
> index 54354fc..86ad404 100644

Acked-by: Luca Boccassi <luca.boccassi@microsoft.com>

Thanks, applied.

-- 
Kind regards,
Luca Boccassi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-02-27 13:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-27 12:28 [dpdk-stable] [PATCH 19.11] doc: clarify memory write combining in mlx5 guide Viacheslav Ovsiienko
2020-02-27 13:13 ` Luca Boccassi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).