patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH v2] net/netvsc: ignore NVS_TYPE_TXTBL_NOTE while executing a sync command
@ 2020-12-11 20:48 Long Li
  2020-12-15 17:47 ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
  0 siblings, 1 reply; 2+ messages in thread
From: Long Li @ 2020-12-11 20:48 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: dev, Long Li, stable

From: Long Li <longli@microsoft.com>

On netvsc initialization, the host VSP may send a NVS_TYPE_TXTBL_NOTE
packet while executing a VSP command synchronously.

Instead of returning an error, ignore this packet as we don't use it for
DPDK.

Cc: stable@dpdk.org
Signed-off-by: Long Li <longli@microsoft.com>
---
 drivers/net/netvsc/hn_nvs.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/net/netvsc/hn_nvs.c b/drivers/net/netvsc/hn_nvs.c
index a0ee7d8bfa..a97591d16b 100644
--- a/drivers/net/netvsc/hn_nvs.c
+++ b/drivers/net/netvsc/hn_nvs.c
@@ -97,8 +97,13 @@ __hn_nvs_execute(struct hn_data *hv,
 	hdr = (struct hn_nvs_hdr *)buffer;
 
 	/* Silently drop received packets while waiting for response */
-	if (hdr->type == NVS_TYPE_RNDIS) {
+	switch (hdr->type) {
+	case NVS_TYPE_RNDIS:
 		hn_nvs_ack_rxbuf(chan, xactid);
+		/* fallthrough */
+
+	case NVS_TYPE_TXTBL_NOTE:
+		PMD_DRV_LOG(DEBUG, "discard packet type 0x%x", hdr->type);
 		goto retry;
 	}
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] net/netvsc: ignore NVS_TYPE_TXTBL_NOTE while executing a sync command
  2020-12-11 20:48 [dpdk-stable] [PATCH v2] net/netvsc: ignore NVS_TYPE_TXTBL_NOTE while executing a sync command Long Li
@ 2020-12-15 17:47 ` Ferruh Yigit
  0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2020-12-15 17:47 UTC (permalink / raw)
  To: Long Li, Stephen Hemminger; +Cc: dev, Long Li, stable

On 12/11/2020 8:48 PM, Long Li wrote:
> From: Long Li <longli@microsoft.com>
> 
> On netvsc initialization, the host VSP may send a NVS_TYPE_TXTBL_NOTE
> packet while executing a VSP command synchronously.
> 
> Instead of returning an error, ignore this packet as we don't use it for
> DPDK.
> 
> Cc: stable@dpdk.org
> Signed-off-by: Long Li <longli@microsoft.com>

Applied to dpdk-next-net/main, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-12-15 17:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-11 20:48 [dpdk-stable] [PATCH v2] net/netvsc: ignore NVS_TYPE_TXTBL_NOTE while executing a sync command Long Li
2020-12-15 17:47 ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git