From: Kevin Traynor <ktraynor@redhat.com>
To: Olivier Matz <olivier.matz@6wind.com>, stable@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>,
Radu Nicolau <radu.nicolau@intel.com>
Subject: Re: [dpdk-stable] [PATCH 18.11] examples/multi_process: fix compilation
Date: Wed, 2 Dec 2020 14:42:33 +0000 [thread overview]
Message-ID: <838afee8-fe95-84a4-c3c5-c547811f1f02@redhat.com> (raw)
In-Reply-To: <20201202143849.26557-1-olivier.matz@6wind.com>
On 02/12/2020 14:38, Olivier Matz wrote:
> Fix compilation of examples/multi_process:
>
>> examples/multi_process/client_server_mp/mp_server/main.c:68:4: error:
>> implicit declaration of function ‘rte_ether_format_addr’;
>> did you mean ‘ether_format_addr’? [-Werror=implicit-function-declaration]
>> rte_ether_format_addr(err_address,
>> ^~~~~~~~~~~~~~~~~~~~~
>
> This failure happens after the backport of
> commit a7500412fc5c ("examples/multi_process: fix build on Ubuntu
> 20.04"), which uses a function that does not exist in this branch. The
> function was introduced by upstream commit 538da7a1cad2 ("net: add rte
> prefix to ether functions"), and is just a renaming of an existing
> function.
>
Thanks Olivier. I had noticed this too and fixed locally. I will take
your patch as you sent it upstream first.
> Fixes: a7500412fc5c ("examples/multi_process: fix build on Ubuntu 20.04")
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> ---
> examples/multi_process/client_server_mp/mp_server/main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/examples/multi_process/client_server_mp/mp_server/main.c b/examples/multi_process/client_server_mp/mp_server/main.c
> index 1a5bf534ff..62abd62cf3 100644
> --- a/examples/multi_process/client_server_mp/mp_server/main.c
> +++ b/examples/multi_process/client_server_mp/mp_server/main.c
> @@ -65,14 +65,14 @@ get_printable_mac_addr(uint16_t port)
>
> if (unlikely(port >= RTE_MAX_ETHPORTS)) {
> if (err_address[0] == '\0')
> - rte_ether_format_addr(err_address,
> + ether_format_addr(err_address,
> sizeof(err_address), &null_mac);
> return err_address;
> }
> if (unlikely(addresses[port][0]=='\0')){
> struct ether_addr mac;
> rte_eth_macaddr_get(port, &mac);
> - rte_ether_format_addr(addresses[port],
> + ether_format_addr(addresses[port],
> sizeof(addresses[port]), &mac);
> }
> return addresses[port];
>
next prev parent reply other threads:[~2020-12-02 14:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 14:38 Olivier Matz
2020-12-02 14:42 ` Kevin Traynor [this message]
2020-12-03 16:41 ` Kevin Traynor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=838afee8-fe95-84a4-c3c5-c547811f1f02@redhat.com \
--to=ktraynor@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=olivier.matz@6wind.com \
--cc=radu.nicolau@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).