patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: Juraj Linkeš <juraj.linkes@pantheon.tech>,
	Ruifeng Wang <Ruifeng.Wang@arm.com>,
	"thomas@monjalon.net" <thomas@monjalon.net>,
	"david.marchand@redhat.com" <david.marchand@redhat.com>,
	"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
	"aconole@redhat.com" <aconole@redhat.com>,
	"maicolgabriel@hotmail.com" <maicolgabriel@hotmail.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"arybchenko@solarflare.com" <arybchenko@solarflare.com>,
	"stable@dpdk.org" <stable@dpdk.org>, nd <nd@arm.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v16 1/8] net/sfc: fix aarch32 build
Date: Wed, 21 Apr 2021 17:20:04 +0300
Message-ID: <847c00bd-d210-c5c6-c8bc-3232f7e17f8b@oktetlabs.ru> (raw)
In-Reply-To: <dcff330e8b5742a9aef4a573d6950036@pantheon.tech>

On 4/21/21 5:08 PM, Juraj Linkeš wrote:
> 
> 
>> -----Original Message-----
>> From: Ruifeng Wang <Ruifeng.Wang@arm.com>
>> Sent: Wednesday, April 21, 2021 12:06 PM
>> To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>; Juraj Linkeš
>> <juraj.linkes@pantheon.tech>; thomas@monjalon.net;
>> david.marchand@redhat.com; bruce.richardson@intel.com;
>> aconole@redhat.com; maicolgabriel@hotmail.com
>> Cc: dev@dpdk.org; arybchenko@solarflare.com; stable@dpdk.org; nd
>> <nd@arm.com>
>> Subject: RE: [dpdk-dev] [PATCH v16 1/8] net/sfc: fix aarch32 build
>>
>>> -----Original Message-----
>>> From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>>> Sent: Wednesday, April 21, 2021 5:05 PM
>>> To: Juraj Linkeš <juraj.linkes@pantheon.tech>; thomas@monjalon.net;
>>> david.marchand@redhat.com; bruce.richardson@intel.com;
>>> aconole@redhat.com; maicolgabriel@hotmail.com
>>> Cc: dev@dpdk.org; Ruifeng Wang <Ruifeng.Wang@arm.com>;
>>> arybchenko@solarflare.com; stable@dpdk.org
>>> Subject: Re: [dpdk-dev] [PATCH v16 1/8] net/sfc: fix aarch32 build
>>>
>>> On 4/21/21 11:50 AM, Juraj Linkeš wrote:
>>>> From: Ruifeng Wang <ruifeng.wang@arm.com>
>>>>
>>>> The sfc PMD was enabled for aarch32 which is 32-bit mode but has
>>>> cpu_family set to aarch64.
>>>> As sfc support only 64-bit system, it should be disabled for aarch32.
>>>>
>>>> Updated meson file to disable sfc for aarch32 build.
>>>>
>>>> Fixes: 141d2870675a ("net/sfc: support aarch64 architecture")
>>>> Cc: arybchenko@solarflare.com
>>>> Cc: stable@dpdk.org
>>>>
>>>> Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
>>>> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>>>
>>> Withdraw my ack
>>>
>>>> ---
>>>>  drivers/common/sfc_efx/meson.build | 2 +-
>>>>  drivers/net/sfc/meson.build        | 2 +-
>>>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/drivers/common/sfc_efx/meson.build
>>>> b/drivers/common/sfc_efx/meson.build
>>>> index 1ca9510733..db5a6a8b42 100644
>>>> --- a/drivers/common/sfc_efx/meson.build
>>>> +++ b/drivers/common/sfc_efx/meson.build
>>>> @@ -10,7 +10,7 @@ if is_windows
>>>>  	reason = 'not supported on Windows'
>>>>  endif
>>>>
>>>> -if (arch_subdir != 'x86' or not dpdk_conf.get('RTE_ARCH_64')) and
>>>> (arch_subdir != 'arm' or not
>>>> host_machine.cpu_family().startswith('aarch64'))
>>>> +if (arch_subdir != 'x86' or arch_subdir != 'arm') and (not
>>>> +dpdk_conf.get('RTE_ARCH_64'))
>>>
>>> Am I missing something or condition in parenthesis is always true? I
>>> think it
>>
> 
> Thanks for catching this.
> 
>> Oops, it should be an 'and' in the parenthesis.
>>
>>> should be:
>>>
>>> if arch_subdir != 'x86' or arch_subdir != 'arm' or not
>>> dpdk_conf.get('RTE_ARCH_64')
>>
>> I assume you meant to use 'and's.
>>
> 
> I believe the actual correct condition is:
> (arch_subdir != 'x86' and arch_subdir != 'arm') or (not dpdk_conf.get('RTE_ARCH_64'))
> 
> This should result in 'only supported on x86_64 and aarch64'.

Yes, many thanks.

Andrew.

> 
>>>
>>>>  	build = false
>>>>  	reason = 'only supported on x86_64 and aarch64'
>>>>  endif
>>>> diff --git a/drivers/net/sfc/meson.build
>>>> b/drivers/net/sfc/meson.build index 0c5cfb9058..0a96235e33 100644
>>>> --- a/drivers/net/sfc/meson.build
>>>> +++ b/drivers/net/sfc/meson.build
>>>> @@ -12,7 +12,7 @@ if is_windows
>>>>  	subdir_done()
>>>>  endif
>>>>
>>>> -if (arch_subdir != 'x86' or not dpdk_conf.get('RTE_ARCH_64')) and
>>>> (arch_subdir != 'arm' or not
>>>> host_machine.cpu_family().startswith('aarch64'))
>>>> +if (arch_subdir != 'x86' or arch_subdir != 'arm') and (not
>>>> +dpdk_conf.get('RTE_ARCH_64'))
>>>
>>> same here.
>>>
>>>>  	build = false
>>>>  	reason = 'only supported on x86_64 and aarch64'
>>>>  endif
>>>>
> 


  reply	other threads:[~2021-04-21 14:20 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1600244472-29696-1-git-send-email-juraj.linkes@pantheon.tech>
     [not found] ` <1607518771-7564-1-git-send-email-juraj.linkes@pantheon.tech>
2020-12-09 12:59   ` [dpdk-stable] [PATCH v11 1/7] " Juraj Linkeš
2020-12-09 13:37     ` [dpdk-stable] ***Spam*** " Andrew Rybchenko
2020-12-09 12:59   ` [dpdk-stable] [PATCH v11 2/7] net/bnxt: " Juraj Linkeš
2020-12-09 14:10     ` Lance Richardson
2020-12-09 14:16       ` Ruifeng Wang
2020-12-09 18:56     ` [dpdk-stable] [dpdk-dev] " Ajit Khaparde
2020-12-09 19:08     ` Ajit Khaparde
     [not found]   ` <1607675213-12061-1-git-send-email-juraj.linkes@pantheon.tech>
2020-12-11  8:26     ` [dpdk-stable] [PATCH v12 1/6] net/sfc: " Juraj Linkeš
2020-12-11  8:26     ` [dpdk-stable] [PATCH v12 2/6] net/bnxt: " Juraj Linkeš
     [not found]     ` <1615279005-30278-1-git-send-email-juraj.linkes@pantheon.tech>
2021-03-09  8:36       ` [dpdk-stable] [PATCH v13 1/7] net/sfc: " Juraj Linkeš
2021-03-09  8:36       ` [dpdk-stable] [PATCH v13 2/7] net/bnxt: " Juraj Linkeš
2021-03-09  8:36       ` [dpdk-stable] [PATCH v13 3/7] net/virtio: " Juraj Linkeš
     [not found]       ` <1615988163-17371-1-git-send-email-juraj.linkes@pantheon.tech>
2021-03-17 13:35         ` [dpdk-stable] [PATCH v14 1/7] net/sfc: " Juraj Linkeš
2021-03-17 13:35         ` [dpdk-stable] [PATCH v14 2/7] net/bnxt: " Juraj Linkeš
2021-03-17 13:35         ` [dpdk-stable] [PATCH v14 3/7] net/virtio: " Juraj Linkeš
     [not found]         ` <1618995020-4775-1-git-send-email-juraj.linkes@pantheon.tech>
2021-04-21  8:50           ` [dpdk-stable] [PATCH v16 1/8] net/sfc: " Juraj Linkeš
2021-04-21  9:04             ` [dpdk-stable] [dpdk-dev] " Andrew Rybchenko
2021-04-21 10:06               ` Ruifeng Wang
2021-04-21 14:08                 ` Juraj Linkeš
2021-04-21 14:20                   ` Andrew Rybchenko [this message]
2021-04-21  8:50           ` [dpdk-stable] [PATCH v16 2/8] net/bnxt: " Juraj Linkeš
2021-04-21  8:50           ` [dpdk-stable] [PATCH v16 3/8] net/virtio: " Juraj Linkeš
2021-04-21  9:16             ` [dpdk-stable] [dpdk-dev] " Maxime Coquelin
     [not found]           ` <1619095749-7948-1-git-send-email-juraj.linkes@pantheon.tech>
2021-04-22 12:49             ` [dpdk-stable] [PATCH v17 1/8] net/sfc: " Juraj Linkeš
2021-04-22 12:49             ` [dpdk-stable] [PATCH v17 2/8] net/bnxt: " Juraj Linkeš
2021-04-22 18:50               ` Ajit Khaparde
2021-04-22 12:49             ` [dpdk-stable] [PATCH v17 3/8] net/virtio: " Juraj Linkeš
     [not found]             ` <1625664343-26498-1-git-send-email-juraj.linkes@pantheon.tech>
2021-07-07 13:25               ` [dpdk-stable] [PATCH v18 1/7] net/sfc: " Juraj Linkeš
2021-07-07 13:25               ` [dpdk-stable] [PATCH v18 2/7] net/bnxt: " Juraj Linkeš
2021-07-07 13:25               ` [dpdk-stable] [PATCH v18 3/7] net/virtio: " Juraj Linkeš

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=847c00bd-d210-c5c6-c8bc-3232f7e17f8b@oktetlabs.ru \
    --to=andrew.rybchenko@oktetlabs.ru \
    --cc=Ruifeng.Wang@arm.com \
    --cc=aconole@redhat.com \
    --cc=arybchenko@solarflare.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=juraj.linkes@pantheon.tech \
    --cc=maicolgabriel@hotmail.com \
    --cc=nd@arm.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git