patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: Luca Boccassi <bluca@debian.org>,
	Christian Ehrhardt <christian.ehrhardt@canonical.com>,
	dpdk stable <stable@dpdk.org>, Akhil Goyal <akhil.goyal@nxp.com>
Subject: Re: [dpdk-stable] Why was "drivers/crypto: fix build with -fno-common" not picked for 19.11 stable back then?
Date: Mon, 28 Jun 2021 10:47:50 +0100
Message-ID: <8a5c03be-cca7-2659-d652-fc7abc0619f7@redhat.com> (raw)
In-Reply-To: <205f243e1ed6df6d5b17817e6af4a91f0705fb56.camel@debian.org>

On 28/06/2021 10:13, Luca Boccassi wrote:
> On Mon, 2021-06-28 at 09:34 +0200, Christian Ehrhardt wrote:
>> Hi,
>> there is an old patch [1] which back then was not considered/taken
>> into 19.11 series.
>> This is now breaking Clang build [2].
>>
>> Since you were the Author/Maintainers back then I wanted to ask if
>> there was a reason to not pick it? If it should be picked now and if
>> there are any special things to consider for a backport?
>>
>> Chiming in/subscribing to the bug would also be appreciated.
>>
>> [1]: https://github.com/DPDK/dpdk/commit/eef9e0412a84cddf8944379ed4995314b4369370
>> [2]: https://bugs.dpdk.org/show_bug.cgi?id=733#c6
> 
> Can't remember the details about this particular one, but I think
> several fixes were backported for the -fno-common issue in 19.11
> 

I have some recollection is that as -fcommon was the default in gcc at
the time of 18.11/19.11 release, using the patch 50b03f3b8eaf
("drivers/crypto: disable gcc 10 no-common errors") to continue to keep
it building in the same way, may have been seen as more acceptable in
stable than using the same patch on main when gcc had a different default.

I had to send that patch as there was no fuller solution provided by the
crypto maintainers at the time. Then, late on it was provided and
applied to main.

So it might have been a mix of the workaround seen as good enough for
stable and the other patch coming in late, but I'm not 100% about it.


      reply	other threads:[~2021-06-28  9:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-28  7:34 Christian Ehrhardt
2021-06-28  9:13 ` Luca Boccassi
2021-06-28  9:47   ` Kevin Traynor [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8a5c03be-cca7-2659-d652-fc7abc0619f7@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=akhil.goyal@nxp.com \
    --cc=bluca@debian.org \
    --cc=christian.ehrhardt@canonical.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git