From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: David Marchand <david.marchand@redhat.com>, dev@dpdk.org
Cc: stable@dpdk.org, Chenbo Xia <chenbo.xia@intel.com>,
Jiayu Hu <jiayu.hu@intel.com>,
Cheng Jiang <cheng1.jiang@intel.com>
Subject: Re: [PATCH 02/11] vhost: fix build with clang 15
Date: Fri, 18 Nov 2022 11:23:43 +0100 [thread overview]
Message-ID: <9fe17726-fc4d-0f62-3a59-1e8640c92afa@redhat.com> (raw)
In-Reply-To: <20221118085313.2118977-3-david.marchand@redhat.com>
On 11/18/22 09:53, David Marchand wrote:
> This variable is not used.
>
> Fixes: abeb86525577 ("vhost: remove copy threshold for async path")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> lib/vhost/virtio_net.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c
> index 4358899718..9abf752f30 100644
> --- a/lib/vhost/virtio_net.c
> +++ b/lib/vhost/virtio_net.c
> @@ -1877,7 +1877,6 @@ virtio_dev_rx_async_submit_packed(struct virtio_net *dev, struct vhost_virtqueue
> struct rte_mbuf **pkts, uint32_t count, int16_t dma_id, uint16_t vchan_id)
> {
> uint32_t pkt_idx = 0;
> - uint32_t remained = count;
> uint16_t n_xfer;
> uint16_t num_buffers;
> uint16_t num_descs;
> @@ -1903,7 +1902,6 @@ virtio_dev_rx_async_submit_packed(struct virtio_net *dev, struct vhost_virtqueue
> pkts_info[slot_idx].mbuf = pkts[pkt_idx];
>
> pkt_idx++;
> - remained--;
> vq_inc_last_avail_packed(vq, num_descs);
> } while (pkt_idx < count);
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
next prev parent reply other threads:[~2022-11-18 10:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221118085313.2118977-1-david.marchand@redhat.com>
2022-11-18 8:53 ` [PATCH 01/11] service: " David Marchand
2022-11-18 14:47 ` Van Haaren, Harry
2022-11-18 8:53 ` [PATCH 02/11] vhost: " David Marchand
2022-11-18 10:23 ` Maxime Coquelin [this message]
2022-11-18 8:53 ` [PATCH 03/11] bus/dpaa: " David Marchand
2022-11-18 8:53 ` [PATCH 04/11] net/atlantic: " David Marchand
2022-11-18 8:53 ` [PATCH 05/11] net/dpaa2: " David Marchand
2022-11-18 8:53 ` [PATCH 06/11] net/ice: " David Marchand
2022-11-18 8:53 ` [PATCH 07/11] app/testpmd: " David Marchand
2022-11-18 8:53 ` [PATCH 08/11] app/testpmd: fix build with clang 15 in flow code David Marchand
2022-11-18 8:53 ` [PATCH 09/11] test/efd: fix build with clang 15 David Marchand
2022-11-18 8:53 ` [PATCH 10/11] test/member: " David Marchand
2022-11-18 8:53 ` [PATCH 11/11] test/event: " David Marchand
2022-11-21 1:51 ` Gao, DaxueX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fe17726-fc4d-0f62-3a59-1e8640c92afa@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=cheng1.jiang@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).