Re: [dpdk-stable] [PATCH v1 1/5] vhost: fix add a missing include

Re: [dpdk-stable] [PATCH v1 1/5] vhost: fix add a missing include

[Matan Azrad]

 From: Noa Ezra
> Add a missing include with the defines for vhost-user driver features.
> 
> Fixes: 5fbb3941da9f ("vhost: introduce driver features related APIs")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Noa Ezra <noae@mellanox.com>

Reviewed-by: Matan Azrad <matan@mellanox.com>
For all the series.

> ---
>  lib/librte_vhost/rte_vhost.h | 1 +
>  1 file changed, 1 insertion(+)
>  mode change 100644 => 100755 lib/librte_vhost/rte_vhost.h
> 
> diff --git a/lib/librte_vhost/rte_vhost.h b/lib/librte_vhost/rte_vhost.h old
> mode 100644 new mode 100755 index 0226b3e..338e47c
> --- a/lib/librte_vhost/rte_vhost.h
> +++ b/lib/librte_vhost/rte_vhost.h
> @@ -23,6 +23,7 @@
>  /* These are not C++-aware. */
>  #include <linux/vhost.h>
>  #include <linux/virtio_ring.h>
> +#include <linux/virtio_net.h>
> 
>  #define RTE_VHOST_USER_CLIENT		(1ULL << 0)
>  #define RTE_VHOST_USER_NO_RECONNECT	(1ULL << 1)
> --
> 1.8.3.1

Re: [dpdk-stable] [PATCH v1 1/5] vhost: fix add a missing include

[Noa Ezra]

Hi,
Does anyone else want to review this patch?

Thanks,
Noa.

-----Original Message-----
From: Matan Azrad 
Sent: Sunday, May 26, 2019 1:23 PM
To: Noa Ezra <noae@mellanox.com>; dev@dpdk.org; maxime.coquelin@redhat.com
Cc: Noa Ezra <noae@mellanox.com>; stable@dpdk.org
Subject: RE: [PATCH v1 1/5] vhost: fix add a missing include



 From: Noa Ezra
> Add a missing include with the defines for vhost-user driver features.
> 
> Fixes: 5fbb3941da9f ("vhost: introduce driver features related APIs")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Noa Ezra <noae@mellanox.com>

Reviewed-by: Matan Azrad <matan@mellanox.com> For all the series.

> ---
>  lib/librte_vhost/rte_vhost.h | 1 +
>  1 file changed, 1 insertion(+)
>  mode change 100644 => 100755 lib/librte_vhost/rte_vhost.h
> 
> diff --git a/lib/librte_vhost/rte_vhost.h 
> b/lib/librte_vhost/rte_vhost.h old mode 100644 new mode 100755 index 
> 0226b3e..338e47c
> --- a/lib/librte_vhost/rte_vhost.h
> +++ b/lib/librte_vhost/rte_vhost.h
> @@ -23,6 +23,7 @@
>  /* These are not C++-aware. */
>  #include <linux/vhost.h>
>  #include <linux/virtio_ring.h>
> +#include <linux/virtio_net.h>
> 
>  #define RTE_VHOST_USER_CLIENT		(1ULL << 0)
>  #define RTE_VHOST_USER_NO_RECONNECT	(1ULL << 1)
> --
> 1.8.3.1

Re: [dpdk-stable] [PATCH v1 1/5] vhost: fix add a missing include

[Maxime Coquelin]

On 6/18/19 8:24 AM, Noa Ezra wrote:
> Hi,
> Does anyone else want to review this patch?

I do, but it seems that the other 4 patches of the series aren't on
dev@dpdk.org, is that expected?

> Thanks,
> Noa.
> 
> -----Original Message-----
> From: Matan Azrad
> Sent: Sunday, May 26, 2019 1:23 PM
> To: Noa Ezra <noae@mellanox.com>; dev@dpdk.org; maxime.coquelin@redhat.com
> Cc: Noa Ezra <noae@mellanox.com>; stable@dpdk.org
> Subject: RE: [PATCH v1 1/5] vhost: fix add a missing include
> 
> 
> 
>   From: Noa Ezra
>> Add a missing include with the defines for vhost-user driver features.
>>
>> Fixes: 5fbb3941da9f ("vhost: introduce driver features related APIs")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Noa Ezra <noae@mellanox.com>
> 
> Reviewed-by: Matan Azrad <matan@mellanox.com> For all the series.

For this patch only:
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime

> 
>> ---
>>   lib/librte_vhost/rte_vhost.h | 1 +
>>   1 file changed, 1 insertion(+)
>>   mode change 100644 => 100755 lib/librte_vhost/rte_vhost.h
>>
>> diff --git a/lib/librte_vhost/rte_vhost.h
>> b/lib/librte_vhost/rte_vhost.h old mode 100644 new mode 100755 index
>> 0226b3e..338e47c
>> --- a/lib/librte_vhost/rte_vhost.h
>> +++ b/lib/librte_vhost/rte_vhost.h
>> @@ -23,6 +23,7 @@
>>   /* These are not C++-aware. */
>>   #include <linux/vhost.h>
>>   #include <linux/virtio_ring.h>
>> +#include <linux/virtio_net.h>
>>
>>   #define RTE_VHOST_USER_CLIENT		(1ULL << 0)
>>   #define RTE_VHOST_USER_NO_RECONNECT	(1ULL << 1)
>> --
>> 1.8.3.1
>