patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Wisam Monther <>
To: Thomas Monjalon <>
Cc: "" <>,
	Raslan Darawsheh <>,
	"" <>,
	"" <>,
	"" <>
Subject: Re: [dpdk-stable] [PATCH] lib/cmdline_rdline: increase command line buf size
Date: Thu, 20 Feb 2020 14:06:12 +0000
Message-ID: <> (raw)
In-Reply-To: <4718348.687JKscXgg@xps>


Sure I'll handle the title with the right prefix.

- consequence on memory usage?
I don't think it will affect much,
Since we are reading from the same buffer all the time,
Read -> reset -> read again -> ...etc

- How critical is this change?
For now it's not that critical, but for testing perspective I think it's critical,
And it's a must to have so we can check un touched scenarios.
one rule can have outer items, inner items, actions ={ header rewrite, meta actions, duplicate actions, fate action, ..etc} 
thus to test such combination we need to parse more in the cmdline

- Which kind of command is so long?
RTE_FLOW Example:
flow create 2 ingress priority 0 group 4 transfer pattern eth / ipv4 tos spec 0x0 ttl spec 0x0 proto spec 0x6 src spec dst spec tos mask 0x0 ttl mask 0x0 proto mask 0x0 src mask dst mask / tcp src spec 5001 dst spec 38392 flags spec 0x0 src mask 65535 dst mask 65535 flags mask 0x5 / tag index is 0 data spec 0x00000200 data mask 0x0000ff00 / end actions count / set_tag index 0 data 0x00000200 mask 0x0000ff00 / set_tag index 0 data 0x0000002a mask 0x000000ff / set_meta data 0x00000001 mask 0x0000ffff / jump group 7 / end

Wisam Jaddo

-----Original Message-----
From: Thomas Monjalon <> 
Sent: Thursday, February 20, 2020 3:43 PM
To: Wisam Monther <>
Cc:; Raslan Darawsheh <>;;;
Subject: Re: [dpdk-stable] [PATCH] lib/cmdline_rdline: increase command line buf size


About the title, I suggest:
cmdline: increase maximum line length

20/02/2020 14:18, Wisam Jaddo:
> The current size of buffer is not enough to fit all allowed 
> items/actions, thus it will block a lot of testing.
> Cc:

+Cc maintainers of cmdline and testpmd

> Signed-off-by: Wisam Jaddo <>
> -#define RDLINE_BUF_SIZE 512
> +#define RDLINE_BUF_SIZE 2048

I feel 2k is reasonable.
What is the consequence on memory usage?

How critical is this change?
Which kind of command is so long?

  reply	other threads:[~2020-02-20 14:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-20 13:18 Wisam Jaddo
2020-02-20 13:42 ` Thomas Monjalon
2020-02-20 14:06   ` Wisam Monther [this message]
2020-02-20 14:53 ` [dpdk-stable] [PATCH v3] cmdline: increase maximum line length Wisam Jaddo
2020-02-22 15:28   ` [dpdk-stable] [dpdk-dev] " David Marchand
2020-07-31 12:55     ` Olivier Matz
2020-07-31 13:00       ` David Marchand
2020-07-31 15:46       ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ \
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:

AGPL code for this site: git clone