patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Ruifeng Wang <Ruifeng.Wang@arm.com>
To: Michael Pfeiffer <michael.pfeiffer@tu-ilmenau.de>,
	Jan Viktorin <viktorin@rehivetech.com>,
	"jerinj@marvell.com" <jerinj@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"kosar@rehivetech.com" <kosar@rehivetech.com>,
	"stable@dpdk.org" <stable@dpdk.org>, nd <nd@arm.com>
Subject: Re: [dpdk-stable] [PATCH v3] eal: arm: fix out of tree build
Date: Tue, 8 Jun 2021 09:56:20 +0000
Message-ID: <AM5PR0802MB2465D700FA41A4DEAC44C10D9E379@AM5PR0802MB2465.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20210607065325.12140-1-michael.pfeiffer@tu-ilmenau.de>

> -----Original Message-----
> From: Michael Pfeiffer <michael.pfeiffer@tu-ilmenau.de>
> Sent: Monday, June 7, 2021 2:53 PM
> To: Jan Viktorin <viktorin@rehivetech.com>; Ruifeng Wang
> <Ruifeng.Wang@arm.com>; jerinj@marvell.com
> Cc: dev@dpdk.org; Michael Pfeiffer <michael.pfeiffer@tu-ilmenau.de>;
> kosar@rehivetech.com; stable@dpdk.org
> Subject: [PATCH v3] eal: arm: fix out of tree build
> 
> Including rte_byteorder.h may fail for ARM builds with 'Platform must be
> built with RTE_FORCE_INTRINSICS' if rte_config.h is not included before.
> Include rte_config.h from rte_byteorder.h to solve the issue.
> 
> Fixes: de966ccdcd7f ("eal/arm: add byte order operations for ARM")
> Cc: kosar@rehivetech.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Michael Pfeiffer <michael.pfeiffer@tu-ilmenau.de>
> ---
> v3:
> * Proper in-reply-to.
> 
> v2:
> * Fixed subject line.
> * Add "Fixes:" and CC to stable.
> 
>  lib/eal/arm/include/rte_byteorder.h | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/lib/eal/arm/include/rte_byteorder.h
> b/lib/eal/arm/include/rte_byteorder.h
> index df2f1d87ba..1f90db9943 100644
> --- a/lib/eal/arm/include/rte_byteorder.h
> +++ b/lib/eal/arm/include/rte_byteorder.h
> @@ -5,18 +5,19 @@
>  #ifndef _RTE_BYTEORDER_ARM_H_
>  #define _RTE_BYTEORDER_ARM_H_
> 
> -#ifndef RTE_FORCE_INTRINSICS
> -#  error Platform must be built with RTE_FORCE_INTRINSICS -#endif
> -
Moving of this section solves the problem.

>  #ifdef __cplusplus
>  extern "C" {
>  #endif
> 
>  #include <stdint.h>
>  #include <rte_common.h>
> +#include <rte_config.h>
rte_config.h is included by rte_common.h in above line.

>  #include "generic/rte_byteorder.h"
> 
> +#ifndef RTE_FORCE_INTRINSICS
> +#  error Platform must be built with RTE_FORCE_INTRINSICS #endif
> +
>  /* fix missing __builtin_bswap16 for gcc older then 4.8 */  #if !(__GNUC__ >
> 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 8))
> 
> --
> 2.31.1

I see similar issue in rte_atomic32.h/rte_atomic64.h/rte_spinlock.h/rte_ticketlock.h/rte_mcslock.h in lib/eal/arm/include.
Do you want to fix all these?
Thanks.

  reply	other threads:[~2021-06-08  9:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CALBAE1N_XJqwA1ypCZ6bMq1edGjLefGc41SM4yUwyDoufWgcSw@mail.gmail.com>
2021-06-07  6:53 ` Michael Pfeiffer
2021-06-08  9:56   ` Ruifeng Wang [this message]
2021-06-08 10:29     ` [dpdk-stable] [PATCH v4] " Michael Pfeiffer
2021-06-09  7:27       ` Ruifeng Wang
2021-06-09 10:17         ` [dpdk-stable] [PATCH v5] " Michael Pfeiffer
2021-06-09 10:22           ` Ruifeng Wang
2021-06-09 11:43           ` [dpdk-stable] [dpdk-dev] " Jerin Jacob
2021-06-11  9:54           ` [dpdk-stable] " David Marchand
2021-06-11  9:59             ` Bruce Richardson
2021-06-11 10:27               ` Michael Pfeiffer
2021-06-11 10:44                 ` Ruifeng Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM5PR0802MB2465D700FA41A4DEAC44C10D9E379@AM5PR0802MB2465.eurprd08.prod.outlook.com \
    --to=ruifeng.wang@arm.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=kosar@rehivetech.com \
    --cc=michael.pfeiffer@tu-ilmenau.de \
    --cc=nd@arm.com \
    --cc=stable@dpdk.org \
    --cc=viktorin@rehivetech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git