patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
To: Apeksha Gupta <apeksha.gupta@nxp.com>,
	"jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"thomas@monjalon.net" <thomas@monjalon.net>,
	"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
	"nipun.gupta@nxp.com" <nipun.gupta@nxp.com>,
	"akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 5/6] app/test-eventdev: Enhancing perf-atq packet	flow
Date: Thu, 2 Jul 2020 03:25:07 +0000
Message-ID: <BN6PR18MB114085EF59420690856F6279DE6D0@BN6PR18MB1140.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20200701060626.28627-5-apeksha.gupta@nxp.com>

>Subject: [dpdk-dev] [PATCH 5/6] app/test-eventdev: Enhancing perf-atq
>packet flow
>
>The event ethernet Tx adapter provides data path for the ethernet
>transmit
>stage. Enqueue a burst of events objects supplied on an event device.

NAK, same as 1/6 use pipeline_atq/queue to test Rx->Tx performace.

>
>Fixes: 1eb10ad8db8 ("app/testeventdev: add perf all types queue
>worker")
>Cc: stable@dpdk.org
>
>Signed-off-by: Apeksha Gupta <apeksha.gupta@nxp.com>
>---
> app/test-eventdev/test_perf_atq.c    | 43 ++++++++++++++++++++------
>--
> app/test-eventdev/test_perf_common.h |  4 +++
> 2 files changed, 35 insertions(+), 12 deletions(-)
>
>diff --git a/app/test-eventdev/test_perf_atq.c b/app/test-
>eventdev/test_perf_atq.c
>index d0241ec4ae..23e9ad4a29 100644
>--- a/app/test-eventdev/test_perf_atq.c
>+++ b/app/test-eventdev/test_perf_atq.c
>@@ -70,10 +70,12 @@ perf_atq_worker(void *arg, const int
>enable_fwd_latency)
> }
>
> static int
>-perf_atq_worker_burst(void *arg, const int enable_fwd_latency)
>+perf_atq_worker_burst(void *arg, const int enable_fwd_latency,
>+					const uint32_t flags)
> {
> 	PERF_WORKER_INIT;
> 	uint16_t i;
>+	uint16_t nb_tx;
> 	/* +1 to avoid prefetch out of array check */
> 	struct rte_event ev[BURST_SIZE + 1];
>
>@@ -110,13 +112,21 @@ perf_atq_worker_burst(void *arg, const int
>enable_fwd_latency)
> 						nb_stages);
> 			}
> 		}
>+		if (flags == TEST_PERF_EVENT_TX_DIRECT) {
>+			nb_tx =
>rte_event_eth_tx_adapter_enqueue(dev, port,
>+						ev, nb_rx, 0);
>+			while (nb_tx < nb_rx && !t->done)
>+				nb_tx +=
>rte_event_eth_tx_adapter_enqueue(dev,
>+						port, ev + nb_tx,
>+						nb_rx - nb_tx, 0);
>+		} else {
>+			uint16_t enq;
>
>-		uint16_t enq;
>-
>-		enq = rte_event_enqueue_burst(dev, port, ev, nb_rx);
>-		while (enq < nb_rx) {
>-			enq += rte_event_enqueue_burst(dev, port,
>+			enq = rte_event_enqueue_burst(dev, port, ev,
>nb_rx);
>+			while (enq < nb_rx) {
>+				enq += rte_event_enqueue_burst(dev,
>port,
> 							ev + enq, nb_rx
>- enq);
>+			}
> 		}
> 	}
> 	return 0;
>@@ -127,20 +137,29 @@ worker_wrapper(void *arg)
> {
> 	struct worker_data *w  = arg;
> 	struct evt_options *opt = w->t->opt;
>-
>+	const bool internal_port = w->t->internal_port;
> 	const bool burst = evt_has_burst_mode(w->dev_id);
> 	const int fwd_latency = opt->fwd_latency;
>+	uint32_t flags;
>
> 	/* allow compiler to optimize */
> 	if (!burst && !fwd_latency)
> 		return perf_atq_worker(arg, 0);
> 	else if (!burst && fwd_latency)
> 		return perf_atq_worker(arg, 1);
>-	else if (burst && !fwd_latency)
>-		return perf_atq_worker_burst(arg, 0);
>-	else if (burst && fwd_latency)
>-		return perf_atq_worker_burst(arg, 1);
>-
>+	else if (burst && !fwd_latency && internal_port) {
>+		flags = TEST_PERF_EVENT_TX_DIRECT;
>+		return perf_atq_worker_burst(arg, 0, flags);
>+	} else if (burst && !fwd_latency && !internal_port) {
>+		flags = TEST_PERF_EVENT_TX_ENQ;
>+		return perf_atq_worker_burst(arg, 1, flags);
>+	} else if (burst && fwd_latency && internal_port) {
>+		flags = TEST_PERF_EVENT_TX_DIRECT;
>+		return perf_atq_worker_burst(arg, 0, flags);
>+	} else if (burst && fwd_latency && !internal_port) {
>+		flags = TEST_PERF_EVENT_TX_ENQ;
>+		return perf_atq_worker_burst(arg, 1, flags);
>+	}
> 	rte_panic("invalid worker\n");
> }
>
>diff --git a/app/test-eventdev/test_perf_common.h b/app/test-
>eventdev/test_perf_common.h
>index 716199d8c9..c86be385ad 100644
>--- a/app/test-eventdev/test_perf_common.h
>+++ b/app/test-eventdev/test_perf_common.h
>@@ -13,6 +13,7 @@
> #include <rte_ethdev.h>
> #include <rte_eventdev.h>
> #include <rte_event_eth_rx_adapter.h>
>+#include <rte_event_eth_tx_adapter.h>
> #include <rte_event_timer_adapter.h>
> #include <rte_lcore.h>
> #include <rte_malloc.h>
>@@ -23,6 +24,9 @@
> #include "evt_options.h"
> #include "evt_test.h"
>
>+#define TEST_PERF_EVENT_TX_ENQ		0x1
>+#define TEST_PERF_EVENT_TX_DIRECT	0X2
>+
> struct test_perf;
>
> struct worker_data {
>--
>2.17.1


  reply	other threads:[~2020-07-02  3:25 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-01  6:06 [dpdk-stable] [PATCH 1/6] app/test-eventdev: Enhancing perf-queue " Apeksha Gupta
2020-07-01  6:06 ` [dpdk-stable] [PATCH 2/6] app/test-eventdev: Removed unwanted checks Apeksha Gupta
2020-07-01  6:06 ` [dpdk-stable] [PATCH 3/6] event/dpaa2: Add all type queue capability flag Apeksha Gupta
2020-07-01  6:06 ` [dpdk-stable] [PATCH 4/6] app/test-eventdev: Fix pipeline atq Apeksha Gupta
2020-07-10 13:08   ` [dpdk-stable] [PATCH v2] " Apeksha Gupta
2020-07-13 11:44     ` [dpdk-stable] [PATCH v3 1/2] " Apeksha Gupta
2020-07-13 11:44       ` [dpdk-stable] [PATCH v3 2/2] event/dpaa2: Add all type queue capability flag Apeksha Gupta
2020-07-21 17:51         ` [dpdk-stable] [dpdk-dev] " Jerin Jacob
2020-07-23 13:36         ` [dpdk-stable] " Nipun Gupta
2020-07-24  5:24           ` [dpdk-stable] [dpdk-dev] " Jerin Jacob
2020-07-23 17:04         ` [dpdk-stable] [PATCH v4 2/2] event/dpaa2: add " Apeksha Gupta
2020-07-22  1:13       ` [dpdk-stable] [dpdk-dev] [PATCH v3 1/2] app/test-eventdev: Fix pipeline atq Pavan Nikhilesh Bhagavatula
2020-07-22  7:48         ` Thomas Monjalon
2020-07-23 17:02       ` [dpdk-stable] [PATCH v4 1/2] app/test-eventdev: fix capability check in pipeline ATQ test Apeksha Gupta
2020-07-01  6:06 ` [dpdk-stable] [PATCH 5/6] app/test-eventdev: Enhancing perf-atq packet flow Apeksha Gupta
2020-07-02  3:25   ` Pavan Nikhilesh Bhagavatula [this message]
2020-07-02 14:46     ` [dpdk-stable] [EXT] RE: [dpdk-dev] " Apeksha Gupta
2020-07-01  6:06 ` [dpdk-stable] [PATCH 6/6] app/test-eventdev: fix eventdev queues Apeksha Gupta
2020-07-02  3:27   ` [dpdk-stable] [dpdk-dev] " Pavan Nikhilesh Bhagavatula
2020-07-09 13:05     ` [dpdk-stable] [EXT] " Apeksha Gupta
2020-07-02  3:24 ` [dpdk-stable] [dpdk-dev] [PATCH 1/6] app/test-eventdev: Enhancing perf-queue packet flow Pavan Nikhilesh Bhagavatula
2020-07-02 14:46   ` [dpdk-stable] [EXT] " Apeksha Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN6PR18MB114085EF59420690856F6279DE6D0@BN6PR18MB1140.namprd18.prod.outlook.com \
    --to=pbhagavatula@marvell.com \
    --cc=akhil.goyal@nxp.com \
    --cc=apeksha.gupta@nxp.com \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=nipun.gupta@nxp.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git