patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Xueming(Steven) Li" <xuemingl@nvidia.com>
To: "Hussin, Mohamad Noor Alim" <mohamad.noor.alim.hussin@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH 20.11] ifpga/meson: Fix finding librt using find_library()
Date: Mon, 28 Jun 2021 07:52:58 +0000
Message-ID: <BN9PR12MB5366F7A62F0DE1EDC580709AA1039@BN9PR12MB5366.namprd12.prod.outlook.com> (raw)
In-Reply-To: <DM5PR11MB2012CBAF856C6B25311AF63C8D039@DM5PR11MB2012.namprd11.prod.outlook.com>

When patches accepted by main branch, normally LTS maintainer will scan all fixes for next LTS release.
You only need to send it manually if the patch expected to be included into LTS earlier, but first you need to get the patch merged into main branch.

Besides checkpatch, also need check-git-log,  please check official guide here:
	https://doc.dpdk.org/guides/contributing/patches.html

Thanks,
Xueming

> -----Original Message-----
> From: Hussin, Mohamad Noor Alim <mohamad.noor.alim.hussin@intel.com>
> Sent: Monday, June 28, 2021 3:43 PM
> To: Xueming(Steven) Li <xuemingl@nvidia.com>; stable@dpdk.org
> Subject: RE: [dpdk-stable] [PATCH 20.11] ifpga/meson: Fix finding librt using find_library()
> 
> Hi Xueming,
> 
> This patch haven't merged in main branch. I will resend this patch to main branch.
> I haven't run devtools/checkpatches.sh. Do I need to run this script before send the patch?
> 
> Regards,
> Alim Hussin
> 
> -----Original Message-----
> From: Xueming(Steven) Li <xuemingl@nvidia.com>
> Sent: Friday, June 25, 2021 8:34 PM
> To: Hussin, Mohamad Noor Alim <mohamad.noor.alim.hussin@intel.com>; stable@dpdk.org
> Subject: RE: [dpdk-stable] [PATCH 20.11] ifpga/meson: Fix finding librt using find_library()
> 
> Hi Mohamad,
> 
> Is the patch merged into dpdk main branch? Need a line [ upstream commit <ID> ] in commit message.
> 
> BTW, have you run devtools/checkpatches.sh? Seems missing "Fixes: " line.
> 
> Best Regards,
> Xueming
> 
> > -----Original Message-----
> > From: stable <stable-bounces@dpdk.org> On Behalf Of mohamad.noor.alim.hussin@intel.com
> > Sent: Thursday, June 24, 2021 2:28 PM
> > To: stable@dpdk.org
> > Cc: Mohamad Noor Alim Hussin <mohamad.noor.alim.hussin@intel.com>
> > Subject: [dpdk-stable] [PATCH 20.11] ifpga/meson: Fix finding librt using find_library()
> >
> > From: Mohamad Noor Alim Hussin <mohamad.noor.alim.hussin@intel.com>
> >
> > Finding with "librt" keyword would give the output with full path of librt such as /usr/lib/librt.so instead of -lrt.
> >
> > Assume find_library() will prepend "lib", thus remove "lib" from "librt" keyword. The output will shows as -lrt.
> >
> > Signed-off-by: Mohamad Noor Alim Hussin <mohamad.noor.alim.hussin@intel.com>
> > ---
> >  drivers/raw/ifpga/base/meson.build | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/raw/ifpga/base/meson.build b/drivers/raw/ifpga/base/meson.build
> > index da2d6e33c..949f7f127 100644
> > --- a/drivers/raw/ifpga/base/meson.build
> > +++ b/drivers/raw/ifpga/base/meson.build
> > @@ -25,7 +25,7 @@ sources = [
> >
> >  rtdep = dependency('librt', required: false)  if not rtdep.found()
> > -	rtdep = cc.find_library('librt', required: false)
> > +	rtdep = cc.find_library('rt', required: false)
> >  endif
> >  if not rtdep.found()
> >  	build = false
> > --
> > 2.32.0


      reply	other threads:[~2021-06-28  7:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-24  6:27 mohamad.noor.alim.hussin
2021-06-25 12:34 ` Xueming(Steven) Li
2021-06-28  7:42   ` Hussin, Mohamad Noor Alim
2021-06-28  7:52     ` Xueming(Steven) Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN9PR12MB5366F7A62F0DE1EDC580709AA1039@BN9PR12MB5366.namprd12.prod.outlook.com \
    --to=xuemingl@nvidia.com \
    --cc=mohamad.noor.alim.hussin@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git