[dpdk-stable] [PATCH 20.11] ifpga/meson: Fix finding librt using find_library()

[dpdk-stable] [PATCH 20.11] ifpga/meson: Fix finding librt using find_library()

[mohamad.noor.alim.hussin]

From: Mohamad Noor Alim Hussin <mohamad.noor.alim.hussin@intel.com>

Finding with "librt" keyword would give the output
with full path of librt such as /usr/lib/librt.so
instead of -lrt.

Assume find_library() will prepend "lib", thus remove
"lib" from "librt" keyword. The output will shows as
-lrt.

Signed-off-by: Mohamad Noor Alim Hussin <mohamad.noor.alim.hussin@intel.com>
---
 drivers/raw/ifpga/base/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/raw/ifpga/base/meson.build b/drivers/raw/ifpga/base/meson.build
index da2d6e33c..949f7f127 100644
--- a/drivers/raw/ifpga/base/meson.build
+++ b/drivers/raw/ifpga/base/meson.build
@@ -25,7 +25,7 @@ sources = [
 
 rtdep = dependency('librt', required: false)
 if not rtdep.found()
-	rtdep = cc.find_library('librt', required: false)
+	rtdep = cc.find_library('rt', required: false)
 endif
 if not rtdep.found()
 	build = false
-- 
2.32.0

Re: [dpdk-stable] [PATCH 20.11] ifpga/meson: Fix finding librt using find_library()

[Xueming(Steven) Li]

Hi Mohamad,

Is the patch merged into dpdk main branch? Need a line [ upstream commit <ID> ] in commit message.

BTW, have you run devtools/checkpatches.sh? Seems missing "Fixes: " line.

Best Regards,
Xueming

> -----Original Message-----
> From: stable <stable-bounces@dpdk.org> On Behalf Of mohamad.noor.alim.hussin@intel.com
> Sent: Thursday, June 24, 2021 2:28 PM
> To: stable@dpdk.org
> Cc: Mohamad Noor Alim Hussin <mohamad.noor.alim.hussin@intel.com>
> Subject: [dpdk-stable] [PATCH 20.11] ifpga/meson: Fix finding librt using find_library()
> 
> From: Mohamad Noor Alim Hussin <mohamad.noor.alim.hussin@intel.com>
> 
> Finding with "librt" keyword would give the output with full path of librt such as /usr/lib/librt.so instead of -lrt.
> 
> Assume find_library() will prepend "lib", thus remove "lib" from "librt" keyword. The output will shows as -lrt.
> 
> Signed-off-by: Mohamad Noor Alim Hussin <mohamad.noor.alim.hussin@intel.com>
> ---
>  drivers/raw/ifpga/base/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/raw/ifpga/base/meson.build b/drivers/raw/ifpga/base/meson.build
> index da2d6e33c..949f7f127 100644
> --- a/drivers/raw/ifpga/base/meson.build
> +++ b/drivers/raw/ifpga/base/meson.build
> @@ -25,7 +25,7 @@ sources = [
> 
>  rtdep = dependency('librt', required: false)  if not rtdep.found()
> -	rtdep = cc.find_library('librt', required: false)
> +	rtdep = cc.find_library('rt', required: false)
>  endif
>  if not rtdep.found()
>  	build = false
> --
> 2.32.0

Re: [dpdk-stable] [PATCH 20.11] ifpga/meson: Fix finding librt using find_library()

[Hussin, Mohamad Noor Alim]

Hi Xueming,

This patch haven't merged in main branch. I will resend this patch to main branch.
I haven't run devtools/checkpatches.sh. Do I need to run this script before send the patch?

Regards,
Alim Hussin

-----Original Message-----
From: Xueming(Steven) Li <xuemingl@nvidia.com> 
Sent: Friday, June 25, 2021 8:34 PM
To: Hussin, Mohamad Noor Alim <mohamad.noor.alim.hussin@intel.com>; stable@dpdk.org
Subject: RE: [dpdk-stable] [PATCH 20.11] ifpga/meson: Fix finding librt using find_library()

Hi Mohamad,

Is the patch merged into dpdk main branch? Need a line [ upstream commit <ID> ] in commit message.

BTW, have you run devtools/checkpatches.sh? Seems missing "Fixes: " line.

Best Regards,
Xueming

> -----Original Message-----
> From: stable <stable-bounces@dpdk.org> On Behalf Of mohamad.noor.alim.hussin@intel.com
> Sent: Thursday, June 24, 2021 2:28 PM
> To: stable@dpdk.org
> Cc: Mohamad Noor Alim Hussin <mohamad.noor.alim.hussin@intel.com>
> Subject: [dpdk-stable] [PATCH 20.11] ifpga/meson: Fix finding librt using find_library()
> 
> From: Mohamad Noor Alim Hussin <mohamad.noor.alim.hussin@intel.com>
> 
> Finding with "librt" keyword would give the output with full path of librt such as /usr/lib/librt.so instead of -lrt.
> 
> Assume find_library() will prepend "lib", thus remove "lib" from "librt" keyword. The output will shows as -lrt.
> 
> Signed-off-by: Mohamad Noor Alim Hussin <mohamad.noor.alim.hussin@intel.com>
> ---
>  drivers/raw/ifpga/base/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/raw/ifpga/base/meson.build b/drivers/raw/ifpga/base/meson.build
> index da2d6e33c..949f7f127 100644
> --- a/drivers/raw/ifpga/base/meson.build
> +++ b/drivers/raw/ifpga/base/meson.build
> @@ -25,7 +25,7 @@ sources = [
> 
>  rtdep = dependency('librt', required: false)  if not rtdep.found()
> -	rtdep = cc.find_library('librt', required: false)
> +	rtdep = cc.find_library('rt', required: false)
>  endif
>  if not rtdep.found()
>  	build = false
> --
> 2.32.0

Re: [dpdk-stable] [PATCH 20.11] ifpga/meson: Fix finding librt using find_library()

[Xueming(Steven) Li]

When patches accepted by main branch, normally LTS maintainer will scan all fixes for next LTS release.
You only need to send it manually if the patch expected to be included into LTS earlier, but first you need to get the patch merged into main branch.

Besides checkpatch, also need check-git-log,  please check official guide here:
	https://doc.dpdk.org/guides/contributing/patches.html

Thanks,
Xueming

> -----Original Message-----
> From: Hussin, Mohamad Noor Alim <mohamad.noor.alim.hussin@intel.com>
> Sent: Monday, June 28, 2021 3:43 PM
> To: Xueming(Steven) Li <xuemingl@nvidia.com>; stable@dpdk.org
> Subject: RE: [dpdk-stable] [PATCH 20.11] ifpga/meson: Fix finding librt using find_library()
> 
> Hi Xueming,
> 
> This patch haven't merged in main branch. I will resend this patch to main branch.
> I haven't run devtools/checkpatches.sh. Do I need to run this script before send the patch?
> 
> Regards,
> Alim Hussin
> 
> -----Original Message-----
> From: Xueming(Steven) Li <xuemingl@nvidia.com>
> Sent: Friday, June 25, 2021 8:34 PM
> To: Hussin, Mohamad Noor Alim <mohamad.noor.alim.hussin@intel.com>; stable@dpdk.org
> Subject: RE: [dpdk-stable] [PATCH 20.11] ifpga/meson: Fix finding librt using find_library()
> 
> Hi Mohamad,
> 
> Is the patch merged into dpdk main branch? Need a line [ upstream commit <ID> ] in commit message.
> 
> BTW, have you run devtools/checkpatches.sh? Seems missing "Fixes: " line.
> 
> Best Regards,
> Xueming
> 
> > -----Original Message-----
> > From: stable <stable-bounces@dpdk.org> On Behalf Of mohamad.noor.alim.hussin@intel.com
> > Sent: Thursday, June 24, 2021 2:28 PM
> > To: stable@dpdk.org
> > Cc: Mohamad Noor Alim Hussin <mohamad.noor.alim.hussin@intel.com>
> > Subject: [dpdk-stable] [PATCH 20.11] ifpga/meson: Fix finding librt using find_library()
> >
> > From: Mohamad Noor Alim Hussin <mohamad.noor.alim.hussin@intel.com>
> >
> > Finding with "librt" keyword would give the output with full path of librt such as /usr/lib/librt.so instead of -lrt.
> >
> > Assume find_library() will prepend "lib", thus remove "lib" from "librt" keyword. The output will shows as -lrt.
> >
> > Signed-off-by: Mohamad Noor Alim Hussin <mohamad.noor.alim.hussin@intel.com>
> > ---
> >  drivers/raw/ifpga/base/meson.build | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/raw/ifpga/base/meson.build b/drivers/raw/ifpga/base/meson.build
> > index da2d6e33c..949f7f127 100644
> > --- a/drivers/raw/ifpga/base/meson.build
> > +++ b/drivers/raw/ifpga/base/meson.build
> > @@ -25,7 +25,7 @@ sources = [
> >
> >  rtdep = dependency('librt', required: false)  if not rtdep.found()
> > -	rtdep = cc.find_library('librt', required: false)
> > +	rtdep = cc.find_library('rt', required: false)
> >  endif
> >  if not rtdep.found()
> >  	build = false
> > --
> > 2.32.0