patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] "net/hns3: fix VF handling LSC event in secondary process" incompatible with 19.11.x
@ 2021-06-01  9:03 Christian Ehrhardt
  2021-06-01  9:05 ` Christian Ehrhardt
  0 siblings, 1 reply; 2+ messages in thread
From: Christian Ehrhardt @ 2021-06-01  9:03 UTC (permalink / raw)
  To: Chengwen Feng; +Cc: dpdk stable

Hi,
this mostly is an FYI to document why a change was not applied to the
stable series. This was targeted for stable releases:

commit dbbbad23e380773b37872df2195c4529fd93ca6f
Author: Chengwen Feng <fengchengwen@huawei.com>
Date:   Tue Apr 13 19:50:02 2021 +0800

    net/hns3: fix VF handling LSC event in secondary process

But it triggers

../drivers/net/hns3/hns3_mbx.c: In function ‘hns3_handle_mbx_msg_out_intr’:
../drivers/net/hns3/hns3_mbx.c:355:4: warning: implicit declaration of
function ‘hns3_handle_mbx_response’; did you mean
‘hns3_handle_msix_error’? [-Wimplicit-function-declaration]
  355 |    hns3_handle_mbx_response(hw, req);
      |    ^~~~~~~~~~~~~~~~~~~~~~~~
      |    hns3_handle_msix_error


This is due to missing:

commit c8dec72de00039f367c1a8cd1f40378d04cf3e8f
Author: Chengwen Feng <fengchengwen@huawei.com>
Date:   Tue Apr 13 19:50:01 2021 +0800

    net/hns3: fix possible mismatched response of mailbox

And this one I already called out as a "help for backport" 12 days ago.

The same is true for:

../drivers/net/hns3/hns3_mbx.c:385:10: warning: implicit declaration
of function ‘rte_thread_is_intr’; did you mean ‘rte_thread_setname’?
[-Wimplicit-function-declaration]
  385 |         !rte_thread_is_intr()) && hns->is_vf;
      |          ^~~~~~~~~~~~~~~~~~
      |          rte_thread_setname

Which needs
commit 5c016fc0205a67123481dbe8f9784635beac8a09
Author: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Date:   Sat Sep 26 02:32:42 2020 +0300

    eal/windows: add interrupt thread skeleton

FYI for now I'll also drop dbbbad23e380773b37872df2195c4529fd93ca6f from 19.11.x

-- 
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-stable] "net/hns3: fix VF handling LSC event in secondary process" incompatible with 19.11.x
  2021-06-01  9:03 [dpdk-stable] "net/hns3: fix VF handling LSC event in secondary process" incompatible with 19.11.x Christian Ehrhardt
@ 2021-06-01  9:05 ` Christian Ehrhardt
  0 siblings, 0 replies; 2+ messages in thread
From: Christian Ehrhardt @ 2021-06-01  9:05 UTC (permalink / raw)
  To: Chengwen Feng; +Cc: dpdk stable

FYI this also implies a remove of the depending

commit 4a2f6ab6fbc4be504e155a48665cc0d854ef36b6
Author: Chengwen Feng <fengchengwen@huawei.com>
Date:   Thu Apr 22 09:55:50 2021 +0800

    net/hns3: fix processing link status message on PF

On Tue, Jun 1, 2021 at 11:03 AM Christian Ehrhardt
<christian.ehrhardt@canonical.com> wrote:
>
> Hi,
> this mostly is an FYI to document why a change was not applied to the
> stable series. This was targeted for stable releases:
>
> commit dbbbad23e380773b37872df2195c4529fd93ca6f
> Author: Chengwen Feng <fengchengwen@huawei.com>
> Date:   Tue Apr 13 19:50:02 2021 +0800
>
>     net/hns3: fix VF handling LSC event in secondary process
>
> But it triggers
>
> ../drivers/net/hns3/hns3_mbx.c: In function ‘hns3_handle_mbx_msg_out_intr’:
> ../drivers/net/hns3/hns3_mbx.c:355:4: warning: implicit declaration of
> function ‘hns3_handle_mbx_response’; did you mean
> ‘hns3_handle_msix_error’? [-Wimplicit-function-declaration]
>   355 |    hns3_handle_mbx_response(hw, req);
>       |    ^~~~~~~~~~~~~~~~~~~~~~~~
>       |    hns3_handle_msix_error
>
>
> This is due to missing:
>
> commit c8dec72de00039f367c1a8cd1f40378d04cf3e8f
> Author: Chengwen Feng <fengchengwen@huawei.com>
> Date:   Tue Apr 13 19:50:01 2021 +0800
>
>     net/hns3: fix possible mismatched response of mailbox
>
> And this one I already called out as a "help for backport" 12 days ago.
>
> The same is true for:
>
> ../drivers/net/hns3/hns3_mbx.c:385:10: warning: implicit declaration
> of function ‘rte_thread_is_intr’; did you mean ‘rte_thread_setname’?
> [-Wimplicit-function-declaration]
>   385 |         !rte_thread_is_intr()) && hns->is_vf;
>       |          ^~~~~~~~~~~~~~~~~~
>       |          rte_thread_setname
>
> Which needs
> commit 5c016fc0205a67123481dbe8f9784635beac8a09
> Author: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> Date:   Sat Sep 26 02:32:42 2020 +0300
>
>     eal/windows: add interrupt thread skeleton
>
> FYI for now I'll also drop dbbbad23e380773b37872df2195c4529fd93ca6f from 19.11.x
>
> --
> Christian Ehrhardt
> Staff Engineer, Ubuntu Server
> Canonical Ltd



-- 
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-06-01  9:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-01  9:03 [dpdk-stable] "net/hns3: fix VF handling LSC event in secondary process" incompatible with 19.11.x Christian Ehrhardt
2021-06-01  9:05 ` Christian Ehrhardt

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git