From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
To: Michael Baum <michaelba@nvidia.com>
Cc: stable@dpdk.org, Matan Azrad <matan@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Subject: Re: [PATCH 19.11] net/mlx5: fix LRO validation in Rx setup
Date: Mon, 11 Jul 2022 08:16:12 +0200 [thread overview]
Message-ID: <CAATJJ0L8pndystzy=V2ERtJFt5JmqpT5qGX_EZ4VnmK22ZHsdQ@mail.gmail.com> (raw)
In-Reply-To: <20220710070342.563953-1-michaelba@nvidia.com>
On Sun, Jul 10, 2022 at 9:04 AM Michael Baum <michaelba@nvidia.com> wrote:
>
> [ upstream commit a213b8682117711c8e92475c5bbb321a3d8428dd ]
Thanks, applied
> The mlx5_rx_queue_setup() get LRO offload from user.
>
> When LRO is configured, the LRO flag in rxq_data is set to 1.
>
> This patch adds validation to make sure the LRO is supported.
>
> Fixes: 17ed314 ("net/mlx5: allow LRO per Rx queue")
>
> Signed-off-by: Michael Baum <michaelba@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
> ---
> drivers/net/mlx5/mlx5_rxq.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
> index bb4f11bccb..7a0a7e6ac9 100644
> --- a/drivers/net/mlx5/mlx5_rxq.c
> +++ b/drivers/net/mlx5/mlx5_rxq.c
> @@ -502,8 +502,18 @@ mlx5_rx_queue_setup(struct rte_eth_dev *dev, uint16_t idx, uint16_t desc,
> struct mlx5_rxq_data *rxq = (*priv->rxqs)[idx];
> struct mlx5_rxq_ctrl *rxq_ctrl =
> container_of(rxq, struct mlx5_rxq_ctrl, rxq);
> + uint64_t offloads = conf->offloads |
> + dev->data->dev_conf.rxmode.offloads;
> int res;
>
> + if ((offloads & DEV_RX_OFFLOAD_TCP_LRO) &&
> + !priv->config.lro.supported) {
> + DRV_LOG(ERR,
> + "Port %u queue %u LRO is configured but not supported.",
> + dev->data->port_id, idx);
> + rte_errno = EINVAL;
> + return -rte_errno;
> + }
> res = mlx5_rx_queue_pre_setup(dev, idx, &desc);
> if (res)
> return res;
> --
> 2.25.1
>
--
Christian Ehrhardt
Senior Staff Engineer, Ubuntu Server
Canonical Ltd
prev parent reply other threads:[~2022-07-11 6:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-10 7:03 Michael Baum
2022-07-11 6:16 ` Christian Ehrhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAATJJ0L8pndystzy=V2ERtJFt5JmqpT5qGX_EZ4VnmK22ZHsdQ@mail.gmail.com' \
--to=christian.ehrhardt@canonical.com \
--cc=matan@nvidia.com \
--cc=michaelba@nvidia.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).