From: Elad Nachman <eladv6@gmail.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Igor Ryzhov <iryzhov@nfware.com>,
stable@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>,
Dan Gora <dg@adax.com>, dev <dev@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v5 3/3] kni: fix kernel deadlock when using mlx devices
Date: Mon, 12 Apr 2021 17:35:32 +0300 [thread overview]
Message-ID: <CACXF7qnUuiqAq7B2S4s1kOnEXwG2cGmV0wdNKYgxS+YXuqXj2g@mail.gmail.com> (raw)
In-Reply-To: <b421b26d-0949-3277-2c00-5a7f287c2dd2@intel.com>
Hi,
The new patch is fine by me.
Tested several dozens restarts of our proprietary application without
apparent problem.
FYI,
Elad.
בתאריך יום ו׳, 9 באפר׳ 2021, 17:56, מאת Ferruh Yigit <
ferruh.yigit@intel.com>:
> On 3/29/2021 3:36 PM, Ferruh Yigit wrote:
> > KNI runs userspace callback with rtnl lock held, this is not working
> > fine with some devices that needs to interact with kernel interface in
> > the callback, like Mellanox devices.
> >
> > The solution is releasing the rtnl lock before calling the userspace
> > callback. But it requires two consideration:
> >
> > 1. The rtnl lock needs to released before 'kni->sync_lock', otherwise it
> > causes deadlock with multiple KNI devices, please check below the A.
> > for the details of the deadlock condition.
> >
> > 2. When rtnl lock is released for interface down event, it cause a
> > regression and deadlock, so can't release the rtnl lock for interface
> > down event, please check below B. for the details.
> >
> > As a solution, interface down event is handled asynchronously and for
> > all other events rtnl lock is released before processing the callback.
> >
> > A. KNI sync lock is being locked while rtnl is held.
> > If two threads are calling kni_net_process_request() ,
> > then the first one will take the sync lock, release rtnl lock then sleep.
> > The second thread will try to lock sync lock while holding rtnl.
> > The first thread will wake, and try to lock rtnl, resulting in a
> > deadlock. The remedy is to release rtnl before locking the KNI sync
> > lock.
> > Since in between nothing is accessing Linux network-wise, no rtnl
> > locking is needed.
> >
> > B. There is a race condition in __dev_close_many() processing the
> > close_list while the application terminates.
> > It looks like if two KNI interfaces are terminating,
> > and one releases the rtnl lock, the other takes it,
> > updating the close_list in an unstable state,
> > causing the close_list to become a circular linked list,
> > hence list_for_each_entry() will endlessly loop inside
> > __dev_close_many() .
> >
> > To summarize:
> > request != interface down : unlock rtnl, send request to user-space,
> > wait for response, send the response error code to caller in user-space.
> >
> > request == interface down: send request to user-space, return immediately
> > with error code of 0 (success) to user-space.
> >
> > Fixes: 3fc5ca2f6352 ("kni: initial import")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Elad Nachman <eladv6@gmail.com>
> > ---
> > Cc: Stephen Hemminger <stephen@networkplumber.org>
> > Cc: Igor Ryzhov <iryzhov@nfware.com>
> > Cc: Dan Gora <dg@adax.com>
> >
>
> Hi Elad, Igor,
>
> Can you please review/test this set when you have time?
>
> Thanks,
> ferruh
>
>
next prev parent reply other threads:[~2021-04-12 14:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201126144613.4986-1-eladv6@gmail.com>
[not found] ` <20210329143655.521750-1-ferruh.yigit@intel.com>
2021-03-29 14:36 ` Ferruh Yigit
2021-04-09 14:56 ` Ferruh Yigit
2021-04-12 14:35 ` Elad Nachman [this message]
2021-04-20 23:07 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2021-04-23 8:41 ` Igor Ryzhov
2021-04-23 8:59 ` Ferruh Yigit
2021-04-23 12:43 ` Igor Ryzhov
2021-04-23 12:58 ` Igor Ryzhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACXF7qnUuiqAq7B2S4s1kOnEXwG2cGmV0wdNKYgxS+YXuqXj2g@mail.gmail.com \
--to=eladv6@gmail.com \
--cc=dev@dpdk.org \
--cc=dg@adax.com \
--cc=ferruh.yigit@intel.com \
--cc=iryzhov@nfware.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).