patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Igor Ryzhov <iryzhov@nfware.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
	Stephen Hemminger <stephen@networkplumber.org>,
	 Elad Nachman <eladv6@gmail.com>, dev <dev@dpdk.org>,
	dpdk stable <stable@dpdk.org>, Dan Gora <dg@adax.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v5 3/3] kni: fix kernel deadlock when using mlx devices
Date: Fri, 23 Apr 2021 15:58:14 +0300
Message-ID: <CAF+s_Fy_Mm-AzPXbav1TxJ77=C5zj5HGmpWhAZ879Ayszr=a-g@mail.gmail.com> (raw)
In-Reply-To: <CAF+s_FxyBHqm-ms9D7JyOVJ8eKcspoYP+SYyG3bQm27P5sRnyA@mail.gmail.com>

Sorry I remembered the problem with the deadlock.

We can't just make the shutdown command synchronous, because
we can't release the rtnl_lock anyway. So regardless of the process
mode (sync/async), we have to preserve the lock when processing
the shutdown. It looks like two different settings...

On Fri, Apr 23, 2021 at 3:43 PM Igor Ryzhov <iryzhov@nfware.com> wrote:

> Hi Ferruh,
>
> Thanks. I think it would be great to make this configurable, and maybe even
> make shutdown synchronous by default to preserve the old behavior.
>
> I would be grateful if you could spend time on the work and I am ready to
> review it.
>
> Igor
>
> On Fri, Apr 23, 2021 at 11:59 AM Ferruh Yigit <ferruh.yigit@intel.com>
> wrote:
>
>> On 4/23/2021 9:41 AM, Igor Ryzhov wrote:
>> > This patch changes the behavior for KNI interface shutdown.
>> > Previously we would receive a real response from the driver, now we
>> > always receive success.
>> > I think this should be reflected in the docs/release notes.
>> >
>>
>> Hi Igor,
>>
>> Make sense, I can add it.
>>
>> Meanwhile do you think has a benefit to make shutdown behavior
>> configurable?
>> Async/Sync shutdown based on module param?
>>
>> > Igor
>> >
>> > On Wed, Apr 21, 2021 at 2:07 AM Thomas Monjalon <thomas@monjalon.net
>> > <mailto:thomas@monjalon.net>> wrote:
>> >
>> >     12/04/2021 16:35, Elad Nachman:
>> >      > Hi,
>> >      >
>> >      > The new patch is fine by me.
>> >      >
>> >      > Tested several dozens restarts of our proprietary application
>> without
>> >      > apparent problem.
>> >
>> >     Series applied, thanks.
>> >
>> >
>>
>>

      reply	other threads:[~2021-04-23 12:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20201126144613.4986-1-eladv6@gmail.com>
     [not found] ` <20210329143655.521750-1-ferruh.yigit@intel.com>
2021-03-29 14:36   ` [dpdk-stable] " Ferruh Yigit
2021-04-09 14:56     ` Ferruh Yigit
2021-04-12 14:35       ` Elad Nachman
2021-04-20 23:07         ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2021-04-23  8:41           ` Igor Ryzhov
2021-04-23  8:59             ` Ferruh Yigit
2021-04-23 12:43               ` Igor Ryzhov
2021-04-23 12:58                 ` Igor Ryzhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAF+s_Fy_Mm-AzPXbav1TxJ77=C5zj5HGmpWhAZ879Ayszr=a-g@mail.gmail.com' \
    --to=iryzhov@nfware.com \
    --cc=dev@dpdk.org \
    --cc=dg@adax.com \
    --cc=eladv6@gmail.com \
    --cc=ferruh.yigit@intel.com \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git