From: Ajit Khaparde <ajit.khaparde@broadcom.com> To: Chenbo Xia <chenbo.xia@intel.com> Cc: dpdk-dev <dev@dpdk.org>, Somnath Kotur <somnath.kotur@broadcom.com>, Qiming Yang <qiming.yang@intel.com>, Qi Zhang <qi.z.zhang@intel.com>, Rasesh Mody <rmody@marvell.com>, Shahed Shaikh <shshaikh@marvell.com>, Shahaji Bhosle <sbhosle@broadcom.com>, Kishore Padmanabha <kishore.padmanabha@broadcom.com>, Michael Baucom <michael.baucom@broadcom.com>, Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>, Xiaoyun Li <xiaoyun.li@intel.com>, Ferruh Yigit <ferruh.yigit@intel.com>, Jingjing Wu <jingjing.wu@intel.com>, irusskikh@marvell.com, Wenzhuo Lu <wenzhuo.lu@intel.com>, Beilei Xing <beilei.xing@intel.com>, "Iremonger, Bernard" <bernard.iremonger@intel.com>, nikhil.rao@intel.com, "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, Jerin Jacob <jerin.jacob@caviumnetworks.com>, Marko Kovacevic <marko.kovacevic@intel.com>, Ori Kam <orika@nvidia.com>, Bruce Richardson <bruce.richardson@intel.com>, radu.nicolau@intel.com, Akhil Goyal <akhil.goyal@nxp.com>, tomasz.kantecki@intel.com, skori@marvell.com, pbhagavatula@marvell.com, "Mcnamara, John" <john.mcnamara@intel.com>, dpdk stable <stable@dpdk.org> Subject: Re: [dpdk-stable] [PATCH v3 1/3] net: fix variable size of ethdev port id Date: Wed, 30 Sep 2020 06:40:48 -0700 Message-ID: <CACZ4nhu0Jt=SZQ=1LxXbOq+Z9MOefhBdQy+5vZH5r8KhNqkUTA@mail.gmail.com> (raw) In-Reply-To: <20200930042328.22507-1-chenbo.xia@intel.com> On Tue, Sep 29, 2020 at 9:28 PM Chenbo Xia <chenbo.xia@intel.com> wrote: > > The ethdev port id should be 16 bits now. This patch changes the > variable size of port id in some net drivers from 8 bits to 16 > bits. > > Fixes: 09b23f8b9df6 ("net/bnxt: fix port stop process and cleanup resources") > Fixes: 769de16872ab ("net/bnxt: fix port default rule create/destroy") > Fixes: 50370662b727 ("net/ice: support device and queue ops") > Fixes: a50d7cbbdad7 ("net/qede: support registers dump") > Cc: stable@dpdk.org > > Signed-off-by: Chenbo Xia <chenbo.xia@intel.com> For bnxt, Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com> > > --- > drivers/net/bnxt/tf_ulp/bnxt_ulp.c | 2 +- > drivers/net/bnxt/tf_ulp/ulp_def_rules.c | 6 +++--- > drivers/net/ice/ice_rxtx.h | 4 ++-- > drivers/net/qede/base/bcm_osal.h | 2 +- > drivers/net/qede/qede_regs.c | 2 +- > 5 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/net/bnxt/tf_ulp/bnxt_ulp.c b/drivers/net/bnxt/tf_ulp/bnxt_ulp.c > index e8927f629..3d148029e 100644 > --- a/drivers/net/bnxt/tf_ulp/bnxt_ulp.c > +++ b/drivers/net/bnxt/tf_ulp/bnxt_ulp.c > @@ -646,7 +646,7 @@ static void > bnxt_ulp_destroy_vfr_default_rules(struct bnxt *bp, bool global) > { > struct bnxt_ulp_vfr_rule_info *info; > - uint8_t port_id; > + uint16_t port_id; > struct rte_eth_dev *vfr_eth_dev; > struct bnxt_vf_representor *vfr_bp; > > diff --git a/drivers/net/bnxt/tf_ulp/ulp_def_rules.c b/drivers/net/bnxt/tf_ulp/ulp_def_rules.c > index 2d0c3bccc..fdd2692f6 100644 > --- a/drivers/net/bnxt/tf_ulp/ulp_def_rules.c > +++ b/drivers/net/bnxt/tf_ulp/ulp_def_rules.c > @@ -402,7 +402,7 @@ void > bnxt_ulp_destroy_df_rules(struct bnxt *bp, bool global) > { > struct bnxt_ulp_df_rule_info *info; > - uint8_t port_id; > + uint16_t port_id; > > if (!BNXT_TRUFLOW_EN(bp) || > BNXT_ETH_DEV_IS_REPRESENTOR(bp->eth_dev)) > @@ -466,7 +466,7 @@ int32_t > bnxt_ulp_create_df_rules(struct bnxt *bp) > { > struct bnxt_ulp_df_rule_info *info; > - uint8_t port_id; > + uint16_t port_id; > int rc; > > if (!BNXT_TRUFLOW_EN(bp) || > @@ -540,7 +540,7 @@ bnxt_ulp_create_vfr_default_rules(struct rte_eth_dev *vfr_ethdev) > struct rte_eth_dev *parent_dev = vfr->parent_dev; > struct bnxt *bp = parent_dev->data->dev_private; > uint16_t vfr_port_id = vfr_ethdev->data->port_id; > - uint8_t port_id; > + uint16_t port_id; > int rc; > > if (!bp || !BNXT_TRUFLOW_EN(bp)) > diff --git a/drivers/net/ice/ice_rxtx.h b/drivers/net/ice/ice_rxtx.h > index 9fa57b3b2..e4309b8b9 100644 > --- a/drivers/net/ice/ice_rxtx.h > +++ b/drivers/net/ice/ice_rxtx.h > @@ -68,7 +68,7 @@ struct ice_rx_queue { > uint16_t rxrearm_start; /**< the idx we start the re-arming from */ > uint64_t mbuf_initializer; /**< value to init mbufs */ > > - uint8_t port_id; /* device port ID */ > + uint16_t port_id; /* device port ID */ > uint8_t crc_len; /* 0 if CRC stripped, 4 otherwise */ > uint8_t fdir_enabled; /* 0 if FDIR disabled, 1 when enabled */ > uint16_t queue_id; /* RX queue index */ > @@ -112,7 +112,7 @@ struct ice_tx_queue { > uint8_t pthresh; /**< Prefetch threshold register. */ > uint8_t hthresh; /**< Host threshold register. */ > uint8_t wthresh; /**< Write-back threshold reg. */ > - uint8_t port_id; /* Device port identifier. */ > + uint16_t port_id; /* Device port identifier. */ > uint16_t queue_id; /* TX queue index. */ > uint32_t q_teid; /* TX schedule node id. */ > uint16_t reg_idx; > diff --git a/drivers/net/qede/base/bcm_osal.h b/drivers/net/qede/base/bcm_osal.h > index 5d4df5907..814000039 100644 > --- a/drivers/net/qede/base/bcm_osal.h > +++ b/drivers/net/qede/base/bcm_osal.h > @@ -372,7 +372,7 @@ void qede_hw_err_notify(struct ecore_hwfn *p_hwfn, > /* TODO: */ > #define OSAL_SCHEDULE_RECOVERY_HANDLER(hwfn) nothing > > -int qede_save_fw_dump(uint8_t port_id); > +int qede_save_fw_dump(uint16_t port_id); > > #define OSAL_SAVE_FW_DUMP(port_id) qede_save_fw_dump(port_id) > > diff --git a/drivers/net/qede/qede_regs.c b/drivers/net/qede/qede_regs.c > index 1f2dbc6e7..d2ea1c910 100644 > --- a/drivers/net/qede/qede_regs.c > +++ b/drivers/net/qede/qede_regs.c > @@ -242,7 +242,7 @@ qede_write_fwdump(const char *dump_file, void *dump, size_t len) > } > > int > -qede_save_fw_dump(uint8_t port_id) > +qede_save_fw_dump(uint16_t port_id) > { > struct rte_eth_dev *eth_dev = &rte_eth_devices[port_id]; > struct rte_dev_reg_info regs; > -- > 2.17.1 >
next prev parent reply other threads:[~2020-09-30 13:41 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-04 17:41 [dpdk-stable] [PATCH] net/bnxt: fix variable size of " Chenbo Xia 2020-08-04 16:22 ` [dpdk-stable] [dpdk-dev] " Stephen Hemminger 2020-08-05 20:18 ` Thomas Monjalon 2020-08-06 2:03 ` Xia, Chenbo 2020-08-06 7:57 ` Thomas Monjalon 2020-09-03 6:49 ` Xiao, QimaiX 2020-09-25 5:37 ` [dpdk-stable] [PATCH v2 1/3] net: fix variable size of ethdev " Chenbo Xia 2020-09-25 5:37 ` [dpdk-stable] [PATCH v2 2/3] app: " Chenbo Xia 2020-09-25 5:37 ` [dpdk-stable] [PATCH v2 3/3] doc: " Chenbo Xia 2020-09-29 18:51 ` [dpdk-stable] [PATCH v2 1/3] net: " Ed Czeck 2020-09-30 4:23 ` [dpdk-stable] [PATCH v3 " Chenbo Xia 2020-09-30 4:23 ` [dpdk-stable] [PATCH v3 2/3] app: " Chenbo Xia 2020-09-30 4:23 ` [dpdk-stable] [PATCH v3 3/3] doc: " Chenbo Xia 2020-09-30 13:40 ` Ajit Khaparde [this message] 2020-09-30 17:13 ` [dpdk-stable] [PATCH v3 1/3] net: " Ferruh Yigit
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CACZ4nhu0Jt=SZQ=1LxXbOq+Z9MOefhBdQy+5vZH5r8KhNqkUTA@mail.gmail.com' \ --to=ajit.khaparde@broadcom.com \ --cc=akhil.goyal@nxp.com \ --cc=beilei.xing@intel.com \ --cc=bernard.iremonger@intel.com \ --cc=bruce.richardson@intel.com \ --cc=chenbo.xia@intel.com \ --cc=dev@dpdk.org \ --cc=ferruh.yigit@intel.com \ --cc=irusskikh@marvell.com \ --cc=jerin.jacob@caviumnetworks.com \ --cc=jingjing.wu@intel.com \ --cc=john.mcnamara@intel.com \ --cc=kishore.padmanabha@broadcom.com \ --cc=konstantin.ananyev@intel.com \ --cc=marko.kovacevic@intel.com \ --cc=michael.baucom@broadcom.com \ --cc=nikhil.rao@intel.com \ --cc=orika@nvidia.com \ --cc=pbhagavatula@marvell.com \ --cc=qi.z.zhang@intel.com \ --cc=qiming.yang@intel.com \ --cc=radu.nicolau@intel.com \ --cc=rmody@marvell.com \ --cc=sbhosle@broadcom.com \ --cc=shshaikh@marvell.com \ --cc=skori@marvell.com \ --cc=somnath.kotur@broadcom.com \ --cc=stable@dpdk.org \ --cc=tomasz.kantecki@intel.com \ --cc=venkatkumar.duvvuru@broadcom.com \ --cc=wenzhuo.lu@intel.com \ --cc=xiaoyun.li@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
patches for DPDK stable branches This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \ stable@dpdk.org public-inbox-index stable Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.stable AGPL code for this site: git clone https://public-inbox.org/public-inbox.git