patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] examples/fips_validation: fix checking return value
@ 2020-10-28 15:38 Ciara Power
  2020-10-30 13:01 ` [dpdk-stable] [dpdk-dev] " David Marchand
  0 siblings, 1 reply; 2+ messages in thread
From: Ciara Power @ 2020-10-28 15:38 UTC (permalink / raw)
  To: dev; +Cc: Ciara Power, marko.kovacevic, roy.fan.zhang, stable

The return value was not being checked when calling the
get_writeback_data function in the AES test case. On failure, this led
to a NULL dereference when using memcpy later. The return value is now
checked to avoid this NULL dereference.

Coverity issue: 363463
Fixes: cd255ccf5764 ("examples/fips_validation: support AES parsing")
Cc: marko.kovacevic@intel.com
Cc: roy.fan.zhang@intel.com
Cc: stable@dpdk.org

Signed-off-by: Ciara Power <ciara.power@intel.com>
---
 examples/fips_validation/main.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c
index 07532c9562..bc7abd2b8f 100644
--- a/examples/fips_validation/main.c
+++ b/examples/fips_validation/main.c
@@ -1520,7 +1520,9 @@ fips_mct_aes_test(void)
 				return ret;
 			}
 
-			get_writeback_data(&val);
+			ret = get_writeback_data(&val);
+			if (ret < 0)
+				return ret;
 
 			if (info.op == FIPS_TEST_DEC_AUTH_VERIF)
 				memcpy(prev_in, vec.ct.val, AES_BLOCK_SIZE);
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] examples/fips_validation: fix checking return value
  2020-10-28 15:38 [dpdk-stable] [PATCH] examples/fips_validation: fix checking return value Ciara Power
@ 2020-10-30 13:01 ` David Marchand
  0 siblings, 0 replies; 2+ messages in thread
From: David Marchand @ 2020-10-30 13:01 UTC (permalink / raw)
  To: Ciara Power; +Cc: dev, Kovacevic, Marko, Fan Zhang, dpdk stable

On Wed, Oct 28, 2020 at 4:38 PM Ciara Power <ciara.power@intel.com> wrote:
>
> The return value was not being checked when calling the
> get_writeback_data function in the AES test case. On failure, this led
> to a NULL dereference when using memcpy later. The return value is now
> checked to avoid this NULL dereference.
>
> Coverity issue: 363463
> Fixes: cd255ccf5764 ("examples/fips_validation: support AES parsing")

I'd rather flag:
Fixes: 952e10cdad5e ("examples/fips_validation: support scatter gather list")

Can you double check?


> Cc: marko.kovacevic@intel.com
> Cc: roy.fan.zhang@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Ciara Power <ciara.power@intel.com>
> ---
>  examples/fips_validation/main.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c
> index 07532c9562..bc7abd2b8f 100644
> --- a/examples/fips_validation/main.c
> +++ b/examples/fips_validation/main.c
> @@ -1520,7 +1520,9 @@ fips_mct_aes_test(void)
>                                 return ret;
>                         }
>
> -                       get_writeback_data(&val);
> +                       ret = get_writeback_data(&val);
> +                       if (ret < 0)
> +                               return ret;
>
>                         if (info.op == FIPS_TEST_DEC_AUTH_VERIF)
>                                 memcpy(prev_in, vec.ct.val, AES_BLOCK_SIZE);

And I think we have the same issue in fips_mct_sha_test().


-- 
David Marchand


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-10-30 13:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-28 15:38 [dpdk-stable] [PATCH] examples/fips_validation: fix checking return value Ciara Power
2020-10-30 13:01 ` [dpdk-stable] [dpdk-dev] " David Marchand

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git