From: David Marchand <david.marchand@redhat.com>
To: wangyunjian <wangyunjian@huawei.com>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>,
Luca Boccassi <bluca@debian.org>,
Kevin Traynor <ktraynor@redhat.com>
Cc: dev <dev@dpdk.org>, Hemant Agrawal <hemant.agrawal@nxp.com>,
Sachin Saxena <sachin.saxena@nxp.com>,
"Lilijun (Jerry)" <jerry.lilijun@huawei.com>,
xudingke <xudingke@huawei.com>, dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 1/2] vfio: fix check for vfio_group_fd
Date: Tue, 19 May 2020 09:43:44 +0200 [thread overview]
Message-ID: <CAJFAV8wTshK8Jok8Tz_5LWs52yUmuk8fRzPsm1VMs8pH3h0ahw@mail.gmail.com> (raw)
In-Reply-To: <1589859720-16224-1-git-send-email-wangyunjian@huawei.com>
On Tue, May 19, 2020 at 5:42 AM wangyunjian <wangyunjian@huawei.com> wrote:
>
> From: Yunjian Wang <wangyunjian@huawei.com>
>
> The issue is that a file descriptor at 0 is a valid one. Currently
> the file not found, the return value will be set to 0. As a result,
> it is impossible to distinguish between a correct descriptor and a
> failed return value. Fix it to return -ENOENT instead of 0.
>
> Fixes: b758423bc4fe ("vfio: fix race condition with sysfs")
> Fixes: ff0b67d1c868 ("vfio: DMA mappinge")
> Cc: stable@dpdk.org
This patch reverts the (marked for stable) fix b758423bc4fe ("vfio:
fix race condition with sysfs") and comes with a different fix.
- Kevin, Luca, I would put this b758423bc4fe backport on hold.
- Anatoly, I don't want to put 20.05 at risk.
My simple question for 20.05 is, should we revert b758423bc4fe?
- This patchset will go to 20.08 as I don't feel confident in taking it now.
--
David Marchand
next prev parent reply other threads:[~2020-05-19 7:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 3:42 wangyunjian
2020-05-19 7:43 ` David Marchand [this message]
2020-05-21 12:53 ` Burakov, Anatoly
2020-05-22 7:36 ` David Marchand
2020-05-27 10:45 ` Kevin Traynor
2020-07-29 11:43 ` wangyunjian
2020-09-17 11:44 ` Burakov, Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8wTshK8Jok8Tz_5LWs52yUmuk8fRzPsm1VMs8pH3h0ahw@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=bluca@debian.org \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=jerry.lilijun@huawei.com \
--cc=ktraynor@redhat.com \
--cc=sachin.saxena@nxp.com \
--cc=stable@dpdk.org \
--cc=wangyunjian@huawei.com \
--cc=xudingke@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).