From: David Marchand <david.marchand@redhat.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, Luca Boccassi <bluca@debian.org>,
Aaron Conole <aconole@redhat.com>, dpdk stable <stable@dpdk.org>,
Thomas Monjalon <thomas@monjalon.net>,
Ranjit Menon <ranjit.menon@intel.com>,
Jeff Shaw <jeffrey.b.shaw@intel.com>,
Pallavi Kadam <pallavi.kadam@intel.com>,
Harini Ramakrishnan <harini.ramakrishnan@microsoft.com>,
Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-stable] [PATCH 1/2] build: fix libm detection in meson
Date: Thu, 9 Jan 2020 15:08:55 +0100 [thread overview]
Message-ID: <CAJFAV8xzkwXt9rskMWdS_Q6M2KUDpYBGyuoq6b0dP_R51VyZ=Q@mail.gmail.com> (raw)
In-Reply-To: <20200109130900.GB248@bricha3-MOBL.ger.corp.intel.com>
On Thu, Jan 9, 2020 at 2:09 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> On Thu, Jan 09, 2020 at 01:59:15PM +0100, David Marchand wrote:
> > Using version 0.47.1, meson is unable to find the math library in Travis
> > for the 32bits job.
> > Quite surprisingly, this problem is not seen with the 64bits jobs.
> >
> > Switching to 0.48.0, the problem disappears.
> >
> > But we should pass 'm' to find_library instead of 'libm' anyway.
> >
> > Fixes: 98edcbb5ab2f ("eal/windows: introduce Windows support")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
> > config/meson.build | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/config/meson.build b/config/meson.build
> > index 01911ecf9..28a57f56f 100644
> > --- a/config/meson.build
> > +++ b/config/meson.build
> > @@ -115,7 +115,7 @@ add_project_link_arguments('-pthread', language: 'c')
> > dpdk_extra_ldflags += '-pthread'
> >
> > # on some OS, maths functions are in a separate library
> > -if cc.find_library('libm', required : false).found()
> > +if cc.find_library('m', required : false).found()
> > # some libs depend on maths lib
> > add_project_link_arguments('-lm', language: 'c')
> > dpdk_extra_ldflags += '-lm'
> > --
> > 2.23.0
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Series applied.
--
David Marchand
next prev parent reply other threads:[~2020-01-09 14:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 12:59 David Marchand
2020-01-09 12:59 ` [dpdk-stable] [PATCH 2/2] ci: use meson 0.47.1 David Marchand
2020-01-09 13:09 ` Bruce Richardson
2020-01-09 14:16 ` Aaron Conole
2020-01-09 13:09 ` [dpdk-stable] [PATCH 1/2] build: fix libm detection in meson Bruce Richardson
2020-01-09 14:08 ` David Marchand [this message]
2020-01-09 14:17 ` Aaron Conole
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8xzkwXt9rskMWdS_Q6M2KUDpYBGyuoq6b0dP_R51VyZ=Q@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=aconole@redhat.com \
--cc=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=harini.ramakrishnan@microsoft.com \
--cc=jeffrey.b.shaw@intel.com \
--cc=pallavi.kadam@intel.com \
--cc=ranjit.menon@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).