From: "Michał Krawczyk" <mk@semihalf.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Marcin Wojtas <mw@semihalf.com>,
Maciej Bielski <mba@semihalf.com>,
"Tzalik, Guy" <gtzalik@amazon.com>,
"Schmeilin, Evgeny" <evgenys@amazon.com>,
"Chauskin, Igor" <igorch@amazon.com>,
stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 02/29] net/ena/base: make allocation macros thread-safe
Date: Tue, 31 Mar 2020 11:47:04 +0200 [thread overview]
Message-ID: <CAJMMOfNwO182v=DMJv1b-kBjPTm6Oj7GJVFzwenC1QWNsVMXzQ@mail.gmail.com> (raw)
In-Reply-To: <20200327075448.417ef984@hermes.lan>
pt., 27 mar 2020 o 15:54 Stephen Hemminger
<stephen@networkplumber.org> napisał(a):
>
> On Fri, 27 Mar 2020 11:17:56 +0100
> Michal Krawczyk <mk@semihalf.com> wrote:
>
> > From: Igor Chauskin <igorch@amazon.com>
> >
> > Memory allocation region id could possibly be non-unique
> > due to non-atomic increment, causing allocation failure.
> >
> > Fixes: 9ba7981ec992 ("ena: add communication layer for DPDK")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Igor Chauskin <igorch@amazon.com>
> > Reviewed-by: Michal Krawczyk <mk@semihalf.com>
> > Reviewed-by: Guy Tzalik <gtzalik@amazon.com>
>
> With DPDK all control operations are the device are supposed
> to be single threaded by the caller. Do you have an allocation in
> some datapath?
Currently, there aren't any allocations on the datapath. But if you
don't mind, we would like to keep the atomics there for future
robustness.
next prev parent reply other threads:[~2020-03-31 9:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200327101823.12646-1-mk@semihalf.com>
2020-03-27 10:17 ` [dpdk-stable] " Michal Krawczyk
2020-03-27 14:54 ` [dpdk-stable] [dpdk-dev] " Stephen Hemminger
2020-03-31 9:47 ` Michał Krawczyk [this message]
2020-03-27 10:17 ` [dpdk-stable] [PATCH 03/29] net/ena/base: prevent allocation of 0-sized memory Michal Krawczyk
2020-03-27 10:18 ` [dpdk-stable] [PATCH 15/29] net/ena: set IO ring size to the valid value Michal Krawczyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJMMOfNwO182v=DMJv1b-kBjPTm6Oj7GJVFzwenC1QWNsVMXzQ@mail.gmail.com' \
--to=mk@semihalf.com \
--cc=dev@dpdk.org \
--cc=evgenys@amazon.com \
--cc=gtzalik@amazon.com \
--cc=igorch@amazon.com \
--cc=mba@semihalf.com \
--cc=mw@semihalf.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).