patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Li, Xiaoyun" <>
To: "Yigit, Ferruh" <>,
	"Singh, Jasvinder" <>,
	"Wu, Jingjing" <>,
	"Adrien Mazarguil" <>,
	"Dumitrescu, Cristian" <>
Cc: "" <>, "" <>
Subject: Re: [dpdk-stable] [PATCH v3] app/testpmd: fix meter commands help strings
Date: Wed, 10 Feb 2021 00:28:33 +0000
Message-ID: <> (raw)
In-Reply-To: <>

Acked-by: Xiaoyun Li <>

-----Original Message-----
From: Yigit, Ferruh <> 
Sent: Tuesday, February 9, 2021 22:15
To: Li, Xiaoyun <>; Singh, Jasvinder <>; Wu, Jingjing <>; Adrien Mazarguil <>; Dumitrescu, Cristian <>
Cc: Yigit, Ferruh <>;;
Subject: [PATCH v3] app/testpmd: fix meter commands help strings

Helps strings syntax is "command : description", the 'command' part was missing, updated command help strings.

Fixes: 281eeb8afc55 ("app/testpmd: add commands for metering and policing")
Fixes: 30ffb4e67ee3 ("app/testpmd: add commands traffic metering and policing")
Fixes: e63b50162aa3 ("app/testpmd: clean metering and policing commands")

Signed-off-by: Ferruh Yigit <>

- "set port meter dscp table" documented with 'port_id' & 'mtr_id', but
  command itself is not requiring it, can be better to double check the
  intention in the command.
- In command "show port meter stats <port_id> <mtr_id> yes|no", it is
  not clear what 'yes|no' is, can be better to have a 'clear' keyword
  there: "show port meter stats <port_id> <mtr_id> clear yes|no"
- 'meter' commands seems using many high level commands, that is harder
  to remember when you take all commands into account:
  "show port meter ..."
  "add port meter ..."
  "del port meter ..."
  "create port meter ..."
  "enable port meter ..."
  "disable port meter ..."
  "set port meter ..."
  And some high level commands created just for 'meter'. Instead I think
  it is better to group the commands, like:
  "port meter [add,del,create,enable,disable] ..."
  "show port meter ..."
  It is already too late but it worth to keep in mind for the possible
  future update.

* Fixed typo, actiono -> action0
* Added more info to help string, like "<variable>(possible values)"

* Fix the "set port meter dscp table" command according the original
 app/test-pmd/cmdline_mtr.c | 33 +++++++++++++++++++--------------
 1 file changed, 19 insertions(+), 14 deletions(-)

      parent reply	other threads:[~2021-02-10  0:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-05 13:39 [dpdk-stable] [PATCH] " Ferruh Yigit
2021-02-07  2:47 ` Li, Xiaoyun
2021-02-08 14:40   ` Ferruh Yigit
2021-02-08 15:15 ` [dpdk-stable] [PATCH v2] " Ferruh Yigit
2021-02-09  2:35   ` Li, Xiaoyun
2021-02-09 11:19     ` Ferruh Yigit
2021-02-09 14:15 ` [dpdk-stable] [PATCH v3] " Ferruh Yigit
2021-02-09 15:32   ` Singh, Jasvinder
2021-02-10 20:59     ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2021-02-10  0:28   ` Li, Xiaoyun [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ \
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:

AGPL code for this site: git clone