patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Devendra Singh Rawat <dsinghrawat@marvell.com>
To: Igor Russkikh <irusskikh@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Rasesh Mody <rmody@marvell.com>,
	Igor Russkikh <irusskikh@marvell.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH 2/2] qede: make driver accept bigger rss tables
Date: Thu, 11 Mar 2021 09:28:52 +0000
Message-ID: <CY4PR18MB14966F391BF414AD59B5EC0BB6909@CY4PR18MB1496.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20210221111637.31193-3-irusskikh@marvell.com>



> -----Original Message-----
> From: Igor Russkikh <irusskikh@marvell.com>
> Sent: Sunday, February 21, 2021 4:47 PM
> To: dev@dpdk.org
> Cc: Rasesh Mody <rmody@marvell.com>; Devendra Singh Rawat
> <dsinghrawat@marvell.com>; Igor Russkikh <irusskikh@marvell.com>;
> stable@dpdk.org
> Subject: [PATCH 2/2] qede: make driver accept bigger rss tables
> 
> We found some dpdk applications blindly pass fixed side rss hash tables, and
> do not check driver/device capabilities.
> 
> Moreover, many other drivers do not do such a strong check as well.
> 
> So here we fix it, making qede accept any size rss_key. For larger key tables we
> just crop it with notice trace message.
> 
> CC: stable@dpdk.org
> Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
> ---
>  drivers/net/qede/qede_ethdev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
> index ab5f5b106..7363d98f2 100644
> --- a/drivers/net/qede/qede_ethdev.c
> +++ b/drivers/net/qede/qede_ethdev.c
> @@ -2139,8 +2139,8 @@ int qede_rss_hash_update(struct rte_eth_dev
> *eth_dev,
>  		/* RSS hash key */
>  		if (key) {
>  			if (len > (ECORE_RSS_KEY_SIZE * sizeof(uint32_t))) {
> -				DP_ERR(edev, "RSS key length exceeds
> limit\n");
> -				return -EINVAL;
> +				len = ECORE_RSS_KEY_SIZE * sizeof(uint32_t);
> +				DP_NOTICE(edev, false, "RSS key length
> exceeds limit\n");

IMO, it will be better if the log message also states that RSS key is trimmed to 'len' size.

Thanks,
Devendra

  parent reply	other threads:[~2021-03-11  9:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210221111637.31193-1-irusskikh@marvell.com>
2021-02-21 11:16 ` [dpdk-stable] [PATCH 1/2] qede: reduce trace verbosity level Igor Russkikh
2021-03-11  9:13   ` Devendra Singh Rawat
2021-02-21 11:16 ` [dpdk-stable] [PATCH 2/2] qede: make driver accept bigger rss tables Igor Russkikh
2021-03-08 19:02   ` [dpdk-stable] [dpdk-dev] " Jerin Jacob
2021-03-11  9:28   ` Devendra Singh Rawat [this message]
2021-03-19  9:48     ` [dpdk-stable] " Igor Russkikh
2021-03-22  5:22       ` Devendra Singh Rawat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CY4PR18MB14966F391BF414AD59B5EC0BB6909@CY4PR18MB1496.namprd18.prod.outlook.com \
    --to=dsinghrawat@marvell.com \
    --cc=dev@dpdk.org \
    --cc=irusskikh@marvell.com \
    --cc=rmody@marvell.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git