patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH 1/2] eal: remove redundant code
@ 2020-06-11 10:24 Phil Yang
  2020-07-08  5:14 ` Honnappa Nagarahalli
  0 siblings, 1 reply; 3+ messages in thread
From: Phil Yang @ 2020-06-11 10:24 UTC (permalink / raw)
  To: dev; +Cc: drc, honnappa.nagarahalli, ruifeng.wang, nd, shahafs, stable

The event status has been cleaned up by the CAS operation when we free
the event data, so there is no need to set it to invalid after that.

Fixes: 49e2f374e45a ("eal/linux: support external Rx interrupt")
Cc: shahafs@mellanox.com
Cc: stable@dpdk.org

Signed-off-by: Phil Yang <phil.yang@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
 lib/librte_eal/linux/eal_interrupts.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/librte_eal/linux/eal_interrupts.c b/lib/librte_eal/linux/eal_interrupts.c
index 16e7a7d..2f369dc 100644
--- a/lib/librte_eal/linux/eal_interrupts.c
+++ b/lib/librte_eal/linux/eal_interrupts.c
@@ -1431,7 +1431,6 @@ rte_intr_free_epoll_fd(struct rte_intr_handle *intr_handle)
 		if (rte_epoll_ctl(rev->epfd, EPOLL_CTL_DEL, rev->fd, rev)) {
 			/* force free if the entry valid */
 			eal_epoll_data_safe_free(rev);
-			rev->status = RTE_EPOLL_INVALID;
 		}
 	}
 }
-- 
2.7.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH 1/2] eal: remove redundant code
  2020-06-11 10:24 [dpdk-stable] [PATCH 1/2] eal: remove redundant code Phil Yang
@ 2020-07-08  5:14 ` Honnappa Nagarahalli
  2020-07-08  5:20   ` Phil Yang
  0 siblings, 1 reply; 3+ messages in thread
From: Honnappa Nagarahalli @ 2020-07-08  5:14 UTC (permalink / raw)
  To: Phil Yang, dev
  Cc: drc, Ruifeng Wang, nd, shahafs, stable, Honnappa Nagarahalli, nd

<snip>

> Subject: [PATCH 1/2] eal: remove redundant code
> 
> The event status has been cleaned up by the CAS operation when we free
> the event data, so there is no need to set it to invalid after that.
> 
> Fixes: 49e2f374e45a ("eal/linux: support external Rx interrupt")
> Cc: shahafs@mellanox.com
> Cc: stable@dpdk.org
This is not a bug fix. I think it is not worth backporting, suggest removing this.

> 
> Signed-off-by: Phil Yang <phil.yang@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Otherwise

Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>

> ---
>  lib/librte_eal/linux/eal_interrupts.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/lib/librte_eal/linux/eal_interrupts.c
> b/lib/librte_eal/linux/eal_interrupts.c
> index 16e7a7d..2f369dc 100644
> --- a/lib/librte_eal/linux/eal_interrupts.c
> +++ b/lib/librte_eal/linux/eal_interrupts.c
> @@ -1431,7 +1431,6 @@ rte_intr_free_epoll_fd(struct rte_intr_handle
> *intr_handle)
>  		if (rte_epoll_ctl(rev->epfd, EPOLL_CTL_DEL, rev->fd, rev)) {
>  			/* force free if the entry valid */
>  			eal_epoll_data_safe_free(rev);
> -			rev->status = RTE_EPOLL_INVALID;
>  		}
>  	}
>  }
> --
> 2.7.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH 1/2] eal: remove redundant code
  2020-07-08  5:14 ` Honnappa Nagarahalli
@ 2020-07-08  5:20   ` Phil Yang
  0 siblings, 0 replies; 3+ messages in thread
From: Phil Yang @ 2020-07-08  5:20 UTC (permalink / raw)
  To: Honnappa Nagarahalli, dev; +Cc: drc, Ruifeng Wang, nd, shahafs, stable, nd

> -----Original Message-----
> From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
> Sent: Wednesday, July 8, 2020 1:15 PM
> To: Phil Yang <Phil.Yang@arm.com>; dev@dpdk.org
> Cc: drc@linux.vnet.ibm.com; Ruifeng Wang <Ruifeng.Wang@arm.com>; nd
> <nd@arm.com>; shahafs@mellanox.com; stable@dpdk.org; Honnappa
> Nagarahalli <Honnappa.Nagarahalli@arm.com>; nd <nd@arm.com>
> Subject: RE: [PATCH 1/2] eal: remove redundant code
> 
> <snip>
> 
> > Subject: [PATCH 1/2] eal: remove redundant code
> >
> > The event status has been cleaned up by the CAS operation when we free
> > the event data, so there is no need to set it to invalid after that.
> >
> > Fixes: 49e2f374e45a ("eal/linux: support external Rx interrupt")
> > Cc: shahafs@mellanox.com
> > Cc: stable@dpdk.org
> This is not a bug fix. I think it is not worth backporting, suggest removing this.

OK.

> 
> >
> > Signed-off-by: Phil Yang <phil.yang@arm.com>
> > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> Otherwise
> 
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> 
> > ---
> >  lib/librte_eal/linux/eal_interrupts.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/lib/librte_eal/linux/eal_interrupts.c
> > b/lib/librte_eal/linux/eal_interrupts.c
> > index 16e7a7d..2f369dc 100644
> > --- a/lib/librte_eal/linux/eal_interrupts.c
> > +++ b/lib/librte_eal/linux/eal_interrupts.c
> > @@ -1431,7 +1431,6 @@ rte_intr_free_epoll_fd(struct rte_intr_handle
> > *intr_handle)
> >  		if (rte_epoll_ctl(rev->epfd, EPOLL_CTL_DEL, rev->fd, rev)) {
> >  			/* force free if the entry valid */
> >  			eal_epoll_data_safe_free(rev);
> > -			rev->status = RTE_EPOLL_INVALID;
> >  		}
> >  	}
> >  }
> > --
> > 2.7.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-07-08  5:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-11 10:24 [dpdk-stable] [PATCH 1/2] eal: remove redundant code Phil Yang
2020-07-08  5:14 ` Honnappa Nagarahalli
2020-07-08  5:20   ` Phil Yang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).