19.11.14 patches review and test

19.11.14 patches review and test

[christian.ehrhardt]

Hi all,

Here is a list of patches targeted for stable release 19.11.14.

The planned date for the final release is Tue 12th December 2022.

Please help with testing and validation of your use cases and report
any issues/results with reply-all to this mail. For the final release
the fixes and reported validations will be added to the release notes.

A release candidate tarball can be found at:

    https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.14-rc1

These patches are located at branch 19.11 of dpdk-stable repo:
    https://dpdk.org/browse/dpdk-stable/

Thanks.

Christian Ehrhardt <christian.ehrhardt@canonical.com>

---
Alex Kiselev (1):
      net/tap: fix overflow of network interface index

Alexander Chernavin (1):
      net/virtio: fix crash when configured twice

Ali Alnubani (1):
      examples/l2fwd-crypto: fix typo in error message

Amit Prakash Shukla (5):
      net/mvneta: fix build with GCC 12
      test/ipsec: fix build with GCC 12
      ipsec: fix build with GCC 12
      crypto/qat: fix build with GCC 12
      net/qede/base: fix 32-bit build with GCC 12

Anoob Joseph (1):
      test/crypto: fix PDCP vectors

Brian Dooley (1):
      crypto/qat: fix null hash algorithm digest size

Chengwen Feng (1):
      net/hns3: fix crash when secondary process access FW

Ciara Power (1):
      test/crypto: fix wireless auth digest segment

Dariusz Sosnowski (1):
      net/mlx5: fix hairpin split with set VLAN VID action

David Marchand (9):
      vhost: fix virtqueue use after free on NUMA reallocation
      app/testpmd: restore ixgbe bypass commands
      service: fix build with clang 15
      bus/dpaa: fix build with clang 15
      net/atlantic: fix build with clang 15
      app/testpmd: fix build with clang 15
      test/efd: fix build with clang 15
      test/member: fix build with clang 15
      test/event: fix build with clang 15

Dmitry Kozlyuk (1):
      eal: fix side effect in some pointer arithmetic macros

Erik Gabriel Carrillo (1):
      service: fix early move to inactive status

Fidaullah Noonari (1):
      malloc: fix storage size for some allocations

Ganapati Kundapura (1):
      eventdev/crypto: fix multi-process

Gregory Etelson (1):
      doc: add LRO size limitation in mlx5 guide

Hamza Khan (1):
      examples/vm_power_manager: use safe list iterator

Huisong Li (2):
      net/bonding: fix dropping valid MAC packets
      net/bonding: fix mbuf fast free handling

Huzaifa Rahman (1):
      net/memif: fix crash with different number of Rx/Tx queues

Ivan Malov (4):
      common/sfc_efx/base: fix maximum Tx data count
      net/bonding: fix descriptor limit reporting
      net/bonding: fix flow flush order on close
      net/bonding: set initial value of descriptor count alignment

James Hershaw (1):
      net/nfp: improve HW info header log readability

Jeremy Spewock (1):
      test/ipsec: skip if no compatible device

Jerin Jacob (2):
      eal: fix doxygen comments for UUID
      power: fix some doxygen comments

Jun Qiu (1):
      net/bonding: fix Tx hash for TCP

Kai Ji (1):
      test/crypto: fix bitwise operator in a SNOW3G case

Ke Zhang (1):
      net/i40e: fix VF representor release

Kevin Liu (1):
      net/ice: check illegal packet sizes

Kumara Parameshwaran (1):
      gro: fix chain index for more than 2 packets

Long Li (2):
      net/mlx4: fix Verbs FD leak in secondary process
      net/mlx5: fix Verbs FD leak in secondary process

Long Wu (1):
      net/nfp: fix memory leak in Rx

Luca Boccassi (1):
      drivers: fix typos found by Lintian

Mattias Rönnblom (1):
      net: accept unaligned data in checksum routines

Michael Baum (2):
      net/mlx5: fix port event cleaning order
      net/mlx5: fix invalid memory access in port closing

Mingjin Ye (2):
      net/ice: fix scalar Rx path segment
      net/ice: fix scalar Tx path segment

Naga Harish K S V (4):
      eventdev/eth_tx: add spinlock for adapter start/stop
      eventdev/eth_tx: fix adapter stop
      timer: fix stopping all timers
      eventdev/eth_tx: fix queue delete

Olivier Matz (5):
      event/sw: fix flow ID init in self test
      event/sw: fix log in self test
      net/ixgbe: fix broadcast Rx on VF after promisc removal
      net/ixgbe: fix unexpected VLAN Rx in promisc mode on VF
      net/ixgbevf: fix promiscuous and allmulti

Pablo de Lara (1):
      examples/fips_validation: fix typo in error log

Peng Zhang (1):
      net/nfp: fix internal buffer size and MTU check

Qi Zhang (2):
      net/ice/base: fix media type of PHY 10G SFI C2C
      net/ice/base: fix array overflow in add switch recipe

Shun Hao (1):
      net/mlx5: fix meter profile delete after disable

Stephen Coleman (1):
      doc: fix typo depreciated instead of deprecated

Stephen Hemminger (7):
      event/sw: fix device name in dump
      eal: fix data race in multi-process support
      pdump: do not allow enable/disable in primary process
      license: fix paths
      app/testpmd: make quit flag volatile
      doc: fix net drivers ordering
      ring: remove leftover comment about watermark

Steven Zou (1):
      common/iavf: avoid copy in async mode

Sunyang Wu (1):
      test/crypto: fix debug messages

Vladimir Medvedkin (1):
      test/hash: remove dead code in extendable bucket test

Volodymyr Fialko (1):
      eventdev: fix name of Rx conf type in documentation

Yi Li (1):
      doc: fix maximum packet size of virtio driver

Yiding Zhou (1):
      net/ice/base: fix duplicate flow rules

Yunjian Wang (2):
      net/bonding: fix array overflow in Rx burst
      net/bonding: fix double slave link status query

Re: 19.11.14 patches review and test

[YangHang Liu]

[-- Attachment #1: Type: text/plain, Size: 7904 bytes --]

Hi,  Christian

RedHat QE does not find new issues about the 19.11.14 dpdk during the tests.

We tested below 17 scenarios and all got PASS on RHEL8:

   - Guest with device assignment(PF) throughput testing(1G hugepage size):
   PASS
   - Guest with device assignment(PF) throughput testing(2M hugepage size)
   : PASS
   - Guest with device assignment(VF) throughput testing: PASS
   - PVP (host dpdk testpmd as vswitch) 1Q: throughput testing: PASS
   - PVP vhost-user 2Q throughput testing: PASS
   - PVP vhost-user 1Q - cross numa node throughput testing: PASS
   - Guest with vhost-user 2 queues throughput testing: PASS
   - vhost-user reconnect with dpdk-client, qemu-server: qemu reconnect:
   PASS
   - vhost-user reconnect with dpdk-client, qemu-server: ovs reconnect: PASS
   - PVP 1Q live migration testing: PASS
   - PVP 1Q cross numa node live migration testing: PASS
   - Guest with ovs+dpdk+vhost-user 1Q live migration testing: PASS
   - Guest with ovs+dpdk+vhost-user 1Q live migration testing (2M): PASS
   - Guest with ovs+dpdk+vhost-user 2Q live migration testing: PASS
   - Guest with ovs+dpdk+vhost-user 4Q live migration testing: PASS
   - Host PF + DPDK testing: PASS
   - Host VF + DPDK testing: PASS

Versions:

   - kernel 4.18
   - qemu-kvm-6.2
   - DPDk
      - commit f99f2e55af7a49a6ee6555a5554847094086017f
      Author: Christian Ehrhardt <christian.ehrhardt@canonical.com>
      Date:   Mon Nov 28 11:46:00 2022 +0100
      version: 19.11.14-rc1
      Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>


   - NICs: X540-AT2 NIC(ixgbe, 10G)


Best Regards,
YangHang Liu


On Mon, Nov 28, 2022 at 9:17 PM <christian.ehrhardt@canonical.com> wrote:

> Hi all,
>
> Here is a list of patches targeted for stable release 19.11.14.
>
> The planned date for the final release is Tue 12th December 2022.
>
> Please help with testing and validation of your use cases and report
> any issues/results with reply-all to this mail. For the final release
> the fixes and reported validations will be added to the release notes.
>
> A release candidate tarball can be found at:
>
>     https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.14-rc1
>
> These patches are located at branch 19.11 of dpdk-stable repo:
>     https://dpdk.org/browse/dpdk-stable/
>
> Thanks.
>
> Christian Ehrhardt <christian.ehrhardt@canonical.com>
>
> ---
> Alex Kiselev (1):
>       net/tap: fix overflow of network interface index
>
> Alexander Chernavin (1):
>       net/virtio: fix crash when configured twice
>
> Ali Alnubani (1):
>       examples/l2fwd-crypto: fix typo in error message
>
> Amit Prakash Shukla (5):
>       net/mvneta: fix build with GCC 12
>       test/ipsec: fix build with GCC 12
>       ipsec: fix build with GCC 12
>       crypto/qat: fix build with GCC 12
>       net/qede/base: fix 32-bit build with GCC 12
>
> Anoob Joseph (1):
>       test/crypto: fix PDCP vectors
>
> Brian Dooley (1):
>       crypto/qat: fix null hash algorithm digest size
>
> Chengwen Feng (1):
>       net/hns3: fix crash when secondary process access FW
>
> Ciara Power (1):
>       test/crypto: fix wireless auth digest segment
>
> Dariusz Sosnowski (1):
>       net/mlx5: fix hairpin split with set VLAN VID action
>
> David Marchand (9):
>       vhost: fix virtqueue use after free on NUMA reallocation
>       app/testpmd: restore ixgbe bypass commands
>       service: fix build with clang 15
>       bus/dpaa: fix build with clang 15
>       net/atlantic: fix build with clang 15
>       app/testpmd: fix build with clang 15
>       test/efd: fix build with clang 15
>       test/member: fix build with clang 15
>       test/event: fix build with clang 15
>
> Dmitry Kozlyuk (1):
>       eal: fix side effect in some pointer arithmetic macros
>
> Erik Gabriel Carrillo (1):
>       service: fix early move to inactive status
>
> Fidaullah Noonari (1):
>       malloc: fix storage size for some allocations
>
> Ganapati Kundapura (1):
>       eventdev/crypto: fix multi-process
>
> Gregory Etelson (1):
>       doc: add LRO size limitation in mlx5 guide
>
> Hamza Khan (1):
>       examples/vm_power_manager: use safe list iterator
>
> Huisong Li (2):
>       net/bonding: fix dropping valid MAC packets
>       net/bonding: fix mbuf fast free handling
>
> Huzaifa Rahman (1):
>       net/memif: fix crash with different number of Rx/Tx queues
>
> Ivan Malov (4):
>       common/sfc_efx/base: fix maximum Tx data count
>       net/bonding: fix descriptor limit reporting
>       net/bonding: fix flow flush order on close
>       net/bonding: set initial value of descriptor count alignment
>
> James Hershaw (1):
>       net/nfp: improve HW info header log readability
>
> Jeremy Spewock (1):
>       test/ipsec: skip if no compatible device
>
> Jerin Jacob (2):
>       eal: fix doxygen comments for UUID
>       power: fix some doxygen comments
>
> Jun Qiu (1):
>       net/bonding: fix Tx hash for TCP
>
> Kai Ji (1):
>       test/crypto: fix bitwise operator in a SNOW3G case
>
> Ke Zhang (1):
>       net/i40e: fix VF representor release
>
> Kevin Liu (1):
>       net/ice: check illegal packet sizes
>
> Kumara Parameshwaran (1):
>       gro: fix chain index for more than 2 packets
>
> Long Li (2):
>       net/mlx4: fix Verbs FD leak in secondary process
>       net/mlx5: fix Verbs FD leak in secondary process
>
> Long Wu (1):
>       net/nfp: fix memory leak in Rx
>
> Luca Boccassi (1):
>       drivers: fix typos found by Lintian
>
> Mattias Rönnblom (1):
>       net: accept unaligned data in checksum routines
>
> Michael Baum (2):
>       net/mlx5: fix port event cleaning order
>       net/mlx5: fix invalid memory access in port closing
>
> Mingjin Ye (2):
>       net/ice: fix scalar Rx path segment
>       net/ice: fix scalar Tx path segment
>
> Naga Harish K S V (4):
>       eventdev/eth_tx: add spinlock for adapter start/stop
>       eventdev/eth_tx: fix adapter stop
>       timer: fix stopping all timers
>       eventdev/eth_tx: fix queue delete
>
> Olivier Matz (5):
>       event/sw: fix flow ID init in self test
>       event/sw: fix log in self test
>       net/ixgbe: fix broadcast Rx on VF after promisc removal
>       net/ixgbe: fix unexpected VLAN Rx in promisc mode on VF
>       net/ixgbevf: fix promiscuous and allmulti
>
> Pablo de Lara (1):
>       examples/fips_validation: fix typo in error log
>
> Peng Zhang (1):
>       net/nfp: fix internal buffer size and MTU check
>
> Qi Zhang (2):
>       net/ice/base: fix media type of PHY 10G SFI C2C
>       net/ice/base: fix array overflow in add switch recipe
>
> Shun Hao (1):
>       net/mlx5: fix meter profile delete after disable
>
> Stephen Coleman (1):
>       doc: fix typo depreciated instead of deprecated
>
> Stephen Hemminger (7):
>       event/sw: fix device name in dump
>       eal: fix data race in multi-process support
>       pdump: do not allow enable/disable in primary process
>       license: fix paths
>       app/testpmd: make quit flag volatile
>       doc: fix net drivers ordering
>       ring: remove leftover comment about watermark
>
> Steven Zou (1):
>       common/iavf: avoid copy in async mode
>
> Sunyang Wu (1):
>       test/crypto: fix debug messages
>
> Vladimir Medvedkin (1):
>       test/hash: remove dead code in extendable bucket test
>
> Volodymyr Fialko (1):
>       eventdev: fix name of Rx conf type in documentation
>
> Yi Li (1):
>       doc: fix maximum packet size of virtio driver
>
> Yiding Zhou (1):
>       net/ice/base: fix duplicate flow rules
>
> Yunjian Wang (2):
>       net/bonding: fix array overflow in Rx burst
>       net/bonding: fix double slave link status query
>
>

[-- Attachment #2: Type: text/html, Size: 10105 bytes --]

RE: 19.11.14 patches review and test

[Ali Alnubani]

> -----Original Message-----
> From: christian.ehrhardt@canonical.com
> <christian.ehrhardt@canonical.com>
> Sent: Monday, November 28, 2022 3:17 PM
> To: stable@dpdk.org
> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
> Ali Alnubani <alialnu@nvidia.com>; benjamin.walker@intel.com; David
> Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal
> <hemant.agrawal@nxp.com>; Ian Stokes <ian.stokes@intel.com>; Jerin
> Jacob <jerinj@marvell.com>; John McNamara <john.mcnamara@intel.com>;
> Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor
> <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang
> <pezhang@redhat.com>; qian.q.xu@intel.com; Raslan Darawsheh
> <rasland@nvidia.com>; NBU-Contact-Thomas Monjalon (EXTERNAL)
> <thomas@monjalon.net>; yanghliu@redhat.com; yuan.peng@intel.com;
> zhaoyan.chen@intel.com
> Subject: 19.11.14 patches review and test
> 
> Hi all,
> 
> Here is a list of patches targeted for stable release 19.11.14.
> 
> The planned date for the final release is Tue 12th December 2022.
> 
> Please help with testing and validation of your use cases and report
> any issues/results with reply-all to this mail. For the final release
> the fixes and reported validations will be added to the release notes.
> 
> A release candidate tarball can be found at:
> 
>     https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.14-rc1
> 
> These patches are located at branch 19.11 of dpdk-stable repo:
>     https://dpdk.org/browse/dpdk-stable/
> 
> Thanks.
> 
> Christian Ehrhardt <christian.ehrhardt@canonical.com>
> 
> ---

Hello,

We ran the following functional tests with Nvidia hardware on 19.11.14-rc1:
- Basic functionality:
  Send and receive multiple types of traffic.
- testpmd xstats counter test.
- testpmd timestamp test.
- Changing/checking link status through testpmd.
- RTE flow tests:
  Items: eth / ipv4 / ipv6 / tcp / udp / icmp / gre / nvgre / geneve / vxlan / mplsoudp / mplsogre
  Actions: drop / queue / rss / mark / flag / jump / count / raw_encap / raw_decap / vxlan_encap / vxlan_decap / NAT / dec_ttl
- Some RSS tests.
- VLAN filtering, stripping and insertion tests.
- Checksum and TSO tests.
- ptype tests.
- link_status_interrupt example application tests.
- l3fwd-power example application tests.
- Multi-process example applications tests.

Functional tests ran on:
- NIC: ConnectX-4 Lx / OS: Ubuntu 20.04 LTS / Driver: MLNX_OFED_LINUX-5.8-1.0.1.1 / Firmware: 14.32.1010
- NIC: ConnectX-5 / OS: Ubuntu 20.04 LTS / Driver: MLNX_OFED_LINUX-5.8-1.0.1.1 / Firmware: 16.35.1012

Additionally, we ran compilation tests with multiple configurations in the following OS/driver combinations, and they are passing:
- Ubuntu 22.04.1 with MLNX_OFED_LINUX-5.8-1.1.2.1.
- Ubuntu 20.04.5 with MLNX_OFED_LINUX-5.8-1.1.2.1.
- Ubuntu 20.04.5 with rdma-core master (76cfaa1).
- Ubuntu 20.04.5 with rdma-core v28.0.
- Ubuntu 18.04.6 with rdma-core v17.1.
- Ubuntu 18.04.6 with rdma-core master (76cfaa1) (i386).
- Ubuntu 16.04.7 with rdma-core v22.7.
- CentOS 7 7.9.2009 with rdma-core master (76cfaa1).
- CentOS 7 7.9.2009 with MLNX_OFED_LINUX-5.8-1.0.1.1.
- CentOS 8 8.4.2105 with rdma-core master (76cfaa1).
- OpenSUSE Leap 15.4 with rdma-core v38.1.

We don't see any issues introduced by changes in this release.

Builds on Fedora with gcc 12 and clang 15 are failing.

Please note that not all the functional tests mentioned above fall under "Basic functionality with testpmd" like reported in the release notes for previous releases:
https://git.dpdk.org/dpdk-stable/commit/?h=v19.11.13&id=104f5e8eb81e975809476fe894fc2781538ab752

The following patch was missed in 19.11.13:
https://inbox.dpdk.org/stable/DM4PR12MB516765207EE7A8999B284B5EDA1A9@DM4PR12MB5167.namprd12.prod.outlook.com/

Thanks,
Ali

Re: 19.11.14 patches review and test

[Christian Ehrhardt]

Thank you all so much - @ Jiang YuX, YangHang Liu, Ali Alnubani !

To add my own that just completed last night:

Same tests as usual, no regressions found:

19.11.14~rc1-0ubuntu0.20.04.1~focalppa1

1.0.0 (14:11:38): phys (BM) tests
  1.1.0 (14:11:38): initialize environment
    1.1.1 (14:14:57): testpmd  => Pass
    1.1.2 (14:16:32): check testpmd output  => Pass
2.0.0 (14:16:32): prep virtual test environment

1.0.0 (14:18:56): virt tests
  1.1.0 (14:18:56): initialize environment
3.0.0 (14:19:51): performance tests
  3.1.0 (14:19:51): prep benchmarks
  3.2.0 (14:21:53): performance tests
    3.2.1 (14:22:01): test guest-openvswitch for OVS-5CPU  => Pass
    3.2.2 (14:41:19): test guest-dpdk-vhost-user-client-multiq for
OVSDPDK-VUC  => Pass
4.0.0 (15:02:00): VUC endurance checks
  4.1.0 (15:02:00): prep VUC endurance tests
    4.1.1 (15:15:27): start stop guests (client)  => Pass
    4.1.2 (16:37:07): add/remove ports (client)  => Pass
  4.2.0 (16:46:39): Final cleanup


On Sun, Dec 11, 2022 at 3:40 PM Ali Alnubani <alialnu@nvidia.com> wrote:
>
> > -----Original Message-----
> > From: christian.ehrhardt@canonical.com
> > <christian.ehrhardt@canonical.com>
> > Sent: Monday, November 28, 2022 3:17 PM
> > To: stable@dpdk.org
> > Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
> > Ali Alnubani <alialnu@nvidia.com>; benjamin.walker@intel.com; David
> > Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal
> > <hemant.agrawal@nxp.com>; Ian Stokes <ian.stokes@intel.com>; Jerin
> > Jacob <jerinj@marvell.com>; John McNamara <john.mcnamara@intel.com>;
> > Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor
> > <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang
> > <pezhang@redhat.com>; qian.q.xu@intel.com; Raslan Darawsheh
> > <rasland@nvidia.com>; NBU-Contact-Thomas Monjalon (EXTERNAL)
> > <thomas@monjalon.net>; yanghliu@redhat.com; yuan.peng@intel.com;
> > zhaoyan.chen@intel.com
> > Subject: 19.11.14 patches review and test
> >
> > Hi all,
> >
> > Here is a list of patches targeted for stable release 19.11.14.
> >
> > The planned date for the final release is Tue 12th December 2022.
> >
> > Please help with testing and validation of your use cases and report
> > any issues/results with reply-all to this mail. For the final release
> > the fixes and reported validations will be added to the release notes.
> >
> > A release candidate tarball can be found at:
> >
> >     https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.14-rc1
> >
> > These patches are located at branch 19.11 of dpdk-stable repo:
> >     https://dpdk.org/browse/dpdk-stable/
> >
> > Thanks.
> >
> > Christian Ehrhardt <christian.ehrhardt@canonical.com>
> >
> > ---
>
> Hello,
>
> We ran the following functional tests with Nvidia hardware on 19.11.14-rc1:
> - Basic functionality:
>   Send and receive multiple types of traffic.
> - testpmd xstats counter test.
> - testpmd timestamp test.
> - Changing/checking link status through testpmd.
> - RTE flow tests:
>   Items: eth / ipv4 / ipv6 / tcp / udp / icmp / gre / nvgre / geneve / vxlan / mplsoudp / mplsogre
>   Actions: drop / queue / rss / mark / flag / jump / count / raw_encap / raw_decap / vxlan_encap / vxlan_decap / NAT / dec_ttl
> - Some RSS tests.
> - VLAN filtering, stripping and insertion tests.
> - Checksum and TSO tests.
> - ptype tests.
> - link_status_interrupt example application tests.
> - l3fwd-power example application tests.
> - Multi-process example applications tests.
>
> Functional tests ran on:
> - NIC: ConnectX-4 Lx / OS: Ubuntu 20.04 LTS / Driver: MLNX_OFED_LINUX-5.8-1.0.1.1 / Firmware: 14.32.1010
> - NIC: ConnectX-5 / OS: Ubuntu 20.04 LTS / Driver: MLNX_OFED_LINUX-5.8-1.0.1.1 / Firmware: 16.35.1012
>
> Additionally, we ran compilation tests with multiple configurations in the following OS/driver combinations, and they are passing:
> - Ubuntu 22.04.1 with MLNX_OFED_LINUX-5.8-1.1.2.1.
> - Ubuntu 20.04.5 with MLNX_OFED_LINUX-5.8-1.1.2.1.
> - Ubuntu 20.04.5 with rdma-core master (76cfaa1).
> - Ubuntu 20.04.5 with rdma-core v28.0.
> - Ubuntu 18.04.6 with rdma-core v17.1.
> - Ubuntu 18.04.6 with rdma-core master (76cfaa1) (i386).
> - Ubuntu 16.04.7 with rdma-core v22.7.
> - CentOS 7 7.9.2009 with rdma-core master (76cfaa1).
> - CentOS 7 7.9.2009 with MLNX_OFED_LINUX-5.8-1.0.1.1.
> - CentOS 8 8.4.2105 with rdma-core master (76cfaa1).
> - OpenSUSE Leap 15.4 with rdma-core v38.1.
>
> We don't see any issues introduced by changes in this release.
>
> Builds on Fedora with gcc 12 and clang 15 are failing.
>
> Please note that not all the functional tests mentioned above fall under "Basic functionality with testpmd" like reported in the release notes for previous releases:
> https://git.dpdk.org/dpdk-stable/commit/?h=v19.11.13&id=104f5e8eb81e975809476fe894fc2781538ab752
>
> The following patch was missed in 19.11.13:
> https://inbox.dpdk.org/stable/DM4PR12MB516765207EE7A8999B284B5EDA1A9@DM4PR12MB5167.namprd12.prod.outlook.com/
>
> Thanks,
> Ali



-- 
Christian Ehrhardt
Senior Staff Engineer, Ubuntu Server
Canonical Ltd

Re: 19.11.14 patches review and test

[Christian Ehrhardt]

On Sun, Dec 11, 2022 at 3:40 PM Ali Alnubani <alialnu@nvidia.com> wrote:
>
> > -----Original Message-----
> > From: christian.ehrhardt@canonical.com
> > <christian.ehrhardt@canonical.com>
> > Sent: Monday, November 28, 2022 3:17 PM
> > To: stable@dpdk.org
> > Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
> > Ali Alnubani <alialnu@nvidia.com>; benjamin.walker@intel.com; David
> > Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal
> > <hemant.agrawal@nxp.com>; Ian Stokes <ian.stokes@intel.com>; Jerin
> > Jacob <jerinj@marvell.com>; John McNamara <john.mcnamara@intel.com>;
> > Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor
> > <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang
> > <pezhang@redhat.com>; qian.q.xu@intel.com; Raslan Darawsheh
> > <rasland@nvidia.com>; NBU-Contact-Thomas Monjalon (EXTERNAL)
> > <thomas@monjalon.net>; yanghliu@redhat.com; yuan.peng@intel.com;
> > zhaoyan.chen@intel.com
> > Subject: 19.11.14 patches review and test
> >
> > Hi all,
> >
> > Here is a list of patches targeted for stable release 19.11.14.
> >
> > The planned date for the final release is Tue 12th December 2022.
> >
> > Please help with testing and validation of your use cases and report
> > any issues/results with reply-all to this mail. For the final release
> > the fixes and reported validations will be added to the release notes.
> >
> > A release candidate tarball can be found at:
> >
> >     https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.14-rc1
> >
> > These patches are located at branch 19.11 of dpdk-stable repo:
> >     https://dpdk.org/browse/dpdk-stable/
> >
> > Thanks.
> >
> > Christian Ehrhardt <christian.ehrhardt@canonical.com>
> >
> > ---
>
> Hello,
>
> We ran the following functional tests with Nvidia hardware on 19.11.14-rc1:
> - Basic functionality:
>   Send and receive multiple types of traffic.
> - testpmd xstats counter test.
> - testpmd timestamp test.
> - Changing/checking link status through testpmd.
> - RTE flow tests:
>   Items: eth / ipv4 / ipv6 / tcp / udp / icmp / gre / nvgre / geneve / vxlan / mplsoudp / mplsogre
>   Actions: drop / queue / rss / mark / flag / jump / count / raw_encap / raw_decap / vxlan_encap / vxlan_decap / NAT / dec_ttl
> - Some RSS tests.
> - VLAN filtering, stripping and insertion tests.
> - Checksum and TSO tests.
> - ptype tests.
> - link_status_interrupt example application tests.
> - l3fwd-power example application tests.
> - Multi-process example applications tests.
>
> Functional tests ran on:
> - NIC: ConnectX-4 Lx / OS: Ubuntu 20.04 LTS / Driver: MLNX_OFED_LINUX-5.8-1.0.1.1 / Firmware: 14.32.1010
> - NIC: ConnectX-5 / OS: Ubuntu 20.04 LTS / Driver: MLNX_OFED_LINUX-5.8-1.0.1.1 / Firmware: 16.35.1012
>
> Additionally, we ran compilation tests with multiple configurations in the following OS/driver combinations, and they are passing:
> - Ubuntu 22.04.1 with MLNX_OFED_LINUX-5.8-1.1.2.1.
> - Ubuntu 20.04.5 with MLNX_OFED_LINUX-5.8-1.1.2.1.
> - Ubuntu 20.04.5 with rdma-core master (76cfaa1).
> - Ubuntu 20.04.5 with rdma-core v28.0.
> - Ubuntu 18.04.6 with rdma-core v17.1.
> - Ubuntu 18.04.6 with rdma-core master (76cfaa1) (i386).
> - Ubuntu 16.04.7 with rdma-core v22.7.
> - CentOS 7 7.9.2009 with rdma-core master (76cfaa1).
> - CentOS 7 7.9.2009 with MLNX_OFED_LINUX-5.8-1.0.1.1.
> - CentOS 8 8.4.2105 with rdma-core master (76cfaa1).
> - OpenSUSE Leap 15.4 with rdma-core v38.1.
>
> We don't see any issues introduced by changes in this release.
>
> Builds on Fedora with gcc 12 and clang 15 are failing.
>
> Please note that not all the functional tests mentioned above fall under "Basic functionality with testpmd" like reported in the release notes for previous releases:
> https://git.dpdk.org/dpdk-stable/commit/?h=v19.11.13&id=104f5e8eb81e975809476fe894fc2781538ab752
>
> The following patch was missed in 19.11.13:
> https://inbox.dpdk.org/stable/DM4PR12MB516765207EE7A8999B284B5EDA1A9@DM4PR12MB5167.namprd12.prod.outlook.com/

Hi thanks for spotting it.
It has fallen through the cracks as the backport for 17f95513 was
already applied as edea6144.
But this was in fact a follow up fix to edea6144 itself, which I
failed to see at the time.

Ali, it still seems to apply cleanly and indeed is missing from the
former backport.
Do you think I can apply this without needing a full -rc2 of 19.11.14
(and thereby massively stalling the release due to a new test round)?

> Thanks,
> Ali




--
Christian Ehrhardt
Senior Staff Engineer, Ubuntu Server
Canonical Ltd

RE: 19.11.14 patches review and test

[Ali Alnubani]

> -----Original Message-----
> From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> Sent: Tuesday, December 13, 2022 1:41 PM
> To: Ali Alnubani <alialnu@nvidia.com>
> Cc: stable@dpdk.org; dev@dpdk.org; Abhishek Marathe
> <Abhishek.Marathe@microsoft.com>; benjamin.walker@intel.com; David
> Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal
> <hemant.agrawal@nxp.com>; Ian Stokes <ian.stokes@intel.com>; Jerin
> Jacob <jerinj@marvell.com>; John McNamara <john.mcnamara@intel.com>;
> Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor
> <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang
> <pezhang@redhat.com>; qian.q.xu@intel.com; Raslan Darawsheh
> <rasland@nvidia.com>; NBU-Contact-Thomas Monjalon (EXTERNAL)
> <thomas@monjalon.net>; yanghliu@redhat.com; yuan.peng@intel.com;
> zhaoyan.chen@intel.com
> Subject: Re: 19.11.14 patches review and test
> 
> On Sun, Dec 11, 2022 at 3:40 PM Ali Alnubani <alialnu@nvidia.com> wrote:
> >
> > > -----Original Message-----
> > > From: christian.ehrhardt@canonical.com
> > > <christian.ehrhardt@canonical.com>
> > > Sent: Monday, November 28, 2022 3:17 PM
> > > To: stable@dpdk.org
> > > Cc: dev@dpdk.org; Abhishek Marathe
> <Abhishek.Marathe@microsoft.com>;
> > > Ali Alnubani <alialnu@nvidia.com>; benjamin.walker@intel.com; David
> > > Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal
> > > <hemant.agrawal@nxp.com>; Ian Stokes <ian.stokes@intel.com>; Jerin
> > > Jacob <jerinj@marvell.com>; John McNamara
> <john.mcnamara@intel.com>;
> > > Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor
> > > <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang
> > > <pezhang@redhat.com>; qian.q.xu@intel.com; Raslan Darawsheh
> > > <rasland@nvidia.com>; NBU-Contact-Thomas Monjalon (EXTERNAL)
> > > <thomas@monjalon.net>; yanghliu@redhat.com; yuan.peng@intel.com;
> > > zhaoyan.chen@intel.com
> > > Subject: 19.11.14 patches review and test
> > >
> > > Hi all,
> > >
> > > Here is a list of patches targeted for stable release 19.11.14.
> > >
> > > The planned date for the final release is Tue 12th December 2022.
> > >
> > > Please help with testing and validation of your use cases and report
> > > any issues/results with reply-all to this mail. For the final release
> > > the fixes and reported validations will be added to the release notes.
> > >
> > > A release candidate tarball can be found at:
> > >
> > >     https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.14-rc1
> > >
> > > These patches are located at branch 19.11 of dpdk-stable repo:
> > >     https://dpdk.org/browse/dpdk-stable/
> > >
> > > Thanks.
> > >
> > > Christian Ehrhardt <christian.ehrhardt@canonical.com>
> > >
> > > ---
> >
> > Hello,
> >
> > We ran the following functional tests with Nvidia hardware on 19.11.14-rc1:
> > - Basic functionality:
> >   Send and receive multiple types of traffic.
> > - testpmd xstats counter test.
> > - testpmd timestamp test.
> > - Changing/checking link status through testpmd.
> > - RTE flow tests:
> >   Items: eth / ipv4 / ipv6 / tcp / udp / icmp / gre / nvgre / geneve / vxlan /
> mplsoudp / mplsogre
> >   Actions: drop / queue / rss / mark / flag / jump / count / raw_encap /
> raw_decap / vxlan_encap / vxlan_decap / NAT / dec_ttl
> > - Some RSS tests.
> > - VLAN filtering, stripping and insertion tests.
> > - Checksum and TSO tests.
> > - ptype tests.
> > - link_status_interrupt example application tests.
> > - l3fwd-power example application tests.
> > - Multi-process example applications tests.
> >
> > Functional tests ran on:
> > - NIC: ConnectX-4 Lx / OS: Ubuntu 20.04 LTS / Driver: MLNX_OFED_LINUX-
> 5.8-1.0.1.1 / Firmware: 14.32.1010
> > - NIC: ConnectX-5 / OS: Ubuntu 20.04 LTS / Driver: MLNX_OFED_LINUX-5.8-
> 1.0.1.1 / Firmware: 16.35.1012
> >
> > Additionally, we ran compilation tests with multiple configurations in the
> following OS/driver combinations, and they are passing:
> > - Ubuntu 22.04.1 with MLNX_OFED_LINUX-5.8-1.1.2.1.
> > - Ubuntu 20.04.5 with MLNX_OFED_LINUX-5.8-1.1.2.1.
> > - Ubuntu 20.04.5 with rdma-core master (76cfaa1).
> > - Ubuntu 20.04.5 with rdma-core v28.0.
> > - Ubuntu 18.04.6 with rdma-core v17.1.
> > - Ubuntu 18.04.6 with rdma-core master (76cfaa1) (i386).
> > - Ubuntu 16.04.7 with rdma-core v22.7.
> > - CentOS 7 7.9.2009 with rdma-core master (76cfaa1).
> > - CentOS 7 7.9.2009 with MLNX_OFED_LINUX-5.8-1.0.1.1.
> > - CentOS 8 8.4.2105 with rdma-core master (76cfaa1).
> > - OpenSUSE Leap 15.4 with rdma-core v38.1.
> >
> > We don't see any issues introduced by changes in this release.
> >
> > Builds on Fedora with gcc 12 and clang 15 are failing.
> >
> > Please note that not all the functional tests mentioned above fall under
> "Basic functionality with testpmd" like reported in the release notes for
> previous releases:
> > https://git.dpdk.org/dpdk-
> stable/commit/?h=v19.11.13&id=104f5e8eb81e975809476fe894fc2781538ab7
> 52
> >
> > The following patch was missed in 19.11.13:
> >
> https://inbox.dpdk.org/stable/DM4PR12MB516765207EE7A8999B284B5EDA1
> A9@DM4PR12MB5167.namprd12.prod.outlook.com/
> 
> Hi thanks for spotting it.
> It has fallen through the cracks as the backport for 17f95513 was
> already applied as edea6144.
> But this was in fact a follow up fix to edea6144 itself, which I
> failed to see at the time.
> 
> Ali, it still seems to apply cleanly and indeed is missing from the
> former backport.
> Do you think I can apply this without needing a full -rc2 of 19.11.14
> (and thereby massively stalling the release due to a new test round)?
> 

The patch only affects mlx5, and we made sure it doesn't introduce new issues on Nvidia devices.
No need to delay the release with a new rc.

Thank you for helping with this.

Regards,
Ali