From: "Wang, Yinan" <yinan.wang@intel.com>
To: "Ding, Xuan" <xuan.ding@intel.com>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
"Wang, Zhihong" <zhihong.wang@intel.com>,
"Ye, Xiaolong" <xiaolong.ye@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Ding, Xuan" <xuan.ding@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] vhost: fix zero-copy cannot be enabled
Date: Tue, 19 May 2020 07:03:09 +0000 [thread overview]
Message-ID: <DM5PR11MB138885328B452D08B96DC86C8FB90@DM5PR11MB1388.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200513021410.98031-1-xuan.ding@intel.com>
Tested-by: Wang, Yinan <yinan.wang@intel.com>
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Xuan Ding
> Sent: 2020年5月13日 10:14
> To: maxime.coquelin@redhat.com; Wang, Zhihong <zhihong.wang@intel.com>;
> Ye, Xiaolong <xiaolong.ye@intel.com>
> Cc: dev@dpdk.org; Ding, Xuan <Xuan.Ding@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] vhost: fix zero-copy cannot be enabled
>
> This patch fixes the situation where vhost-user cannot start as server with
> dequeue_zero_copy enabled.
>
> Using flag instead of vsocket->is_server to determine whether vhost-user is in
> client mode. Because vsocket->is_server is not ready at this time.
>
> Cc: stable@dpdk.org
>
> Signed-off-by: Xuan Ding <xuan.ding@intel.com>
> ---
>
> v2:
> * Added the description of problem solved in commit log.
> ---
> lib/librte_vhost/socket.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c index
> bb8d0d780..0a66ef976 100644
> --- a/lib/librte_vhost/socket.c
> +++ b/lib/librte_vhost/socket.c
> @@ -926,7 +926,7 @@ rte_vhost_driver_register(const char *path, uint64_t
> flags)
> ret = -1;
> goto out_mutex;
> }
> - if (!vsocket->is_server) {
> + if ((flags & RTE_VHOST_USER_CLIENT) != 0) {
> VHOST_LOG_CONFIG(ERR,
> "error: zero copy is incompatible with vhost client
> mode\n");
> ret = -1;
> --
> 2.17.1
prev parent reply other threads:[~2020-05-19 7:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 9:51 [dpdk-stable] [PATCH] vhost: fix dequeue_zero_zopy " Xuan Ding
2020-05-13 2:14 ` [dpdk-stable] [PATCH v2] vhost: fix zero-copy " Xuan Ding
2020-05-19 6:28 ` Ye Xiaolong
2020-05-19 7:13 ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong
2020-05-19 13:43 ` Ferruh Yigit
2020-05-19 7:03 ` Wang, Yinan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5PR11MB138885328B452D08B96DC86C8FB90@DM5PR11MB1388.namprd11.prod.outlook.com \
--to=yinan.wang@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=xiaolong.ye@intel.com \
--cc=xuan.ding@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).