From: Asaf Penso <asafp@nvidia.com>
To: Slava Ovsiienko <viacheslavo@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Raslan Darawsheh <rasland@nvidia.com>,
Matan Azrad <matan@nvidia.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/mlx5: fix buffer split offload advertising
Date: Sun, 13 Dec 2020 08:30:41 +0000 [thread overview]
Message-ID: <DM5PR12MB240674D972395B2EAFE6C94BCDC80@DM5PR12MB2406.namprd12.prod.outlook.com> (raw)
In-Reply-To: <1607687092-6620-1-git-send-email-viacheslavo@nvidia.com>
>-----Original Message-----
>From: dev <dev-bounces@dpdk.org> On Behalf Of Viacheslav Ovsiienko
>Sent: Friday, December 11, 2020 1:45 PM
>To: dev@dpdk.org
>Cc: Raslan Darawsheh <rasland@nvidia.com>; Matan Azrad
><matan@nvidia.com>; stable@dpdk.org
>Subject: [dpdk-dev] [PATCH] net/mlx5: fix buffer split offload advertising
>
>The buffer split Rx offload is not compatible with Multi-Packet Receiving
>Queue (MPRQ) Rx offload, hence, the buffer split offload flag
>RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT and other related values should be
>advertised only if there is no MPRQ engaged.
>
>Fixes: 6c8f7f1c1877 ("net/mlx5: report Rx buffer split capabilities")
>Cc: stable@dpdk.org
>
>Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Reviewed-by: Asaf Penso <asafp@nvidia.com>
>---
> drivers/net/mlx5/mlx5_ethdev.c | 4 ++--
> drivers/net/mlx5/mlx5_rxq.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/drivers/net/mlx5/mlx5_ethdev.c
>b/drivers/net/mlx5/mlx5_ethdev.c index a3910cf..45ee7e4 100644
>--- a/drivers/net/mlx5/mlx5_ethdev.c
>+++ b/drivers/net/mlx5/mlx5_ethdev.c
>@@ -310,8 +310,8 @@
> info->max_mac_addrs = MLX5_MAX_UC_MAC_ADDRESSES;
> info->rx_queue_offload_capa = mlx5_get_rx_queue_offloads(dev);
> info->rx_seg_capa.max_nseg = MLX5_MAX_RXQ_NSEG;
>- info->rx_seg_capa.multi_pools = 1;
>- info->rx_seg_capa.offset_allowed = 1;
>+ info->rx_seg_capa.multi_pools = !config->mprq.enabled;
>+ info->rx_seg_capa.offset_allowed = !config->mprq.enabled;
> info->rx_seg_capa.offset_align_log2 = 0;
> info->rx_offload_capa = (mlx5_get_rx_port_offloads() |
> info->rx_queue_offload_capa);
>diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index
>da7a8b3..a2613b0 100644
>--- a/drivers/net/mlx5/mlx5_rxq.c
>+++ b/drivers/net/mlx5/mlx5_rxq.c
>@@ -402,14 +402,14 @@
> struct mlx5_priv *priv = dev->data->dev_private;
> struct mlx5_dev_config *config = &priv->config;
> uint64_t offloads = (DEV_RX_OFFLOAD_SCATTER |
>- RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT |
> DEV_RX_OFFLOAD_TIMESTAMP |
> DEV_RX_OFFLOAD_JUMBO_FRAME |
> DEV_RX_OFFLOAD_RSS_HASH);
>
>+ if (!config->mprq.enabled)
>+ offloads |= RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT;
> if (config->hw_fcs_strip)
> offloads |= DEV_RX_OFFLOAD_KEEP_CRC;
>-
> if (config->hw_csum)
> offloads |= (DEV_RX_OFFLOAD_IPV4_CKSUM |
> DEV_RX_OFFLOAD_UDP_CKSUM |
>--
>1.8.3.1
next prev parent reply other threads:[~2020-12-13 8:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 11:44 [dpdk-stable] " Viacheslav Ovsiienko
2020-12-13 8:30 ` Asaf Penso [this message]
2020-12-16 10:43 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5PR12MB240674D972395B2EAFE6C94BCDC80@DM5PR12MB2406.namprd12.prod.outlook.com \
--to=asafp@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).