From: Raslan Darawsheh <rasland@nvidia.com>
To: Suanming Mou <suanmingm@nvidia.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
Matan Azrad <matan@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH 3/4] net/mlx5: fix secondary process attach port Tx queue
Date: Mon, 25 Jan 2021 08:30:58 +0000 [thread overview]
Message-ID: <DM6PR12MB2748A184EA2B4C23289015AACFBD0@DM6PR12MB2748.namprd12.prod.outlook.com> (raw)
In-Reply-To: <1611486126-84749-4-git-send-email-suanmingm@nvidia.com>
Hi,
> -----Original Message-----
> From: Suanming Mou <suanmingm@nvidia.com>
> Sent: Sunday, January 24, 2021 1:02 PM
> To: Slava Ovsiienko <viacheslavo@nvidia.com>; Matan Azrad
> <matan@nvidia.com>
> Cc: Raslan Darawsheh <rasland@nvidia.com>; dev@dpdk.org;
> stable@dpdk.org
> Subject: [PATCH 3/4] net/mlx5: fix secondary process attach port Tx queue
>
> Currently, the secondary process port UAR register mapping used by Tx
> queue is done during port initializing.
>
> Unluckily, in port hot-plug case, the secondary process was requested
> to initialize the port when primary process did not complete the
> device configuration and the port Tx queue number is not configured
> yet. Hence, the secondary process getS the zero Tx queue number during
> probing, causing the UAR registers not be mapped in the correct
> fashion.
>
> This commit checks the configured number of Tx queues in secondary
> process when the port start is requested. In case the Tx queue
> number mismatch found the UAR mapping is reinitialized accordingly.
>
> Fixes: 2aac5b5d119f ("net/mlx5: sync stop/start with secondary process")
> cc: stable@dpdk.org
>
> Signed-off-by: Suanming Mou <suanmingm@nvidia.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> ---
> drivers/net/mlx5/linux/mlx5_mp_os.c | 19 +++++++++++++++++++
> drivers/net/mlx5/mlx5.c | 2 +-
> drivers/net/mlx5/mlx5.h | 6 +++++-
> 3 files changed, 25 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/mlx5/linux/mlx5_mp_os.c
> b/drivers/net/mlx5/linux/mlx5_mp_os.c
> index 08ade75..95372e2 100644
> --- a/drivers/net/mlx5/linux/mlx5_mp_os.c
> +++ b/drivers/net/mlx5/linux/mlx5_mp_os.c
[...]
>
> -/* Per-process private structure. */
> +/*
> + * Per-process private structure.
> + * Caution, secondary pocess may rebuid the struct during port start.
> + */
Typo in
pocess-> process
rebuid-> rebuild
will fix during integration.
[...]
> 1.8.3.1
Kindest regards
Raslan Darawsheh
next prev parent reply other threads:[~2021-01-25 8:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1611486126-84749-1-git-send-email-suanmingm@nvidia.com>
2021-01-24 11:02 ` [dpdk-stable] [PATCH 2/4] net/mlx5: fix secondary process port detach crash Suanming Mou
2021-01-24 11:02 ` [dpdk-stable] [PATCH 3/4] net/mlx5: fix secondary process attach port Tx queue Suanming Mou
2021-01-25 8:30 ` Raslan Darawsheh [this message]
2021-01-24 11:02 ` [dpdk-stable] [PATCH 4/4] net/mlx4: " Suanming Mou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR12MB2748A184EA2B4C23289015AACFBD0@DM6PR12MB2748.namprd12.prod.outlook.com \
--to=rasland@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=stable@dpdk.org \
--cc=suanmingm@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).