patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] net/qede: fix get link details
@ 2020-10-01 22:41 Rasesh Mody
  2020-10-02 19:59 ` [dpdk-stable] [PATCH v2] " Rasesh Mody
  2020-10-02 20:02 ` [dpdk-stable] [PATCH] " Rasesh Mody
  0 siblings, 2 replies; 4+ messages in thread
From: Rasesh Mody @ 2020-10-01 22:41 UTC (permalink / raw)
  To: Jerin Jacob, Ferruh Yigit, dev
  Cc: stable, Igor Russkikh, GR-Everest-DPDK-Dev, Rasesh Mody

This patch fixes get current link details, without this change the link
details can be inaccurate if proper lock is not acquired.

Fixes: 739a5b2f2b49 ("net/qede/base: use passed ptt handler")
Cc: stable@dpdk.org

Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
Signed-off-by: Rasesh Mody <rmody@marvell.com>
Signed-off-by: Igor Russkikh <irusskikh@marvell.com> 
---
 drivers/net/qede/qede_main.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c
index aecb98261..f0ca3373f 100644
--- a/drivers/net/qede/qede_main.c
+++ b/drivers/net/qede/qede_main.c
@@ -584,13 +584,12 @@ qed_get_current_link(struct ecore_dev *edev, struct qed_link_output *if_link)
 	hwfn = &edev->hwfns[0];
 	if (IS_PF(edev)) {
 		ptt = ecore_ptt_acquire(hwfn);
-		if (!ptt)
-			DP_NOTICE(hwfn, true, "Failed to fill link; No PTT\n");
-
+		if (ptt) {
 			qed_fill_link(hwfn, ptt, if_link);
-
-		if (ptt)
 			ecore_ptt_release(hwfn, ptt);
+		} else {
+			DP_NOTICE(hwfn, "Failed to fill link; No PTT\n");
+		}
 	} else {
 		qed_fill_link(hwfn, NULL, if_link);
 	}
-- 
2.18.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dpdk-stable] [PATCH v2] net/qede: fix get link details
  2020-10-01 22:41 [dpdk-stable] [PATCH] net/qede: fix get link details Rasesh Mody
@ 2020-10-02 19:59 ` Rasesh Mody
  2020-10-04  8:37   ` Jerin Jacob
  2020-10-02 20:02 ` [dpdk-stable] [PATCH] " Rasesh Mody
  1 sibling, 1 reply; 4+ messages in thread
From: Rasesh Mody @ 2020-10-02 19:59 UTC (permalink / raw)
  To: Jerin Jacob, Ferruh Yigit, dev
  Cc: stable, Igor Russkikh, GR-Everest-DPDK-Dev, Rasesh Mody

This patch fixes get current link details, without this change the link
details can be inaccurate if proper lock is not acquired.

Fixes: 739a5b2f2b49 ("net/qede/base: use passed ptt handler")
Cc: stable@dpdk.org

Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
Signed-off-by: Rasesh Mody <rmody@marvell.com>
Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
---
 drivers/net/qede/qede_main.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c
index aecb98261..1ae10d99d 100644
--- a/drivers/net/qede/qede_main.c
+++ b/drivers/net/qede/qede_main.c
@@ -584,13 +584,12 @@ qed_get_current_link(struct ecore_dev *edev, struct qed_link_output *if_link)
 	hwfn = &edev->hwfns[0];
 	if (IS_PF(edev)) {
 		ptt = ecore_ptt_acquire(hwfn);
-		if (!ptt)
-			DP_NOTICE(hwfn, true, "Failed to fill link; No PTT\n");
-
+		if (ptt) {
 			qed_fill_link(hwfn, ptt, if_link);
-
-		if (ptt)
 			ecore_ptt_release(hwfn, ptt);
+		} else {
+			DP_NOTICE(hwfn, true, "Failed to fill link; No PTT\n");
+		}
 	} else {
 		qed_fill_link(hwfn, NULL, if_link);
 	}
-- 
2.18.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-stable] [PATCH] net/qede: fix get link details
  2020-10-01 22:41 [dpdk-stable] [PATCH] net/qede: fix get link details Rasesh Mody
  2020-10-02 19:59 ` [dpdk-stable] [PATCH v2] " Rasesh Mody
@ 2020-10-02 20:02 ` Rasesh Mody
  1 sibling, 0 replies; 4+ messages in thread
From: Rasesh Mody @ 2020-10-02 20:02 UTC (permalink / raw)
  To: Jerin Jacob, Ferruh Yigit, dev; +Cc: stable, Igor Russkikh, GR-Everest-DPDK-Dev

Hi Jerin - please use v2, which addresses the build issues.

On 10/1/20, 3:41 PM, "Rasesh Mody" <rmody@marvell.com> wrote:

    This patch fixes get current link details, without this change the link
    details can be inaccurate if proper lock is not acquired.

    Fixes: 739a5b2f2b49 ("net/qede/base: use passed ptt handler")
    Cc: stable@dpdk.org

    Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
    Signed-off-by: Rasesh Mody <rmody@marvell.com>
    Signed-off-by: Igor Russkikh <irusskikh@marvell.com> 
    ---
     drivers/net/qede/qede_main.c | 9 ++++-----
     1 file changed, 4 insertions(+), 5 deletions(-)

    diff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c
    index aecb98261..f0ca3373f 100644
    --- a/drivers/net/qede/qede_main.c
    +++ b/drivers/net/qede/qede_main.c
    @@ -584,13 +584,12 @@ qed_get_current_link(struct ecore_dev *edev, struct qed_link_output *if_link)
     	hwfn = &edev->hwfns[0];
     	if (IS_PF(edev)) {
     		ptt = ecore_ptt_acquire(hwfn);
    -		if (!ptt)
    -			DP_NOTICE(hwfn, true, "Failed to fill link; No PTT\n");
    -
    +		if (ptt) {
     			qed_fill_link(hwfn, ptt, if_link);
    -
    -		if (ptt)
     			ecore_ptt_release(hwfn, ptt);
    +		} else {
    +			DP_NOTICE(hwfn, "Failed to fill link; No PTT\n");
    +		}
     	} else {
     		qed_fill_link(hwfn, NULL, if_link);
     	}
    -- 
    2.18.1



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-stable] [PATCH v2] net/qede: fix get link details
  2020-10-02 19:59 ` [dpdk-stable] [PATCH v2] " Rasesh Mody
@ 2020-10-04  8:37   ` Jerin Jacob
  0 siblings, 0 replies; 4+ messages in thread
From: Jerin Jacob @ 2020-10-04  8:37 UTC (permalink / raw)
  To: Rasesh Mody
  Cc: Ferruh Yigit, dpdk-dev, dpdk stable, Igor Russkikh, GR-Everest-DPDK-Dev

On Sat, Oct 3, 2020 at 1:30 AM Rasesh Mody <rmody@marvell.com> wrote:
>
> This patch fixes get current link details, without this change the link
> details can be inaccurate if proper lock is not acquired.
>
> Fixes: 739a5b2f2b49 ("net/qede/base: use passed ptt handler")
> Cc: stable@dpdk.org
>
> Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Signed-off-by: Rasesh Mody <rmody@marvell.com>
> Signed-off-by: Igor Russkikh <irusskikh@marvell.com>


Applied to dpdk-next-net-mrvl/main. Thanks


> ---
>  drivers/net/qede/qede_main.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c
> index aecb98261..1ae10d99d 100644
> --- a/drivers/net/qede/qede_main.c
> +++ b/drivers/net/qede/qede_main.c
> @@ -584,13 +584,12 @@ qed_get_current_link(struct ecore_dev *edev, struct qed_link_output *if_link)
>         hwfn = &edev->hwfns[0];
>         if (IS_PF(edev)) {
>                 ptt = ecore_ptt_acquire(hwfn);
> -               if (!ptt)
> -                       DP_NOTICE(hwfn, true, "Failed to fill link; No PTT\n");
> -
> +               if (ptt) {
>                         qed_fill_link(hwfn, ptt, if_link);
> -
> -               if (ptt)
>                         ecore_ptt_release(hwfn, ptt);
> +               } else {
> +                       DP_NOTICE(hwfn, true, "Failed to fill link; No PTT\n");
> +               }
>         } else {
>                 qed_fill_link(hwfn, NULL, if_link);
>         }
> --
> 2.18.1
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-10-04  8:38 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-01 22:41 [dpdk-stable] [PATCH] net/qede: fix get link details Rasesh Mody
2020-10-02 19:59 ` [dpdk-stable] [PATCH v2] " Rasesh Mody
2020-10-04  8:37   ` Jerin Jacob
2020-10-02 20:02 ` [dpdk-stable] [PATCH] " Rasesh Mody

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git