patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Zhao1, Wei" <wei.zhao1@intel.com>
To: "Jiang, JunyuX" <junyux.jiang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Yang, Qiming" <qiming.yang@intel.com>,
	"Jiang, JunyuX" <junyux.jiang@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] net/ice: fix core dumped issue in switch	filter
Date: Wed, 20 May 2020 09:31:07 +0000
Message-ID: <MWHPR11MB1391E690FD909850D1068728B7B60@MWHPR11MB1391.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200506030525.3907-1-junyux.jiang@intel.com>

Hi, Junyu

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Junyu Jiang
> Sent: Wednesday, May 6, 2020 11:05 AM
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; guinanx.sun@intel.com X
> <junyux.jiang@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] net/ice: fix core dumped issue in switch filter
> 
> The number of queues in queue group should be checked before using it. This
> patch fixed the issue.
> 
> Fixes: 47d460d63233 ("net/ice: rework switch filter")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Junyu Jiang <junyux.jiang@intel.com>
> Tested-by: Qimai Xiao <qimaix.xiao@intel.com>
> ---
>  drivers/net/ice/ice_switch_filter.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ice/ice_switch_filter.c
> b/drivers/net/ice/ice_switch_filter.c
> index 179430136..c2762e331 100644
> --- a/drivers/net/ice/ice_switch_filter.c
> +++ b/drivers/net/ice/ice_switch_filter.c
> @@ -1296,6 +1296,8 @@ ice_switch_parse_action(struct ice_pf *pf,
>  		switch (action_type) {
>  		case RTE_FLOW_ACTION_TYPE_RSS:
>  			act_qgrop = action->conf;
> +			if (act_qgrop->queue_num <= 1)
> +				goto error;

Why do you ban the case of queue num =1?

>  			rule_info->sw_act.fltr_act =
>  				ICE_FWD_TO_QGRP;
>  			rule_info->sw_act.fwd_id.q_id =
> --
> 2.17.1


  parent reply	other threads:[~2020-05-20  9:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-29  7:25 [dpdk-stable] [PATCH] " Junyu Jiang
2020-04-30  6:52 ` Yang, Qiming
2020-04-30  7:42   ` Jiang, JunyuX
2020-04-30  9:09 ` [dpdk-stable] [dpdk-dev] " Xiao, QimaiX
2020-05-06  3:05 ` [dpdk-stable] [PATCH v2] " Junyu Jiang
2020-05-06  6:30   ` Yang, Qiming
2020-05-06  8:57   ` Ye Xiaolong
2020-05-20  9:31   ` Zhao1, Wei [this message]
2020-05-20  9:32     ` [dpdk-stable] [dpdk-dev] " Zhao1, Wei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MWHPR11MB1391E690FD909850D1068728B7B60@MWHPR11MB1391.namprd11.prod.outlook.com \
    --to=wei.zhao1@intel.com \
    --cc=dev@dpdk.org \
    --cc=junyux.jiang@intel.com \
    --cc=qiming.yang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git