From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
Thierry Herbelot <thierry.herbelot@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>,
"david.marchand@redhat.com" <david.marchand@redhat.com>
Subject: Re: [dpdk-stable] [PATCH v2] table: fix typo
Date: Sat, 3 Jul 2021 00:07:26 +0000 [thread overview]
Message-ID: <SJ0PR11MB5677B5CAD62A2FFA7200DE2AEB1E9@SJ0PR11MB5677.namprd11.prod.outlook.com> (raw)
In-Reply-To: <DM8PR11MB5670D16AD8FC12699C698118EB029@DM8PR11MB5670.namprd11.prod.outlook.com>
> > > > > > > Hi Thierry,
> > > > > > >
> > > > > > > I think Thomas is asking for you to send a new version of this patch
> > with
> > > > > the title updated. Is this OK with you?
> > > > >
> > > > > No need to send a v3.
> > > >
> > > > OK, so you're going to fix the title while applying? Thanks, Thomas.
> > >
> > > Hi Thomas,
> > >
> > > I see this fix is not yet applied, is there any action required?
> >
> > The proposed title is not fantastic. Last one is:
> > table: all keys must be checked to declare that a bucket is empty
> >
> > I just need a title showing what is fixed.
> > What is the impact of the bug in bkt_is_empty()?
> >
>
> Hi Thomas,
>
> How about this one:
>
> table: fix bucket empty logic
>
> Due to a typo, only 3 our of 4 keys in the bucket of the exact match
> table were considered, which can result in valid keys being incorrectly
> dropped from the table.
>
> Regards,
> Cristian
Hi Thomas,
Ping,
next prev parent reply other threads:[~2021-07-03 0:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 8:53 [dpdk-stable] [PATCH] rte_swx: " Thierry Herbelot
2021-05-24 11:25 ` Dumitrescu, Cristian
2021-05-24 11:28 ` [dpdk-stable] [PATCH v2] table: " Thierry Herbelot
2021-05-24 11:30 ` Dumitrescu, Cristian
2021-06-17 7:01 ` Thomas Monjalon
2021-06-17 7:11 ` Thierry Herbelot
2021-06-21 15:44 ` Dumitrescu, Cristian
2021-06-21 15:54 ` Thierry Herbelot
2021-06-21 16:14 ` Thomas Monjalon
2021-06-21 16:56 ` Dumitrescu, Cristian
2021-06-29 11:35 ` Dumitrescu, Cristian
2021-06-29 13:41 ` Thomas Monjalon
2021-06-29 13:51 ` Dumitrescu, Cristian
2021-07-03 0:07 ` Dumitrescu, Cristian [this message]
2021-06-21 17:23 ` Thierry Herbelot
2021-07-07 11:19 ` [dpdk-stable] [PATCH V3] table: fix bucket empty logic Thierry Herbelot
2021-07-07 11:23 ` Dumitrescu, Cristian
2021-07-09 20:43 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR11MB5677B5CAD62A2FFA7200DE2AEB1E9@SJ0PR11MB5677.namprd11.prod.outlook.com \
--to=cristian.dumitrescu@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=thierry.herbelot@6wind.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).