patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Rong, Leyi" <leyi.rong@intel.com>
To: "Zhang, AlvinX" <alvinx.zhang@intel.com>,
	"Zhang, Qi Z" <qi.z.zhang@intel.com>,
	"Yang, Qiming" <qiming.yang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Zhang, AlvinX" <alvinx.zhang@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [DPDK] net/ice: fix txq mbuf release mode
Date: Tue, 27 Apr 2021 02:31:50 +0000
Message-ID: <SN6PR11MB2621A543749D912CDB2402CAEC419@SN6PR11MB2621.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210425092639.1428-1-alvinx.zhang@intel.com>


> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Alvin Zhang
> Sent: Sunday, April 25, 2021 5:27 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming <qiming.yang@intel.com>
> Cc: dev@dpdk.org; Zhang, AlvinX <alvinx.zhang@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [DPDK] net/ice: fix txq mbuf release mode
>
> In some cases, it seems that the txq mbuf vector release mode is enabled first,
> and then it is confirmed that the conditions for using the vector mode are not
> met.
>
> This patch puts the txq vector mode startup process after the condition
> detection.
>
> Fixes: 28f9002ab67f ("net/ice: add Tx AVX512 offload path")
> Cc: stable@dpdk.org
>
> Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
> ---
>  drivers/net/ice/ice_rxtx.c | 16 +++++++++-------
>  1 file changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c index
> 92fbbc1..49abcb2 100644
> --- a/drivers/net/ice/ice_rxtx.c
> +++ b/drivers/net/ice/ice_rxtx.c
> @@ -3303,13 +3303,6 @@
>  if (tx_check_ret >= 0 &&
>      rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_128)
> {
>  ad->tx_vec_allowed = true;
> -for (i = 0; i < dev->data->nb_tx_queues; i++) {
> -txq = dev->data->tx_queues[i];
> -if (txq && ice_txq_vec_setup(txq)) {
> -ad->tx_vec_allowed = false;
> -break;
> -}
> -}
>
>  if (rte_vect_get_max_simd_bitwidth() >=
> RTE_VECT_SIMD_512 &&
>  rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) ==
> 1 && @@ -3329,6 +3322,15 @@
>  if (!use_avx512 && tx_check_ret ==
> ICE_VECTOR_OFFLOAD_PATH)
>  ad->tx_vec_allowed = false;
>
> +if (ad->tx_vec_allowed) {
> +for (i = 0; i < dev->data->nb_tx_queues; i++) {
> +txq = dev->data->tx_queues[i];
> +if (txq && ice_txq_vec_setup(txq)) {
> +ad->tx_vec_allowed = false;
> +break;
> +}
> +}
> +}
>  } else {
>  ad->tx_vec_allowed = false;
>  }
> --
> 1.8.3.1

Acked-by: Leyi Rong <leyi.rong@intel.com>

  reply	other threads:[~2021-04-27  2:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-25  9:26 [dpdk-stable] " Alvin Zhang
2021-04-27  2:31 ` Rong, Leyi [this message]
2021-04-27  3:00   ` [dpdk-stable] [dpdk-dev] " Zhang, Qi Z
2021-04-28 10:03 ` [dpdk-stable] " Ferruh Yigit
2021-05-06  2:37   ` Zhang, AlvinX
2021-05-08  1:20 ` [dpdk-stable] [PATCH v2] net/ice: fix txq vector path selection Alvin Zhang
2021-05-08  2:37   ` Zhang, Qi Z
2021-05-08  3:10     ` Zhang, AlvinX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR11MB2621A543749D912CDB2402CAEC419@SN6PR11MB2621.namprd11.prod.outlook.com \
    --to=leyi.rong@intel.com \
    --cc=alvinx.zhang@intel.com \
    --cc=dev@dpdk.org \
    --cc=qi.z.zhang@intel.com \
    --cc=qiming.yang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git