* [PATCH] app/testpmd: fix 32-bit system forwarding failure
@ 2023-06-29 10:09 Shiyang He
2023-06-29 12:34 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Shiyang He @ 2023-06-29 10:09 UTC (permalink / raw)
To: dev
Cc: yidingx.zhou, Shiyang He, stable, Aman Singh, Yuying Zhang,
Raslan Darawsheh
l2_len is not calculated correctly on 32-bit systems, resulting in
packet forwarding failure.
This patch fixes this issue by changing the l2_len calculation.
Fixes: dd827fa42a30 ("app/testpmd: fix GTP L2 length in checksum engine")
Cc: stable@dpdk.org
Signed-off-by: Shiyang He <shiyangx.he@intel.com>
---
app/test-pmd/csumonly.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c
index 7af635e3f7..c103e54111 100644
--- a/app/test-pmd/csumonly.c
+++ b/app/test-pmd/csumonly.c
@@ -250,7 +250,7 @@ parse_gtp(struct rte_udp_hdr *udp_hdr,
info->l4_proto = 0;
}
- info->l2_len += gtp_len + sizeof(udp_hdr);
+ info->l2_len += gtp_len + sizeof(*udp_hdr);
}
/* Parse a vxlan header */
--
2.37.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] app/testpmd: fix 32-bit system forwarding failure
2023-06-29 10:09 [PATCH] app/testpmd: fix 32-bit system forwarding failure Shiyang He
@ 2023-06-29 12:34 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2023-06-29 12:34 UTC (permalink / raw)
To: Shiyang He, dev
Cc: yidingx.zhou, stable, Aman Singh, Yuying Zhang, Raslan Darawsheh
On 6/29/2023 11:09 AM, Shiyang He wrote:
> l2_len is not calculated correctly on 32-bit systems, resulting in
> packet forwarding failure.
>
> This patch fixes this issue by changing the l2_len calculation.
>
> Fixes: dd827fa42a30 ("app/testpmd: fix GTP L2 length in checksum engine")
> Cc: stable@dpdk.org
>
> Signed-off-by: Shiyang He <shiyangx.he@intel.com>
>
Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-29 12:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-29 10:09 [PATCH] app/testpmd: fix 32-bit system forwarding failure Shiyang He
2023-06-29 12:34 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).