patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH v1] net/ice: fix wrong FDIR flow type for IPv4 fragment
@ 2021-06-02  8:21 Ting Xu
  2021-06-07  0:42 ` Zhang, Qi Z
  0 siblings, 1 reply; 2+ messages in thread
From: Ting Xu @ 2021-06-02  8:21 UTC (permalink / raw)
  To: dev; +Cc: qi.z.zhang, qiming.yang, Ting Xu, stable

When creating FDIR rule and parsing the pattern, if IPv4 fragment type is
detected, the flow type is not changed to ICE_FLTR_PTYPE_FRAG_IPV4 from
ICE_FLTR_PTYPE_NONF_IPV4_OTHER. It will cause profile confilict with
other FDIR rules for IPv4 other type.

Fixes: b7e8781de768 ("net/ice: support flow director for IP fragment packet")
Cc: stable@dpdk.org

Signed-off-by: Ting Xu <ting.xu@intel.com>
---
 drivers/net/ice/ice_fdir_filter.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c
index 092c704503..5cba56918a 100644
--- a/drivers/net/ice/ice_fdir_filter.c
+++ b/drivers/net/ice/ice_fdir_filter.c
@@ -1780,6 +1780,7 @@ ice_fdir_parse_pattern(__rte_unused struct ice_adapter *ad,
 				 * ethertype, if the spec is for all valid
 				 * packet id, set ethertype into input set.
 				 */
+				flow_type = ICE_FLTR_PTYPE_FRAG_IPV4;
 				*input_set |= ICE_INSET_ETHERTYPE;
 				input_set_o |= ICE_INSET_ETHERTYPE;
 			} else if (ipv4_mask->hdr.packet_id == UINT16_MAX) {
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-stable] [PATCH v1] net/ice: fix wrong FDIR flow type for IPv4 fragment
  2021-06-02  8:21 [dpdk-stable] [PATCH v1] net/ice: fix wrong FDIR flow type for IPv4 fragment Ting Xu
@ 2021-06-07  0:42 ` Zhang, Qi Z
  0 siblings, 0 replies; 2+ messages in thread
From: Zhang, Qi Z @ 2021-06-07  0:42 UTC (permalink / raw)
  To: Xu, Ting, dev; +Cc: Yang, Qiming, stable



> -----Original Message-----
> From: Xu, Ting <ting.xu@intel.com>
> Sent: Wednesday, June 2, 2021 4:21 PM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>; Xu, Ting <ting.xu@intel.com>; stable@dpdk.org
> Subject: [PATCH v1] net/ice: fix wrong FDIR flow type for IPv4 fragment
> 
> When creating FDIR rule and parsing the pattern, if IPv4 fragment type is
> detected, the flow type is not changed to ICE_FLTR_PTYPE_FRAG_IPV4 from
> ICE_FLTR_PTYPE_NONF_IPV4_OTHER. It will cause profile confilict with other
> FDIR rules for IPv4 other type.
> 
> Fixes: b7e8781de768 ("net/ice: support flow director for IP fragment packet")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ting Xu <ting.xu@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-06-07  0:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-02  8:21 [dpdk-stable] [PATCH v1] net/ice: fix wrong FDIR flow type for IPv4 fragment Ting Xu
2021-06-07  0:42 ` Zhang, Qi Z

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git