* [dpdk-stable] [PATCH] app/testpmd: fix identifier size for port attach
@ 2020-02-19 16:47 Wisam Jaddo
2020-02-20 10:03 ` [dpdk-stable] [dpdk-dev] " Iremonger, Bernard
2020-02-20 12:28 ` [dpdk-stable] " Ferruh Yigit
0 siblings, 2 replies; 6+ messages in thread
From: Wisam Jaddo @ 2020-02-19 16:47 UTC (permalink / raw)
To: wenzhuo.lu, dev, rasland, matan; +Cc: mukawa, stable
Identifier for new port may contain white list options,
and white list options will not fit into 128 from STR_TOKEN_SIZE,
instead having 4096 char from STR_MULTI_TOKEN_SIZE will provide
better and more options
Fixes: edab33b1c01d ("app/testpmd: support port hotplug")
Cc: mukawa@igel.co.jp
Cc: stable@dpdk.org
Signed-off-by: Wisam Jaddo <wisamm@mellanox.com>
---
app/test-pmd/cmdline.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 38b6d80..a037a55 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -1446,7 +1446,7 @@ cmdline_parse_inst_t cmd_set_port_setup_on = {
struct cmd_operate_attach_port_result {
cmdline_fixed_string_t port;
cmdline_fixed_string_t keyword;
- cmdline_fixed_string_t identifier;
+ cmdline_multi_string_t identifier;
};
static void cmd_operate_attach_port_parsed(void *parsed_result,
@@ -1469,7 +1469,7 @@ cmdline_parse_token_string_t cmd_operate_attach_port_keyword =
keyword, "attach");
cmdline_parse_token_string_t cmd_operate_attach_port_identifier =
TOKEN_STRING_INITIALIZER(struct cmd_operate_attach_port_result,
- identifier, NULL);
+ identifier, TOKEN_STRING_MULTI);
cmdline_parse_inst_t cmd_operate_attach_port = {
.f = cmd_operate_attach_port_parsed,
--
2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-stable] [dpdk-dev] [PATCH] app/testpmd: fix identifier size for port attach
2020-02-19 16:47 [dpdk-stable] [PATCH] app/testpmd: fix identifier size for port attach Wisam Jaddo
@ 2020-02-20 10:03 ` Iremonger, Bernard
2020-02-20 14:18 ` Ferruh Yigit
2020-02-20 12:28 ` [dpdk-stable] " Ferruh Yigit
1 sibling, 1 reply; 6+ messages in thread
From: Iremonger, Bernard @ 2020-02-20 10:03 UTC (permalink / raw)
To: Wisam Jaddo, Lu, Wenzhuo, dev, rasland, matan; +Cc: mukawa, stable
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Wisam Jaddo
> Sent: Wednesday, February 19, 2020 4:48 PM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; dev@dpdk.org;
> rasland@mellanox.com; matan@mellanox.com
> Cc: mukawa@igel.co.jp; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] app/testpmd: fix identifier size for port attach
>
> Identifier for new port may contain white list options, and white list options
> will not fit into 128 from STR_TOKEN_SIZE, instead having 4096 char from
> STR_MULTI_TOKEN_SIZE will provide better and more options
>
> Fixes: edab33b1c01d ("app/testpmd: support port hotplug")
> Cc: mukawa@igel.co.jp
> Cc: stable@dpdk.org
>
> Signed-off-by: Wisam Jaddo <wisamm@mellanox.com>
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-stable] [dpdk-dev] [PATCH] app/testpmd: fix identifier size for port attach
2020-02-20 10:03 ` [dpdk-stable] [dpdk-dev] " Iremonger, Bernard
@ 2020-02-20 14:18 ` Ferruh Yigit
0 siblings, 0 replies; 6+ messages in thread
From: Ferruh Yigit @ 2020-02-20 14:18 UTC (permalink / raw)
To: Iremonger, Bernard, Wisam Jaddo, Lu, Wenzhuo, dev, rasland, matan
Cc: mukawa, stable
On 2/20/2020 10:03 AM, Iremonger, Bernard wrote:
>
>> -----Original Message-----
>> From: dev <dev-bounces@dpdk.org> On Behalf Of Wisam Jaddo
>> Sent: Wednesday, February 19, 2020 4:48 PM
>> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; dev@dpdk.org;
>> rasland@mellanox.com; matan@mellanox.com
>> Cc: mukawa@igel.co.jp; stable@dpdk.org
>> Subject: [dpdk-dev] [PATCH] app/testpmd: fix identifier size for port attach
>>
>> Identifier for new port may contain white list options, and white list options
>> will not fit into 128 from STR_TOKEN_SIZE, instead having 4096 char from
>> STR_MULTI_TOKEN_SIZE will provide better and more options
>>
>> Fixes: edab33b1c01d ("app/testpmd: support port hotplug")
>> Cc: mukawa@igel.co.jp
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Wisam Jaddo <wisamm@mellanox.com>
>
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-stable] [PATCH] app/testpmd: fix identifier size for port attach
2020-02-19 16:47 [dpdk-stable] [PATCH] app/testpmd: fix identifier size for port attach Wisam Jaddo
2020-02-20 10:03 ` [dpdk-stable] [dpdk-dev] " Iremonger, Bernard
@ 2020-02-20 12:28 ` Ferruh Yigit
2020-02-20 12:32 ` Wisam Monther
1 sibling, 1 reply; 6+ messages in thread
From: Ferruh Yigit @ 2020-02-20 12:28 UTC (permalink / raw)
To: Wisam Jaddo, wenzhuo.lu, dev, rasland, matan; +Cc: mukawa, stable
On 2/19/2020 4:47 PM, Wisam Jaddo wrote:
> Identifier for new port may contain white list options,
> and white list options will not fit into 128 from STR_TOKEN_SIZE,
> instead having 4096 char from STR_MULTI_TOKEN_SIZE will provide
> better and more options
Out of curiosity, what device identifier doesn't fit to 128 chars, can you
please give a sample?
>
> Fixes: edab33b1c01d ("app/testpmd: support port hotplug")
> Cc: mukawa@igel.co.jp
> Cc: stable@dpdk.org
>
> Signed-off-by: Wisam Jaddo <wisamm@mellanox.com>
> ---
> app/test-pmd/cmdline.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index 38b6d80..a037a55 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -1446,7 +1446,7 @@ cmdline_parse_inst_t cmd_set_port_setup_on = {
> struct cmd_operate_attach_port_result {
> cmdline_fixed_string_t port;
> cmdline_fixed_string_t keyword;
> - cmdline_fixed_string_t identifier;
> + cmdline_multi_string_t identifier;
> };
>
> static void cmd_operate_attach_port_parsed(void *parsed_result,
> @@ -1469,7 +1469,7 @@ cmdline_parse_token_string_t cmd_operate_attach_port_keyword =
> keyword, "attach");
> cmdline_parse_token_string_t cmd_operate_attach_port_identifier =
> TOKEN_STRING_INITIALIZER(struct cmd_operate_attach_port_result,
> - identifier, NULL);
> + identifier, TOKEN_STRING_MULTI);
>
> cmdline_parse_inst_t cmd_operate_attach_port = {
> .f = cmd_operate_attach_port_parsed,
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-stable] [PATCH] app/testpmd: fix identifier size for port attach
2020-02-20 12:28 ` [dpdk-stable] " Ferruh Yigit
@ 2020-02-20 12:32 ` Wisam Monther
0 siblings, 0 replies; 6+ messages in thread
From: Wisam Monther @ 2020-02-20 12:32 UTC (permalink / raw)
To: Ferruh Yigit, wenzhuo.lu, dev, Raslan Darawsheh, Matan Azrad
Cc: mukawa, stable
When attaching new device, it needs to pass the white list options with the PCI,
For example if I want the following set of options with the new attach device it will fail
Due to not enough space:
port attach 0000:03:00.0,l3_vxlan_en=1,txq_inline_mpw=77,dv_xmeta_en=1,txqs_min_inline=0,dv_esw_en=1,dv_flow_en=1,txq_inline_min=28,txq_inline_max=65
-----Original Message-----
From: Ferruh Yigit <ferruh.yigit@intel.com>
Sent: Thursday, February 20, 2020 2:28 PM
To: Wisam Monther <wisamm@mellanox.com>; wenzhuo.lu@intel.com; dev@dpdk.org; Raslan Darawsheh <rasland@mellanox.com>; Matan Azrad <matan@mellanox.com>
Cc: mukawa@igel.co.jp; stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] app/testpmd: fix identifier size for port attach
On 2/19/2020 4:47 PM, Wisam Jaddo wrote:
> Identifier for new port may contain white list options, and white list
> options will not fit into 128 from STR_TOKEN_SIZE, instead having 4096
> char from STR_MULTI_TOKEN_SIZE will provide better and more options
Out of curiosity, what device identifier doesn't fit to 128 chars, can you please give a sample?
>
> Fixes: edab33b1c01d ("app/testpmd: support port hotplug")
> Cc: mukawa@igel.co.jp
> Cc: stable@dpdk.org
>
> Signed-off-by: Wisam Jaddo <wisamm@mellanox.com>
> ---
> app/test-pmd/cmdline.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
> 38b6d80..a037a55 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -1446,7 +1446,7 @@ cmdline_parse_inst_t cmd_set_port_setup_on = {
> struct cmd_operate_attach_port_result {
> cmdline_fixed_string_t port;
> cmdline_fixed_string_t keyword;
> - cmdline_fixed_string_t identifier;
> + cmdline_multi_string_t identifier;
> };
>
> static void cmd_operate_attach_port_parsed(void *parsed_result, @@
> -1469,7 +1469,7 @@ cmdline_parse_token_string_t cmd_operate_attach_port_keyword =
> keyword, "attach");
> cmdline_parse_token_string_t cmd_operate_attach_port_identifier =
> TOKEN_STRING_INITIALIZER(struct cmd_operate_attach_port_result,
> - identifier, NULL);
> + identifier, TOKEN_STRING_MULTI);
>
> cmdline_parse_inst_t cmd_operate_attach_port = {
> .f = cmd_operate_attach_port_parsed,
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-stable] [PATCH] app/testpmd: fix identifier size for port attach
@ 2020-02-19 16:45 Wisam Jaddo
0 siblings, 0 replies; 6+ messages in thread
From: Wisam Jaddo @ 2020-02-19 16:45 UTC (permalink / raw)
To: wenzhuo.lu, rasland, matan; +Cc: mukawa, stable
Identifier for new port may contain white list options,
and white list options will not fit into 128 from STR_TOKEN_SIZE,
instead having 4096 char from STR_MULTI_TOKEN_SIZE will provide
better and more options
Fixes: edab33b1c01d ("app/testpmd: support port hotplug")
Cc: mukawa@igel.co.jp
Cc: stable@dpdk.org
Signed-off-by: Wisam Jaddo <wisamm@mellanox.com>
---
app/test-pmd/cmdline.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 38b6d80..a037a55 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -1446,7 +1446,7 @@ cmdline_parse_inst_t cmd_set_port_setup_on = {
struct cmd_operate_attach_port_result {
cmdline_fixed_string_t port;
cmdline_fixed_string_t keyword;
- cmdline_fixed_string_t identifier;
+ cmdline_multi_string_t identifier;
};
static void cmd_operate_attach_port_parsed(void *parsed_result,
@@ -1469,7 +1469,7 @@ cmdline_parse_token_string_t cmd_operate_attach_port_keyword =
keyword, "attach");
cmdline_parse_token_string_t cmd_operate_attach_port_identifier =
TOKEN_STRING_INITIALIZER(struct cmd_operate_attach_port_result,
- identifier, NULL);
+ identifier, TOKEN_STRING_MULTI);
cmdline_parse_inst_t cmd_operate_attach_port = {
.f = cmd_operate_attach_port_parsed,
--
2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-02-20 14:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-19 16:47 [dpdk-stable] [PATCH] app/testpmd: fix identifier size for port attach Wisam Jaddo
2020-02-20 10:03 ` [dpdk-stable] [dpdk-dev] " Iremonger, Bernard
2020-02-20 14:18 ` Ferruh Yigit
2020-02-20 12:28 ` [dpdk-stable] " Ferruh Yigit
2020-02-20 12:32 ` Wisam Monther
-- strict thread matches above, loose matches on Subject: below --
2020-02-19 16:45 Wisam Jaddo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).