* [dpdk-stable] [PATCH 19.11] net/bnxt: fix logical AND in if condition
@ 2020-07-29 13:21 Kalesh A P
2020-08-06 10:00 ` Luca Boccassi
0 siblings, 1 reply; 2+ messages in thread
From: Kalesh A P @ 2020-07-29 13:21 UTC (permalink / raw)
To: stable; +Cc: luca.boccassi, ajit.khaparde
From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
[ upstream commit 90c957ef3b11f361dd8e6519d9e195f01295b23e ]
The if condition in bnxt_restore_mac_filters needs to check for
the result of logical AND. But it was not doing it resulting in
an incorrect check.
Fixes: b02f1573cd07 ("net/bnxt: restore MAC filters during reset recovery")
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
---
drivers/net/bnxt/bnxt_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index f1bd575..4c64525 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -3950,7 +3950,7 @@ static int bnxt_restore_mac_filters(struct bnxt *bp)
uint16_t i;
int rc;
- if (BNXT_VF(bp) & !BNXT_VF_IS_TRUSTED(bp))
+ if (BNXT_VF(bp) && !BNXT_VF_IS_TRUSTED(bp))
return 0;
rc = bnxt_dev_info_get_op(dev, &dev_info);
--
2.10.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-stable] [PATCH 19.11] net/bnxt: fix logical AND in if condition
2020-07-29 13:21 [dpdk-stable] [PATCH 19.11] net/bnxt: fix logical AND in if condition Kalesh A P
@ 2020-08-06 10:00 ` Luca Boccassi
0 siblings, 0 replies; 2+ messages in thread
From: Luca Boccassi @ 2020-08-06 10:00 UTC (permalink / raw)
To: Kalesh A P, stable; +Cc: ajit.khaparde
On Wed, 2020-07-29 at 18:51 +0530, Kalesh A P wrote:
> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
>
> [ upstream commit 90c957ef3b11f361dd8e6519d9e195f01295b23e ]
>
> The if condition in bnxt_restore_mac_filters needs to check for
> the result of logical AND. But it was not doing it resulting in
> an incorrect check.
>
> Fixes: b02f1573cd07 ("net/bnxt: restore MAC filters during reset recovery")
>
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> ---
> drivers/net/bnxt/bnxt_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
> index f1bd575..4c64525 100644
> --- a/drivers/net/bnxt/bnxt_ethdev.c
> +++ b/drivers/net/bnxt/bnxt_ethdev.c
> @@ -3950,7 +3950,7 @@ static int bnxt_restore_mac_filters(struct bnxt *bp)
> uint16_t i;
> int rc;
>
> - if (BNXT_VF(bp) & !BNXT_VF_IS_TRUSTED(bp))
> + if (BNXT_VF(bp) && !BNXT_VF_IS_TRUSTED(bp))
> return 0;
>
> rc = bnxt_dev_info_get_op(dev, &dev_info);
Thanks, applied and pushed.
--
Kind regards,
Luca Boccassi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-06 10:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-29 13:21 [dpdk-stable] [PATCH 19.11] net/bnxt: fix logical AND in if condition Kalesh A P
2020-08-06 10:00 ` Luca Boccassi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).