From: "Guo, Jia" <jia.guo@intel.com>
To: "Di, ChenxuX" <chenxux.di@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Xing, Beilei" <beilei.xing@intel.com>,
"Wang, Haiyue" <haiyue.wang@intel.com>,
"Di, ChenxuX" <chenxux.di@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH 1/2] net/i40e: fix incorrect FDIR flex mask
Date: Wed, 4 Nov 2020 09:40:33 +0000 [thread overview]
Message-ID: <fd486cce9b50430183d901133f734842@intel.com> (raw)
In-Reply-To: <20201104082959.63800-2-chenxux.di@intel.com>
Hi, chenxu
> -----Original Message-----
> From: Chenxu Di <chenxux.di@intel.com>
> Sent: Wednesday, November 4, 2020 4:30 PM
> To: dev@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>; Guo, Jia <jia.guo@intel.com>; Wang,
> Haiyue <haiyue.wang@intel.com>; Di, ChenxuX <chenxux.di@intel.com>;
> stable@dpdk.org
> Subject: [PATCH 1/2] net/i40e: fix incorrect FDIR flex mask
>
> The register of FDIR flex mask should not be set during flow validate.
> It should be set when flow create.
>
> Fixes: 6ced3dd72f5f ("net/i40e: support flexible payload parsing for FDIR")
Seems that you move the place of flexible payload parsing from flow validate to create, you delete something but miss some useless parameter deleting,
such as " off_arr/len_arr" etc in this [PATCH 1/2] or [PATCH 2/3]. Please double check if anything related remove and if you want you could merge into 1 remove patch if it could be.
> Cc: stable@dpdk.org
>
> Signed-off-by: Chenxu Di <chenxux.di@intel.com>
> ---
> drivers/net/i40e/i40e_ethdev.h | 1 +
> drivers/net/i40e/i40e_fdir.c | 94 ++++++++++++++++++++++++++++++++
> drivers/net/i40e/i40e_flow.c | 97 +---------------------------------
> 3 files changed, 97 insertions(+), 95 deletions(-)
>
<...>
next prev parent reply other threads:[~2020-11-04 9:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201104082959.63800-1-chenxux.di@intel.com>
2020-11-04 8:29 ` Chenxu Di
2020-11-04 9:40 ` Guo, Jia [this message]
2020-11-04 8:29 ` [dpdk-stable] [PATCH 2/2] net/i40e: fix incorrect FDIR flex pit Chenxu Di
2020-11-04 9:18 ` Guo, Jia
2020-11-06 6:47 ` [dpdk-stable] [PATCH v2] net/i40e: fix incorrect FDIR flex configuration Chenxu Di
2020-11-09 3:23 ` [dpdk-stable] [dpdk-dev] " Zhou, JunX W
2020-11-10 5:42 ` [dpdk-stable] [PATCH v3] " Chenxu Di
2020-11-10 6:54 ` Guo, Jia
2020-11-10 7:08 ` [dpdk-stable] [PATCH v4] " Chenxu Di
2020-11-10 8:27 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd486cce9b50430183d901133f734842@intel.com \
--to=jia.guo@intel.com \
--cc=beilei.xing@intel.com \
--cc=chenxux.di@intel.com \
--cc=dev@dpdk.org \
--cc=haiyue.wang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).