[dpdk-test-report] |WARNING| pw69680 [PATCH 3/8] trace: simplify trace point headers

[dpdk-test-report] |WARNING| pw69680 [PATCH 3/8] trace: simplify trace point headers

[checkpatch]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/69680

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#322: FILE: lib/librte_eal/include/rte_trace_point.h:343:
+#define __rte_trace_point_emit_header_generic(t) \
+void *mem; \
+do { \
+	const uint64_t val = __atomic_load_n(t, __ATOMIC_ACQUIRE); \
+	if (likely(!(val & __RTE_TRACE_FIELD_ENABLE_MASK))) \
+		return; \
+	mem = __rte_trace_mem_get(val); \
+	if (unlikely(mem == NULL)) \
+		return; \
+	mem = __rte_trace_point_emit_ev_header(mem, val); \
+} while (0)

ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects
#334: FILE: lib/librte_eal/include/rte_trace_point.h:355:
+#define __rte_trace_point_emit_header_fp(t) \
+	if (!__rte_trace_point_fp_is_enabled()) \
+		return; \
+	__rte_trace_point_emit_header_generic(t)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#334: FILE: lib/librte_eal/include/rte_trace_point.h:355:
+#define __rte_trace_point_emit_header_fp(t) \
+	if (!__rte_trace_point_fp_is_enabled()) \
+		return; \
+	__rte_trace_point_emit_header_generic(t)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#345: FILE: lib/librte_eal/include/rte_trace_point.h:366:
+#define rte_trace_point_emit_string(in) \
+do { \
+	if (unlikely(in == NULL)) \
+		return; \
+	rte_strscpy(mem, in, __RTE_TRACE_EMIT_STRING_LEN_MAX); \
+	mem = RTE_PTR_ADD(mem, __RTE_TRACE_EMIT_STRING_LEN_MAX); \
+} while (0)

total: 1 errors, 3 warnings, 284 lines checked