automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Arek Kusztal <arkadiuszx.kusztal@intel.com>
Subject: [dpdk-test-report] |WARNING| pw72156 [PATCH v2] examples: add multi process crypto application
Date: Wed, 24 Jun 2020 16:24:34 +0200 (CEST)
Message-ID: <20200624142434.B40E81D9A0@dpdk.org> (raw)
In-Reply-To: <20200624142344.3152-1-arkadiuszx.kusztal@intel.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/72156

_coding style issues_

Must be a reply to the first patch (--in-reply-to).


ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#346: FILE: examples/mp_crypto/main.c:16:
+int
+mp_crypto_init_devs(void) {

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 32)
#566: FILE: examples/mp_crypto/main.c:236:
+		if (mp_app_params->enq_param.vector_number[i] >=
[...]
+				MP_APP_LOG(ERR, COL_RED,

WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#598: FILE: examples/mp_crypto/main.c:268:
+					"Session %d not yet created.
 - Press 'w' to wait until other process will create it 
 - Press 'n' to create local session",

WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#708: FILE: examples/mp_crypto/main.c:378:
+						while (__timeout <= __counter) {

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 32)
#748: FILE: examples/mp_crypto/main.c:418:
+		for (qp_id = last_qp_on_device; qp_id < MP_APP_QUEUE_PAIRS_NUM;
[...]
+				if (mp_app_devs[dev_id].queue_pair_flag[qp_id]

WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'mp_app_init', this function's name, in a string
#1008: FILE: examples/mp_crypto/main.c:678:
+				"mp_app_init: cannot create memzone for process");

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#1192: FILE: examples/mp_crypto/main.c:862:
+			break;
+		else

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#1204: FILE: examples/mp_crypto/main.c:874:
+			break;
+		else

WARNING:LONG_LINE: line over 90 characters
#1241: FILE: examples/mp_crypto/main.c:911:
+							livesign_print_char[livesign_print_idx]);

WARNING:LONG_LINE: line over 90 characters
#1247: FILE: examples/mp_crypto/main.c:917:
+						livesign_print_char[livesign_deq_print_idx]);

WARNING:LONG_LINE: line over 90 characters
#1280: FILE: examples/mp_crypto/main.c:950:
+						livesign_print_char[livesign_deq_print_idx]);

WARNING:LONG_LINE: line over 90 characters
#1286: FILE: examples/mp_crypto/main.c:956:
+						livesign_print_char[livesign_deq_print_idx]);

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'session_vectors[vectors[vector_number].session'
#1573: FILE: examples/mp_crypto/mp_crypto.c:104:
+		RTE_ALIGN_CEIL(session_vectors[vectors[vector_number].
+				session].aad_len, 16);

WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#1910: FILE: examples/mp_crypto/mp_crypto_parser.c:28:
+	" across all processes. 
						--Example: --devtype=crypto_qat"

WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#1914: FILE: examples/mp_crypto/mp_crypto_parser.c:32:
+	" first. 
						--Example: -w 03:01.2 -w 03:01.1 -w 03:01.3 --config-dev 0,2"

ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#1955: FILE: examples/mp_crypto/mp_crypto_parser.c:73:
+static void dump_test_data_options(struct mp_crypto_app_parameters
+	*test_data __rte_unused) {

ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#1959: FILE: examples/mp_crypto/mp_crypto_parser.c:77:
+int16_t
+get_options(int argc, char *argv[]) {

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#2425: FILE: examples/mp_crypto/mp_crypto_parser.h:26:
+	do {		\
+	printf("%s", color);			\

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#2432: FILE: examples/mp_crypto/mp_crypto_parser.h:33:
+	do {		\
+	printf("%s", color);			\

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#2439: FILE: examples/mp_crypto/mp_crypto_parser.h:40:
+	do {		\
+	printf("
%s", color);			\

total: 3 errors, 17 warnings, 2641 lines checked

       reply	other threads:[~2020-06-24 14:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200624142344.3152-1-arkadiuszx.kusztal@intel.com>
2020-06-24 14:24 ` checkpatch [this message]
2020-06-24 21:15 ` [dpdk-test-report] |SUCCESS| pw72156 " 0-day Robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200624142434.B40E81D9A0@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=arkadiuszx.kusztal@intel.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

automatic DPDK test reports

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/test-report/0 test-report/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 test-report test-report/ https://inbox.dpdk.org/test-report \
		test-report@dpdk.org
	public-inbox-index test-report

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.test-report


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git