automatic DPDK test reports
 help / color / mirror / Atom feed
* [dpdk-test-report] |WARNING| pw86376 [RFC] eal: add fair reader writer lock
       [not found] <20210112060524.409412-1-stephen@networkplumber.org>
@ 2021-01-12  6:05 ` checkpatch
  0 siblings, 0 replies; only message in thread
From: checkpatch @ 2021-01-12  6:05 UTC (permalink / raw)
  To: test-report; +Cc: Stephen Hemminger

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/86376

_coding style issues_


ERROR:SPACING: spaces required around that '=' (ctx:VxV)
#340: FILE: app/test/test_fair_rwlock.c:185:
+	for (i=0; i<RTE_MAX_LCORE; i++)
 	      ^

ERROR:SPACING: spaces required around that '<' (ctx:VxV)
#340: FILE: app/test/test_fair_rwlock.c:185:
+	for (i=0; i<RTE_MAX_LCORE; i++)
 	           ^

WARNING:TYPO_SPELLING: 'reverese' may be misspelled - perhaps 'reverse'?
#410: FILE: app/test/test_fair_rwlock.c:255:
+	/* update by bytes in reverese order */

WARNING:TYPO_SPELLING: 'reverese' may be misspelled - perhaps 'reverse'?
#427: FILE: app/test/test_fair_rwlock.c:272:
+	/* restore by bytes in reverese order */

WARNING:TYPO_SPELLING: 'avaialble' may be misspelled - perhaps 'available'?
#619: FILE: app/test/test_fair_rwlock.c:464:
+	/* start read test on all avaialble lcores */

ERROR:CODE_INDENT: code indent should use tabs where possible
#799: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:31:
+        rte_ticketlock_t writer;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#799: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:31:
+        rte_ticketlock_t writer;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#800: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:32:
+        uint16_t readers;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#800: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:32:
+        uint16_t readers;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#821: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:53:
+        rte_ticketlock_init(&rwl->writer);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#821: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:53:
+        rte_ticketlock_init(&rwl->writer);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#822: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:54:
+        rwl->readers = 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#822: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:54:
+        rwl->readers = 0;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#839: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:71:
+        __atomic_fetch_add(&rwl->readers, 1, __ATOMIC_ACQUIRE);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#839: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:71:
+        __atomic_fetch_add(&rwl->readers, 1, __ATOMIC_ACQUIRE);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#841: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:73:
+        /* If a writer raced in and got the lock, we need to back out. */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#842: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:74:
+        if (rte_ticketlock_is_locked(&rwl->writer)) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#842: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:74:
+        if (rte_ticketlock_is_locked(&rwl->writer)) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#843: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:75:
+                /* Drop our reference so the Writer can continue */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#844: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:76:
+                __atomic_sub_fetch(&rwl->readers, 1, __ATOMIC_RELEASE);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#844: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:76:
+                __atomic_sub_fetch(&rwl->readers, 1, __ATOMIC_RELEASE);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#846: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:78:
+                /* Wait for the Writer to finish then get our new reference */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#847: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:79:
+                rte_ticketlock_lock(&rwl->writer);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#847: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:79:
+                rte_ticketlock_lock(&rwl->writer);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#848: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:80:
+                __atomic_add_fetch(&rwl->readers, 1, __ATOMIC_ACQUIRE);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#848: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:80:
+                __atomic_add_fetch(&rwl->readers, 1, __ATOMIC_ACQUIRE);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#849: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:81:
+                rte_ticketlock_unlock(&rwl->writer);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#849: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:81:
+                rte_ticketlock_unlock(&rwl->writer);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#850: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:82:
+        }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#850: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:82:
+        }$

ERROR:CODE_INDENT: code indent should use tabs where possible
#871: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:103:
+        /* Get our reference count */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#872: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:104:
+        __atomic_fetch_add(&rwl->readers, 1, __ATOMIC_ACQUIRE);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#872: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:104:
+        __atomic_fetch_add(&rwl->readers, 1, __ATOMIC_ACQUIRE);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#874: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:106:
+        /* If a writer has the lock, we need to back out. */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#875: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:107:
+        if (rte_ticketlock_is_locked(&rwl->writer)) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#875: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:107:
+        if (rte_ticketlock_is_locked(&rwl->writer)) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#876: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:108:
+                __atomic_sub_fetch(&rwl->readers, 1, __ATOMIC_RELEASE);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#876: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:108:
+                __atomic_sub_fetch(&rwl->readers, 1, __ATOMIC_RELEASE);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#877: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:109:
+                return -EBUSY;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#877: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:109:
+                return -EBUSY;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#878: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:110:
+        }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#878: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:110:
+        }$

ERROR:CODE_INDENT: code indent should use tabs where possible
#896: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:128:
+        __atomic_fetch_sub(&rwl->readers, 1, __ATOMIC_RELEASE);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#896: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:128:
+        __atomic_fetch_sub(&rwl->readers, 1, __ATOMIC_RELEASE);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#912: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:144:
+        /* Wait for our turn to be writer */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#913: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:145:
+        rte_ticketlock_lock(&rwl->writer);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#913: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:145:
+        rte_ticketlock_lock(&rwl->writer);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#915: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:147:
+        /* Wait for all outstanding readers */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#938: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:170:
+        if (!rte_ticketlock_trylock(&rwl->writer))$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#938: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:170:
+        if (!rte_ticketlock_trylock(&rwl->writer))$

ERROR:CODE_INDENT: code indent should use tabs where possible
#939: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:171:
+                return -EBUSY;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#939: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:171:
+                return -EBUSY;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#943: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:175:
+                rte_ticketlock_unlock(&rwl->writer);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#943: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:175:
+                rte_ticketlock_unlock(&rwl->writer);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#944: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:176:
+                return -EBUSY;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#944: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:176:
+                return -EBUSY;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#945: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:177:
+        }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#945: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:177:
+        }$

ERROR:CODE_INDENT: code indent should use tabs where possible
#963: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:195:
+        /* Unblock readers */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#964: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:196:
+        rte_ticketlock_unlock(&rwl->writer);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#964: FILE: lib/librte_eal/include/generic/rte_fair_rwlock.h:196:
+        rte_ticketlock_unlock(&rwl->writer);$

total: 34 errors, 27 warnings, 880 lines checked
Warning in app/test/test_fair_rwlock.c:
Using rte_atomicNN_xxx

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-01-12  6:06 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20210112060524.409412-1-stephen@networkplumber.org>
2021-01-12  6:05 ` [dpdk-test-report] |WARNING| pw86376 [RFC] eal: add fair reader writer lock checkpatch

automatic DPDK test reports

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/test-report/0 test-report/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 test-report test-report/ https://inbox.dpdk.org/test-report \
		test-report@dpdk.org
	public-inbox-index test-report

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.test-report


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git